fix(plugin-typescript): refined logic and types

Author: BioPhoton

packages/plugin-typescript/src/lib/runner/runner.ts

@@ -1,7 +1,6 @@
 import type {
   AuditOutput,
   AuditOutputs,
-  AuditReport,
   Issue,
   RunnerFunction,
 } from '@code-pushup/models';
@@ -11,7 +10,7 @@ import {
   getTypeScriptDiagnostics,
 } from './ts-runner.js';
 import type { CodeRangeName } from './types.js';
-import { getIssueFromDiagnostic, tSCodeToAuditSlug } from './utils.js';
+import { getIssueFromDiagnostic, tsCodeToAuditSlug } from './utils.js';
 
 export type RunnerOptions = DiagnosticsOptions & {
   expectedAudits: { slug: AuditSlug }[];
@@ -21,28 +20,22 @@ export function createRunnerFunction(options: RunnerOptions): RunnerFunction {
   const { tsconfig, expectedAudits } = options;
   return async (): Promise<AuditOutputs> => {
     const diagnostics = await getTypeScriptDiagnostics({ tsconfig });
-    const result: Record<
-      CodeRangeName,
-      Pick<AuditReport, 'slug' | 'details'>
-    > = diagnostics.reduce(
-      (acc, diag) => {
-        const slug = tSCodeToAuditSlug(diag.code);
-        const existingIssues: Issue[] = acc[slug]?.details?.issues ?? [];
-        return {
-          ...acc,
-          [slug]: {
-            slug,
-            details: {
-              issues: [...existingIssues, getIssueFromDiagnostic(diag)],
-            },
+    const result = diagnostics.reduce<
+      Partial<Record<CodeRangeName, Pick<AuditOutput, 'slug' | 'details'>>>
+    >((acc, diag) => {
+      const slug = tsCodeToAuditSlug(diag.code);
+      const existingIssues: Issue[] =
+        (acc[slug] && acc[slug].details?.issues) || ([] as Issue[]);
+      return {
+        ...acc,
+        [slug]: {
+          slug,
+          details: {
+            issues: [...existingIssues, getIssueFromDiagnostic(diag)],
           },
-        };
-      },
-      {} as unknown as Record<
-        CodeRangeName,
-        Pick<AuditOutput, 'slug' | 'details'>
-      >,
-    );
+        },
+      };
+    }, {});
 
     return expectedAudits.map(({ slug }) => {
       const { details } = result[slug] ?? {};

packages/plugin-typescript/src/lib/runner/ts-runner.ts

@@ -3,6 +3,7 @@ import {
   createProgram,
   getPreEmitDiagnostics,
 } from 'typescript';
+import { stringifyError } from '@code-pushup/utils';
 import { loadTargetConfig } from './utils.js';
 
 export type DiagnosticsOptions = {
@@ -15,11 +16,10 @@ export async function getTypeScriptDiagnostics({
   const { fileNames, options } = await loadTargetConfig(tsconfig);
   try {
     const program = createProgram(fileNames, options);
-    // @TODO use more fine-grained helpers like getSemanticDiagnostics instead of getPreEmitDiagnostics
     return getPreEmitDiagnostics(program);
   } catch (error) {
     throw new Error(
-      `Can't create TS program in getDiagnostics. \n ${(error as Error).message}`,
+      `Can't create TS program in getDiagnostics. \n ${stringifyError(error)}`,
     );
   }
 }

packages/plugin-typescript/src/lib/runner/utils.ts

@@ -19,7 +19,7 @@ import type { CodeRangeName } from './types.js';
  * @returns The audit slug.
  * @throws Error if the code is not supported.
  */
-export function tSCodeToAuditSlug(code: number): CodeRangeName {
+export function tsCodeToAuditSlug(code: number): CodeRangeName {
   const rangeNumber = code
     .toString()
     .slice(0, 1) as keyof typeof TS_CODE_RANGE_NAMES;