refactor: fix unicorn/import-style lint warnings for node:path imports

Author: matejchalk

docs/e2e.md

@@ -144,14 +144,14 @@ export default defineConfig({
 
 // to avoid port conflicts ever E2E targets has a unique port
 const uniquePort = 6000 + Math.round(Math.random() * 1000);
-const e2eDir = join('tmp', 'e2e');
+const e2eDir = path.join('tmp', 'e2e');
 
 export async function setup() {
   // start local verdaccio registry
   const { registry } = await startLocalRegistry({
     localRegistryTarget: '@code-pushup/cli-source:start-verdaccio',
     // to avoid file system conflicts ever E2E targets has a unique storage folder
-    storage: join(join(e2eDir, `registry-${uniquePort}`), 'storage'),
+    storage: path.join(path.join(e2eDir, `registry-${uniquePort}`), 'storage'),
     port: uniquePort,
   });
 

e2e/ci-e2e/tests/ci.e2e.test.ts

@@ -1,5 +1,5 @@
 import { cp, readFile, rename } from 'node:fs/promises';
-import { dirname, join } from 'node:path';
+import path from 'node:path';
 import { fileURLToPath } from 'node:url';
 import {
   type DiffResult,
@@ -26,21 +26,21 @@ import {
 } from '@code-pushup/test-utils';
 
 describe('CI package', () => {
-  const fixturesDir = join(
-    fileURLToPath(dirname(import.meta.url)),
+  const fixturesDir = path.join(
+    fileURLToPath(path.dirname(import.meta.url)),
     '..',
     'mocks',
     'fixtures',
     'ci-test-repo',
   );
-  const ciSetupRepoDir = join(
+  const ciSetupRepoDir = path.join(
     process.cwd(),
     E2E_ENVIRONMENTS_DIR,
     nxTargetProject(),
     TEST_OUTPUT_DIR,
     'ci-test-repo',
   );
-  const outputDir = join(ciSetupRepoDir, '.code-pushup');
+  const outputDir = path.join(ciSetupRepoDir, '.code-pushup');
 
   const options = {
     directory: ciSetupRepoDir,
@@ -91,14 +91,14 @@ describe('CI package', () => {
           report: {
             rootDir: outputDir,
             files: [
-              join(outputDir, 'report.json'),
-              join(outputDir, 'report.md'),
+              path.join(outputDir, 'report.json'),
+              path.join(outputDir, 'report.md'),
             ],
           },
         },
       } satisfies RunResult);
 
-      const jsonPromise = readFile(join(outputDir, 'report.json'), 'utf8');
+      const jsonPromise = readFile(path.join(outputDir, 'report.json'), 'utf8');
       await expect(jsonPromise).resolves.toBeTruthy();
       const report = JSON.parse(await jsonPromise) as Report;
       expect(report).toEqual(
@@ -138,8 +138,8 @@ describe('CI package', () => {
       await git.checkoutLocalBranch('feature-1');
 
       await rename(
-        join(ciSetupRepoDir, 'index.js'),
-        join(ciSetupRepoDir, 'index.ts'),
+        path.join(ciSetupRepoDir, 'index.js'),
+        path.join(ciSetupRepoDir, 'index.ts'),
       );
 
       await git.add('index.ts');
@@ -160,26 +160,29 @@ describe('CI package', () => {
           report: {
             rootDir: outputDir,
             files: [
-              join(outputDir, 'report.json'),
-              join(outputDir, 'report.md'),
+              path.join(outputDir, 'report.json'),
+              path.join(outputDir, 'report.md'),
             ],
           },
           diff: {
             rootDir: outputDir,
             files: [
-              join(outputDir, 'report-diff.json'),
-              join(outputDir, 'report-diff.md'),
+              path.join(outputDir, 'report-diff.json'),
+              path.join(outputDir, 'report-diff.md'),
             ],
           },
         },
       } satisfies RunResult);
 
-      const mdPromise = readFile(join(outputDir, 'report-diff.md'), 'utf8');
+      const mdPromise = readFile(
+        path.join(outputDir, 'report-diff.md'),
+        'utf8',
+      );
       await expect(mdPromise).resolves.toBeTruthy();
       const md = await mdPromise;
       await expect(
         md.replace(/[\da-f]{40}/g, '`<commit-sha>`'),
-      ).toMatchFileSnapshot(join(TEST_SNAPSHOTS_DIR, 'report-diff.md'));
+      ).toMatchFileSnapshot(path.join(TEST_SNAPSHOTS_DIR, 'report-diff.md'));
     });
   });
 });

e2e/cli-e2e/mocks/fixtures/dummy-setup/dummy.plugin.ts

@@ -1,5 +1,5 @@
 import { readFile } from 'node:fs/promises';
-import { join } from 'node:path';
+import path from 'node:path';
 import type { PluginConfig } from '@code-pushup/models';
 
 export const dummyPluginSlug = 'dummy-plugin';
@@ -32,7 +32,7 @@ export function create(): PluginConfig {
     description: 'A dummy plugin to test the cli.',
     runner: async () => {
       const itemCount = JSON.parse(
-        await readFile(join('src', 'items.json'), 'utf-8'),
+        await readFile(path.join('src', 'items.json'), 'utf-8'),
       ).length;
       return [
         {

e2e/cli-e2e/mocks/fixtures/existing-reports/dummy.plugin.ts

@@ -1,5 +1,5 @@
 import { readFile } from 'node:fs/promises';
-import { join } from 'node:path';
+import path from 'node:path';
 import type { PluginConfig } from '@code-pushup/models';
 
 export const dummyPluginSlug = 'dummy-plugin';
@@ -32,7 +32,7 @@ export function create(): PluginConfig {
     description: 'A dummy plugin to test the cli.',
     runner: async () => {
       const itemCount = JSON.parse(
-        await readFile(join('src', 'items.json'), 'utf-8'),
+        await readFile(path.join('src', 'items.json'), 'utf-8'),
       ).length;
       return [
         {

e2e/cli-e2e/tests/collect.e2e.test.ts

@@ -1,5 +1,5 @@
 import { cp } from 'node:fs/promises';
-import { join } from 'node:path';
+import path from 'node:path';
 import { afterEach, beforeAll, describe, expect, it } from 'vitest';
 import { nxTargetProject } from '@code-pushup/test-nx-utils';
 import { teardownTestFolder } from '@code-pushup/test-setup';
@@ -9,21 +9,21 @@ import { executeProcess, readTextFile } from '@code-pushup/utils';
 describe('CLI collect', () => {
   const dummyPluginTitle = 'Dummy Plugin';
   const dummyAuditTitle = 'Dummy Audit';
-  const fixtureDummyDir = join(
+  const fixtureDummyDir = path.join(
     'e2e',
     nxTargetProject(),
     'mocks',
     'fixtures',
     'dummy-setup',
   );
-  const testFileDir = join(
+  const testFileDir = path.join(
     E2E_ENVIRONMENTS_DIR,
     nxTargetProject(),
     TEST_OUTPUT_DIR,
     'collect',
   );
-  const dummyDir = join(testFileDir, 'dummy-setup');
-  const dummyOutputDir = join(dummyDir, '.code-pushup');
+  const dummyDir = path.join(testFileDir, 'dummy-setup');
+  const dummyOutputDir = path.join(dummyDir, '.code-pushup');
 
   beforeAll(async () => {
     await cp(fixtureDummyDir, dummyDir, { recursive: true });
@@ -52,7 +52,7 @@ describe('CLI collect', () => {
     expect(code).toBe(0);
     expect(stderr).toBe('');
 
-    const md = await readTextFile(join(dummyOutputDir, 'report.md'));
+    const md = await readTextFile(path.join(dummyOutputDir, 'report.md'));
 
     expect(md).toContain('# Code PushUp Report');
     expect(md).toContain(dummyPluginTitle);

e2e/cli-e2e/tests/compare.e2e.test.ts

@@ -1,5 +1,5 @@
 import { cp } from 'node:fs/promises';
-import { join } from 'node:path';
+import path from 'node:path';
 import { beforeAll } from 'vitest';
 import type { ReportsDiff } from '@code-pushup/models';
 import { nxTargetProject } from '@code-pushup/test-nx-utils';
@@ -8,22 +8,22 @@ import { E2E_ENVIRONMENTS_DIR, TEST_OUTPUT_DIR } from '@code-pushup/test-utils';
 import { executeProcess, readJsonFile, readTextFile } from '@code-pushup/utils';
 
 describe('CLI compare', () => {
-  const fixtureDummyDir = join(
+  const fixtureDummyDir = path.join(
     'e2e',
     nxTargetProject(),
     'mocks',
     'fixtures',
     'existing-reports',
   );
 
-  const testFileDir = join(
+  const testFileDir = path.join(
     E2E_ENVIRONMENTS_DIR,
     nxTargetProject(),
     TEST_OUTPUT_DIR,
     'compare',
   );
-  const existingDir = join(testFileDir, 'existing-reports');
-  const existingOutputDir = join(existingDir, '.code-pushup');
+  const existingDir = path.join(testFileDir, 'existing-reports');
+  const existingOutputDir = path.join(existingDir, '.code-pushup');
 
   beforeAll(async () => {
     await cp(fixtureDummyDir, existingDir, { recursive: true });
@@ -39,14 +39,14 @@ describe('CLI compare', () => {
       args: [
         '@code-pushup/cli',
         'compare',
-        `--before=${join('.code-pushup', 'source-report.json')}`,
-        `--after=${join('.code-pushup', 'target-report.json')}`,
+        `--before=${path.join('.code-pushup', 'source-report.json')}`,
+        `--after=${path.join('.code-pushup', 'target-report.json')}`,
       ],
       cwd: existingDir,
     });
 
     const reportsDiff = await readJsonFile<ReportsDiff>(
-      join(existingOutputDir, 'report-diff.json'),
+      path.join(existingOutputDir, 'report-diff.json'),
     );
     expect(reportsDiff).toMatchSnapshot({
       commits: expect.any(Object),
@@ -56,7 +56,7 @@ describe('CLI compare', () => {
     });
 
     const reportsDiffMd = await readTextFile(
-      join(existingOutputDir, 'report-diff.md'),
+      path.join(existingOutputDir, 'report-diff.md'),
     );
     // commits are variable, replace SHAs with placeholders
     const sanitizedMd = reportsDiffMd.replace(/[\da-f]{40}/g, '`<commit-sha>`');

e2e/cli-e2e/tests/help.e2e.test.ts

@@ -1,4 +1,4 @@
-import { join } from 'node:path';
+import path from 'node:path';
 import { nxTargetProject } from '@code-pushup/test-nx-utils';
 import {
   E2E_ENVIRONMENTS_DIR,
@@ -7,7 +7,7 @@ import {
 import { executeProcess } from '@code-pushup/utils';
 
 describe('CLI help', () => {
-  const envRoot = join(E2E_ENVIRONMENTS_DIR, nxTargetProject());
+  const envRoot = path.join(E2E_ENVIRONMENTS_DIR, nxTargetProject());
 
   it('should print help with help command', async () => {
     const { code, stdout, stderr } = await executeProcess({

e2e/cli-e2e/tests/print-config.e2e.test.ts

@@ -1,5 +1,5 @@
 import { cp } from 'node:fs/promises';
-import { join } from 'node:path';
+import path from 'node:path';
 import { beforeAll, expect } from 'vitest';
 import { nxTargetProject } from '@code-pushup/test-nx-utils';
 import { teardownTestFolder } from '@code-pushup/test-setup';
@@ -8,23 +8,23 @@ import { executeProcess } from '@code-pushup/utils';
 
 describe('CLI print-config', () => {
   const extensions = ['js', 'mjs', 'ts'] as const;
-  const fixtureDummyDir = join(
+  const fixtureDummyDir = path.join(
     'e2e',
     nxTargetProject(),
     'mocks',
     'fixtures',
     'dummy-setup',
   );
 
-  const testFileDir = join(
+  const testFileDir = path.join(
     E2E_ENVIRONMENTS_DIR,
     nxTargetProject(),
     TEST_OUTPUT_DIR,
     'print-config',
   );
-  const testFileDummySetup = join(testFileDir, 'dummy-setup');
+  const testFileDummySetup = path.join(testFileDir, 'dummy-setup');
   const configFilePath = (ext: (typeof extensions)[number]) =>
-    join(process.cwd(), testFileDummySetup, `code-pushup.config.${ext}`);
+    path.join(process.cwd(), testFileDummySetup, `code-pushup.config.${ext}`);
 
   beforeAll(async () => {
     await cp(fixtureDummyDir, testFileDummySetup, { recursive: true });

e2e/create-cli-e2e/tests/init.e2e.test.ts

@@ -1,4 +1,4 @@
-import { join } from 'node:path';
+import path from 'node:path';
 import { afterEach, expect } from 'vitest';
 import { nxTargetProject } from '@code-pushup/test-nx-utils';
 import { teardownTestFolder } from '@code-pushup/test-setup';
@@ -14,15 +14,15 @@ const fakeCacheFolderName = () =>
   `fake-cache-${new Date().toISOString().replace(/[:.]/g, '-')}`;
 
 describe('create-cli-init', () => {
-  const workspaceRoot = join(E2E_ENVIRONMENTS_DIR, nxTargetProject());
-  const testFileDir = join(workspaceRoot, TEST_OUTPUT_DIR, 'init');
+  const workspaceRoot = path.join(E2E_ENVIRONMENTS_DIR, nxTargetProject());
+  const testFileDir = path.join(workspaceRoot, TEST_OUTPUT_DIR, 'init');
 
   afterEach(async () => {
     await teardownTestFolder(testFileDir);
   });
 
   it('should execute package correctly over npm exec', async () => {
-    const cwd = join(testFileDir, 'npm-exec');
+    const cwd = path.join(testFileDir, 'npm-exec');
     await createNpmWorkspace(cwd);
     const { code, stdout } = await executeProcess({
       command: 'npm',
@@ -42,7 +42,7 @@ describe('create-cli-init', () => {
     );
 
     await expect(
-      readJsonFile(join(cwd, 'package.json')),
+      readJsonFile(path.join(cwd, 'package.json')),
     ).resolves.toStrictEqual(
       expect.objectContaining({
         devDependencies: {
@@ -54,14 +54,14 @@ describe('create-cli-init', () => {
       }),
     );
     await expect(
-      readTextFile(join(cwd, 'code-pushup.config.ts')),
+      readTextFile(path.join(cwd, 'code-pushup.config.ts')),
     ).resolves.toContain(
       "import type { CoreConfig } from '@code-pushup/models';",
     );
   });
 
   it('should execute package correctly over npm init', async () => {
-    const cwd = join(testFileDir, 'npm-init-setup');
+    const cwd = path.join(testFileDir, 'npm-init-setup');
     await createNpmWorkspace(cwd);
 
     const { code, stdout } = await executeProcess({
@@ -82,7 +82,7 @@ describe('create-cli-init', () => {
     );
 
     await expect(
-      readJsonFile(join(cwd, 'package.json')),
+      readJsonFile(path.join(cwd, 'package.json')),
     ).resolves.toStrictEqual(
       expect.objectContaining({
         devDependencies: {
@@ -94,14 +94,14 @@ describe('create-cli-init', () => {
       }),
     );
     await expect(
-      readTextFile(join(cwd, 'code-pushup.config.ts')),
+      readTextFile(path.join(cwd, 'code-pushup.config.ts')),
     ).resolves.toContain(
       "import type { CoreConfig } from '@code-pushup/models';",
     );
   });
 
   it('should produce an executable setup when running npm exec', async () => {
-    const cwd = join(testFileDir, 'npm-executable');
+    const cwd = path.join(testFileDir, 'npm-executable');
     await createNpmWorkspace(cwd);
 
     await executeProcess({