feat: add normalize helper for normalization

Author: BioPhoton

packages/cli/src/lib/implementation/core-config.middleware.ts

@@ -53,13 +53,28 @@ export async function coreConfigMiddleware<
       format: normalizeFormats(
         cliPersist?.format ?? rcPersist?.format ?? DEFAULT_PERSIST_FORMAT,
       ),
-      report: !('no-report' in (cliPersist ?? {})),
+      report: normalizeBooleanWithNegation(
+        'report',
+        cliPersist as Record<string, unknown>,
+        rcPersist as Record<string, unknown>,
+      ),
     },
     ...(upload != null && { upload }),
     ...remainingRcConfig,
     ...remainingCliOptions,
   };
 }
 
+export const normalizeBooleanWithNegation = <T extends string>(
+  propertyName: T,
+  cliOptions?: Record<T, unknown>,
+  rcOptions?: Record<T, unknown>,
+): boolean =>
+  propertyName in (cliOptions ?? {})
+    ? (cliOptions?.[propertyName] as boolean)
+    : `no-${propertyName}` in (cliOptions ?? {})
+      ? false
+      : ((rcOptions?.[propertyName] as boolean) ?? true);
+
 export const normalizeFormats = (formats?: string[]): Format[] =>
   (formats ?? []).flatMap(format => format.split(',') as Format[]);

packages/cli/src/lib/implementation/core-config.middleware.unit.test.ts

@@ -2,6 +2,7 @@ import { describe, expect, vi } from 'vitest';
 import { autoloadRc, readRcByPath } from '@code-pushup/core';
 import {
   coreConfigMiddleware,
+  normalizeBooleanWithNegation,
   normalizeFormats,
 } from './core-config.middleware.js';
 import type { CoreConfigCliOptions } from './core-config.model.js';
@@ -19,6 +20,36 @@ vi.mock('@code-pushup/core', async () => {
   };
 });
 
+describe('normalizeBooleanWithNegation', () => {
+  it('should return true when CLI property is true', () => {
+    expect(normalizeBooleanWithNegation('report', { report: true }, {})).toBe(
+      true,
+    );
+  });
+
+  it('should return false when CLI property is false', () => {
+    expect(normalizeBooleanWithNegation('report', { report: false }, {})).toBe(
+      false,
+    );
+  });
+
+  it('should return false when no-property exists in CLI persist', () => {
+    expect(
+      normalizeBooleanWithNegation('report', { 'no-report': true }, {}),
+    ).toBe(false);
+  });
+
+  it('should fallback to RC persist when no CLI property', () => {
+    expect(normalizeBooleanWithNegation('report', {}, { report: false })).toBe(
+      false,
+    );
+  });
+
+  it('should return default true when no property anywhere', () => {
+    expect(normalizeBooleanWithNegation('report', {}, {})).toBe(true);
+  });
+});
+
 describe('normalizeFormats', () => {
   it('should forward valid formats', () => {
     expect(normalizeFormats(['json', 'md'])).toEqual(['json', 'md']);