refactor: implement review

Author: John Doe

packages/utils/mocks/sink.mock.ts

@@ -0,0 +1,30 @@
+import type { Sink } from '../src/lib/sink-source.types';
+
+export class MockSink implements Sink<string, string> {
+  private writtenItems: string[] = [];
+  private closed = false;
+
+  open(): void {
+    this.closed = false;
+  }
+
+  write(input: string): void {
+    this.writtenItems.push(input);
+  }
+
+  close(): void {
+    this.closed = true;
+  }
+
+  isClosed(): boolean {
+    return this.closed;
+  }
+
+  encode(input: string): string {
+    return `${input}-${this.constructor.name}-encoded`;
+  }
+
+  getWrittenItems(): string[] {
+    return [...this.writtenItems];
+  }
+}

packages/utils/src/lib/performance-observer.int.test.ts

@@ -1,41 +1,12 @@
 import { type PerformanceEntry, performance } from 'node:perf_hooks';
 import { beforeEach, describe, expect, it, vi } from 'vitest';
+import { MockSink } from '../../mocks/sink.mock';
 import {
   type PerformanceObserverOptions,
   PerformanceObserverSink,
 } from './performance-observer.js';
 import type { Sink } from './sink-source.types';
 
-// @TODO remove duplicate when file-sink is implemented
-class MockSink implements Sink<string, string> {
-  private writtenItems: string[] = [];
-  private closed = false;
-
-  open(): void {
-    this.closed = false;
-  }
-
-  write(input: string): void {
-    this.writtenItems.push(input);
-  }
-
-  close(): void {
-    this.closed = true;
-  }
-
-  isClosed(): boolean {
-    return this.closed;
-  }
-
-  encode(input: string): string {
-    return `${input}-${this.constructor.name}-encoded`;
-  }
-
-  recover(): string[] {
-    return [...this.writtenItems];
-  }
-}
-
 describe('PerformanceObserverSink', () => {
   let sink: MockSink;
   let options: PerformanceObserverOptions<string>;
@@ -79,7 +50,7 @@ describe('PerformanceObserverSink', () => {
     observer.subscribe();
     performance.mark('test-mark');
     observer.flush();
-    expect(sink.recover()).toHaveLength(1);
+    expect(sink.getWrittenItems()).toHaveLength(1);
   });
 
   it('should observe buffered performance entries when buffered is enabled', async () => {
@@ -95,7 +66,7 @@ describe('PerformanceObserverSink', () => {
     await new Promise(resolve => setTimeout(resolve, 10));
     expect(performance.getEntries()).toHaveLength(2);
     observer.flush();
-    expect(sink.recover()).toHaveLength(2);
+    expect(sink.getWrittenItems()).toHaveLength(2);
   });
 
   it('handles multiple encoded items per performance entry', () => {
@@ -113,6 +84,6 @@ describe('PerformanceObserverSink', () => {
     performance.mark('test-mark');
     observer.flush();
 
-    expect(sink.recover()).toHaveLength(2);
+    expect(sink.getWrittenItems()).toHaveLength(2);
   });
 });

packages/utils/src/lib/performance-observer.unit.test.ts

@@ -8,42 +8,13 @@ import {
   vi,
 } from 'vitest';
 import { MockPerformanceObserver } from '@code-pushup/test-utils';
+import { MockSink } from '../../mocks/sink.mock';
 import {
   type PerformanceObserverOptions,
   PerformanceObserverSink,
 } from './performance-observer.js';
 import type { Sink } from './sink-source.types';
 
-// @TODO remove duplicate when file-sink is implemented
-class MockSink implements Sink<string, string> {
-  private writtenItems: string[] = [];
-  private closed = false;
-
-  open(): void {
-    this.closed = false;
-  }
-
-  write(input: string): void {
-    this.writtenItems.push(input);
-  }
-
-  close(): void {
-    this.closed = true;
-  }
-
-  isClosed(): boolean {
-    return this.closed;
-  }
-
-  encode(input: string): string {
-    return `${input}-${this.constructor.name}-encoded`;
-  }
-
-  getWrittenItems(): string[] {
-    return [...this.writtenItems];
-  }
-}
-
 describe('PerformanceObserverSink', () => {
   let encode: MockedFunction<(entry: PerformanceEntry) => string[]>;
   let sink: MockSink;

packages/utils/src/lib/sink-source.types.ts

@@ -16,7 +16,7 @@ export type Sink<I, O> = {
 export type Buffered = {
   flush: () => void;
 };
-export type BufferedSink<I, O> = {} & Sink<I, O> & Buffered;
+export type BufferedSink<I, O> = Sink<I, O> & Buffered;
 
 export type Source<I, O = unknown> = {
   read?: () => O;