Skip to content

Commit 503be8f

Browse files
author
John Doe
committed
chore: refine targets 5
1 parent 622a5ac commit 503be8f

File tree

2 files changed

+25
-15
lines changed

2 files changed

+25
-15
lines changed

nx.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@
6666
},
6767
"code-pushup-coverage": {
6868
"cache": true,
69-
"outputs": ["{projectRoot}/.code-pushup/coverage"],
69+
"outputs": ["{projectRoot}/.code-pushup/coverage/runner-output.json"],
7070
"executor": "nx:run-commands",
7171
"dependsOn": ["unit-test", "int-test"],
7272
"options": {
@@ -88,7 +88,7 @@
8888
},
8989
"code-pushup-eslint": {
9090
"cache": true,
91-
"outputs": ["{projectRoot}/.code-pushup/eslint"],
91+
"outputs": ["{projectRoot}/.code-pushup/eslint/runner-output.json"],
9292
"executor": "nx:run-commands",
9393
"options": {
9494
"command": "node packages/cli/src/index.ts collect",
@@ -109,7 +109,7 @@
109109
},
110110
"code-pushup-js-packages": {
111111
"cache": false,
112-
"outputs": ["{projectRoot}/.code-pushup/js-packages"],
112+
"outputs": ["{projectRoot}/.code-pushup/js-packages/runner-output.json"],
113113
"executor": "nx:run-commands",
114114
"options": {
115115
"command": "node packages/cli/src/index.ts collect",
@@ -130,10 +130,10 @@
130130
},
131131
"code-pushup-lighthouse": {
132132
"cache": true,
133-
"outputs": ["{projectRoot}/.code-pushup/lighthouse"],
133+
"outputs": ["{projectRoot}/.code-pushup/lighthouse/runner-output.json"],
134134
"executor": "nx:run-commands",
135135
"options": {
136-
"command": "node packages/cli/src/index.ts",
136+
"command": "node packages/cli/src/index.ts collect",
137137
"args": [
138138
"--no-progress",
139139
"--verbose",
@@ -151,7 +151,7 @@
151151
},
152152
"code-pushup-jsdocs": {
153153
"cache": true,
154-
"outputs": ["{projectRoot}/.code-pushup/jsdocs"],
154+
"outputs": ["{projectRoot}/.code-pushup/jsdocs/runner-output.json"],
155155
"executor": "nx:run-commands",
156156
"options": {
157157
"command": "node packages/cli/src/index.ts collect",
@@ -173,7 +173,7 @@
173173
"code-pushup-typescript": {
174174
"cache": true,
175175
"inputs": ["default", "^default", "{projectRoot}/tsconfig.lib.json"],
176-
"outputs": ["{projectRoot}/.code-pushup/typescript"],
176+
"outputs": ["{projectRoot}/.code-pushup/typescript/runner-output.json"],
177177
"executor": "nx:run-commands",
178178
"options": {
179179
"command": "node packages/cli/src/index.ts collect",

packages/cli/docs/nx-caching.md

Lines changed: 18 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,17 @@ export default {
4949
"coverage.reportsDirectory": "{projectRoot}/coverage/unit-test"
5050
}
5151
},
52+
"code-pushup-js-packages": {
53+
"cache": false,
54+
"executor": "nx:run-commands",
55+
"options": {
56+
"command": "npx @code-pushup/cli collect",
57+
"args": ["--config={projectRoot}/code-pushup.config.ts", "--cache.write=true", "--persist.skipReports=true", "--persist.outputDir={projectRoot}/.code-pushup", "--upload.project={projectName}"]
58+
}
59+
},
5260
"code-pushup-coverage": {
5361
"cache": true,
54-
"outputs": ["{projectRoot}/.code-pushup/coverage"],
62+
"outputs": ["{projectRoot}/.code-pushup/coverage/runner-output.json"],
5563
"executor": "nx:run-commands",
5664
"options": {
5765
"command": "npx @code-pushup/cli collect",
@@ -61,13 +69,13 @@ export default {
6169
},
6270
"code-pushup": {
6371
"cache": true,
64-
"outputs": ["{projectRoot}/.code-pushup"],
72+
"outputs": ["{projectRoot}/.code-pushup/report.*"],
6573
"executor": "nx:run-commands",
6674
"options": {
6775
"command": "npx @code-pushup/cli",
6876
"args": ["--config={projectRoot}/code-pushup.config.ts", "--cache.read=true", "--persist.outputDir={projectRoot}/.code-pushup", "--upload.project={projectName}"]
6977
},
70-
"dependsOn": ["code-pushup-coverage"]
78+
"dependsOn": ["code-pushup-coverage", "code-pushup-js-packages"]
7179
}
7280
}
7381
}
@@ -80,12 +88,14 @@ This configuration creates the following task dependency graph:
8088
**Legend:**
8189

8290
- 🐳 = Cached target
91+
- 💾 = Parallel execution
8392

8493
```mermaid
8594
graph TD
86-
A[lib-a:code-pushup 🐳] --> B[lib-a:code-pushup-coverage 🐳]
87-
B --> C[lib-a:unit-test 🐳]
88-
B --> D[lib-a:int-test 🐳]
95+
A[lib-a:code-pushup 🐳] --> B[lib-a:code-pushup-coverage 💾🐳]
96+
A --> C[lib-a:code-pushup-js-packages 💾]
97+
B --> C[lib-a:unit-test 💾🐳]
98+
B --> D[lib-a:int-test 💾🐳]
8999
```
90100

91101
## Command Line Example
@@ -100,7 +110,7 @@ nx affected --target=code-pushup
100110

101111
This approach has the following benefits:
102112

103-
1. **Parallel Execution**: Plugins can run in parallel
104-
2. **Fine-grained Caching**: Code level cache invalidation enables usage of [affected](https://nx.dev/recipes/affected-tasks) command
113+
1. **💾 Parallel Execution**: Plugins can run in parallel
114+
2. **🐳 Fine-grained Caching**: Code level cache invalidation enables usage of [affected](https://nx.dev/recipes/affected-tasks) command
105115
3. **Dependency Management**: Leverage Nx task dependencies and its caching strategy
106116
4. **Clear Separation**: Each plugin has its own target for better debugging and maintainability

0 commit comments

Comments
 (0)