refactor: autofix lint after update

Author: matejchalk

e2e/nx-plugin-e2e/tests/executor-cli.e2e.test.ts

@@ -27,7 +27,7 @@ async function addTargetToWorkspace(
     ...projectCfg,
     targets: {
       ...projectCfg.targets,
-      ['code-pushup']: {
+      'code-pushup': {
         executor: '@code-pushup/nx-plugin:cli',
       },
     },

e2e/nx-plugin-e2e/tests/plugin-create-nodes.e2e.test.ts

@@ -47,7 +47,7 @@ describe('nx-plugin', () => {
     expect(code).toBe(0);
 
     expect(projectJson.targets).toEqual({
-      ['code-pushup--configuration']: {
+      'code-pushup--configuration': {
         configurations: {},
         executor: 'nx:run-commands',
         options: {
@@ -99,7 +99,7 @@ describe('nx-plugin', () => {
     expect(code).toBe(0);
 
     expect(projectJson.targets).toStrictEqual({
-      ['cp--configuration']: expect.any(Object),
+      'cp--configuration': expect.any(Object),
     });
   });
 
@@ -118,7 +118,7 @@ describe('nx-plugin', () => {
     expect(code).toBe(0);
 
     expect(projectJson.targets).toStrictEqual({
-      ['code-pushup--configuration']: expect.objectContaining({
+      'code-pushup--configuration': expect.objectContaining({
         options: {
           command: `nx g XYZ:configuration --skipTarget --targetName="code-pushup" --project="${project}"`,
         },
@@ -139,7 +139,7 @@ describe('nx-plugin', () => {
 
     expect(projectJson.targets).toStrictEqual(
       expect.not.objectContaining({
-        ['code-pushup--configuration']: expect.any(Object),
+        'code-pushup--configuration': expect.any(Object),
       }),
     );
     expect(projectJson.targets).toMatchSnapshot();
@@ -156,7 +156,7 @@ describe('nx-plugin', () => {
     expect(code).toBe(0);
 
     expect(projectJson.targets).toStrictEqual({
-      ['code-pushup']: {
+      'code-pushup': {
         configurations: {},
         executor: `@code-pushup/nx-plugin:cli`,
         options: {},
@@ -222,7 +222,7 @@ describe('nx-plugin', () => {
     expect(code).toBe(0);
 
     expect(projectJson.targets).toStrictEqual({
-      ['code-pushup']: expect.objectContaining({
+      'code-pushup': expect.objectContaining({
         executor: 'XYZ:cli',
       }),
     });
@@ -245,7 +245,7 @@ describe('nx-plugin', () => {
     expect(code).toBe(0);
 
     expect(projectJson.targets).toStrictEqual({
-      ['code-pushup']: expect.objectContaining({
+      'code-pushup': expect.objectContaining({
         executor: `@code-pushup/nx-plugin:cli`,
         options: {
           projectPrefix: 'cli',

e2e/plugin-coverage-e2e/tests/collect.e2e.test.ts

@@ -19,13 +19,16 @@ describe('PLUGIN collect report with coverage-plugin NPM package', () => {
   const existingDir = join(testFileDir, 'existing-report');
 
   const fixtureDir = join('e2e', nxTargetProject(), 'mocks', 'fixtures');
+
   beforeAll(async () => {
     await cp(fixtureDir, testFileDir, { recursive: true });
   });
+
   afterAll(async () => {
     await teardownTestFolder(basicDir);
     await teardownTestFolder(existingDir);
   });
+
   afterEach(async () => {
     await teardownTestFolder(join(basicDir, '.code-pushup'));
     await teardownTestFolder(join(existingDir, '.code-pushup'));

e2e/plugin-lighthouse-e2e/tests/collect.e2e.test.ts

@@ -22,6 +22,7 @@ describe('PLUGIN collect report with lighthouse-plugin NPM package', () => {
   const defaultSetupDir = join(testFileDir, 'default-setup');
 
   const fixturesDir = join('e2e', nxTargetProject(), 'mocks/fixtures');
+
   beforeAll(async () => {
     await cp(fixturesDir, testFileDir, { recursive: true });
   });

examples/plugins/src/lighthouse/src/constants.ts

@@ -1,4 +1,3 @@
-/* eslint-disable no-magic-numbers */
 import type { Audit, CategoryRef, Group } from '@code-pushup/models';
 
 export const LIGHTHOUSE_OUTPUT_FILE_DEFAULT = 'lighthouse-report.json';

examples/plugins/src/lighthouse/src/lighthouse.plugin.ts

@@ -121,7 +121,7 @@ function lhrToAuditOutputs(lhr: Result): AuditOutputs {
         slug,
         score: score ?? 0, // score can be null
         value: Number.parseInt(value.toString(), 10),
-        displayValue: displayValue,
+        displayValue,
       };
 
       const issues = lhrDetailsToIssueDetails(details);

examples/plugins/src/lighthouse/src/utils.ts

@@ -33,7 +33,7 @@ export function getLighthouseCliArguments(
 
   // handle chrome flags
   // eslint-disable-next-line functional/no-let
-  let chromeFlags: Array<string> = [];
+  let chromeFlags: string[] = [];
   if (headless) {
     chromeFlags = [...chromeFlags, `--headless=${headless}`];
   }
@@ -43,7 +43,7 @@ export function getLighthouseCliArguments(
   if (chromeFlags.length > 0) {
     argsObj = {
       ...argsObj,
-      ['chrome-flags']: chromeFlags.join(' '),
+      'chrome-flags': chromeFlags.join(' '),
     };
   }
 

packages/ci/src/lib/cli/persist.ts

@@ -56,7 +56,7 @@ export function persistedCliFiles<TFormat extends Format = Format>({
       ...acc,
       [`${format}FilePath`]: path.join(rootDir, `${filename}.${format}`),
     }),
-    // eslint-disable-next-line @typescript-eslint/prefer-reduce-type-parameter, @typescript-eslint/consistent-type-assertions
+    // eslint-disable-next-line @typescript-eslint/consistent-type-assertions
     {} as PersistedCliFilesFormats,
   );
   const files = Object.values(filePaths);
@@ -86,7 +86,7 @@ export function findPersistedFiles({
       return acc;
     }
     return { ...acc, [`${format}FilePath`]: path.join(rootDir, matchedFile) };
-    // eslint-disable-next-line @typescript-eslint/prefer-reduce-type-parameter, @typescript-eslint/consistent-type-assertions
+    // eslint-disable-next-line @typescript-eslint/consistent-type-assertions
   }, {} as PersistedCliFilesFormats);
   return {
     ...filePaths,

packages/cli/src/lib/history/history.options.ts

@@ -30,7 +30,7 @@ export function yargsHistoryOptionsDefinition(): Record<
       // https://git-scm.com/docs/git-log#Documentation/git-log.txt---max-countltnumbergt
       describe: 'Number of steps in history',
       type: 'number',
-      // eslint-disable-next-line no-magic-numbers
+
       default: 5,
     },
     from: {

packages/cli/src/lib/implementation/core-config.model.ts

@@ -1,6 +1,5 @@
 import type { CoreConfig, Format, UploadConfig } from '@code-pushup/models';
 
-/* eslint-disable @typescript-eslint/naming-convention */
 export type PersistConfigCliOptions = {
   'persist.outputDir'?: string;
   'persist.filename'?: string;
@@ -13,7 +12,6 @@ export type UploadConfigCliOptions = {
   'upload.apiKey'?: string;
   'upload.server'?: string;
 };
-/* eslint-enable @typescript-eslint/naming-convention */
 
 export type ConfigCliOptions = {
   config?: string;