Skip to content

Commit 67e004c

Browse files
committed
refactor: fix lint
1 parent 3fe6871 commit 67e004c

File tree

6 files changed

+24
-11
lines changed

6 files changed

+24
-11
lines changed

packages/utils/src/lib/file-sink-json-trace.int.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import * as os from 'node:os';
33
import * as path from 'node:path';
44
import { afterAll, beforeAll, describe, expect, it } from 'vitest';
55
import { teardownTestFolder } from '@code-pushup/test-utils';
6-
import { FileSinkJsonTrace } from './file-sink-json-trace';
6+
import { FileSinkJsonTrace } from './file-sink-json-trace.js';
77
import type { CompleteEvent, TraceEvent } from './trace-file.type';
88

99
describe('TraceFileSink integration', () => {

packages/utils/src/lib/file-sink-json-trace.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ export function finalizeTraceFile(
3737
events.sort((a, b) => a.ts - b.ts);
3838
const fallbackTs = performance.now();
3939
const firstTs = events.length > 0 ? events[0].ts : fallbackTs;
40-
const lastTs = events.length > 0 ? events[events.length - 1].ts : fallbackTs;
40+
const lastTs = events.length > 0 ? events.at(-1).ts : fallbackTs;
4141

4242
const marginMs = options?.marginMs ?? TRACE_MARGIN_MS;
4343
const marginDurMs = options?.marginDurMs ?? TRACE_MARGIN_DURATION_MS;
@@ -182,7 +182,9 @@ export class FileSinkJsonTrace {
182182
}
183183

184184
finalize(): void {
185-
if (this.#finalized) return;
185+
if (this.#finalized) {
186+
return;
187+
}
186188
this.#finalized = true;
187189
this.sink.finalize();
188190
}

packages/utils/src/lib/file-sink-json-trace.unit.test.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,10 @@ import { vol } from 'memfs';
22
import * as fs from 'node:fs';
33
import { beforeEach, describe, expect, it } from 'vitest';
44
import { MEMFS_VOLUME } from '@code-pushup/test-utils';
5-
import { FileSinkJsonTrace, finalizeTraceFile } from './file-sink-json-trace';
5+
import {
6+
FileSinkJsonTrace,
7+
finalizeTraceFile,
8+
} from './file-sink-json-trace.js';
69
import {
710
decodeTraceEvent,
811
encodeTraceEvent,

packages/utils/src/lib/file-sink-jsonl.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ export class JsonlFile<
100100
* Encode record to JSONL format.
101101
*/
102102
encode(record: T): string {
103-
return jsonlEncode(record) + '\n';
103+
return `${jsonlEncode(record)}\n`;
104104
}
105105

106106
/**
@@ -121,7 +121,7 @@ export class JsonlFile<
121121
* Write record in JSONL format (append-only).
122122
*/
123123
write(record: T): void {
124-
this.file.append(jsonlEncode(record) + '\n');
124+
this.file.append(`${jsonlEncode(record)}\n`);
125125
}
126126

127127
/**
@@ -167,7 +167,7 @@ export class JsonlFile<
167167
const { records } = this.recover();
168168
fs.writeFileSync(
169169
outputPath ?? this.getPath(),
170-
records.map(jsonlEncode).join('\n') + '\n',
170+
`${records.map(jsonlEncode).join('\n')}\n`,
171171
);
172172
}
173173
}

packages/utils/src/lib/file-sink-text.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,9 @@ export class FileSink<T = string> {
185185
* Open file for writing (creates directory if needed).
186186
*/
187187
open(withRepack?: boolean): void {
188-
if (this.isOpen) return;
188+
if (this.isOpen) {
189+
return;
190+
}
189191

190192
const dir = path.dirname(this.file.getPath());
191193
fs.mkdirSync(dir, { recursive: true });
@@ -202,7 +204,9 @@ export class FileSink<T = string> {
202204
* Write input to file (append-only).
203205
*/
204206
write(input: T): void {
205-
if (!this.isOpen) return;
207+
if (!this.isOpen) {
208+
return;
209+
}
206210

207211
try {
208212
const encoded = this.encode(input);

packages/utils/src/lib/trace-file-utils.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -310,7 +310,9 @@ export function encodeDetail(target: UserTimingDetail): UserTimingDetail {
310310
}
311311

312312
export function decodeTraceEvent({ args, ...rest }: TraceEventRaw): TraceEvent {
313-
if (!args) return rest as TraceEvent;
313+
if (!args) {
314+
return rest as TraceEvent;
315+
}
314316

315317
const processedArgs = decodeDetail(args as { detail: string });
316318
if ('data' in args && args.data && typeof args.data === 'object') {
@@ -326,7 +328,9 @@ export function decodeTraceEvent({ args, ...rest }: TraceEventRaw): TraceEvent {
326328
}
327329

328330
export function encodeTraceEvent({ args, ...rest }: TraceEvent): TraceEventRaw {
329-
if (!args) return rest as TraceEventRaw;
331+
if (!args) {
332+
return rest as TraceEventRaw;
333+
}
330334

331335
const processedArgs = encodeDetail(args);
332336
if ('data' in args && args.data && typeof args.data === 'object') {

0 commit comments

Comments
 (0)