refactor: fix lint

Author: John Doe

packages/utils/src/lib/exit-process.ts

@@ -1,22 +1,22 @@
 import os from 'node:os';
 import process from 'node:process';
 
-const isWindows = os.platform() === 'win32';
-
 // POSIX shells convention: exit status = 128 + signal number
 // https://www.gnu.org/software/bash/manual/html_node/Exit-Status.html#:~:text=When%20a%20command%20terminates%20on%20a%20fatal%20signal%20whose%20number%20is%20N%2C%20Bash%20uses%20the%20value%20128%2BN%20as%20the%20exit%20status.
 const UNIX_SIGNAL_EXIT_CODE_OFFSET = 128;
 const unixSignalExitCode = (signalNumber: number) =>
   UNIX_SIGNAL_EXIT_CODE_OFFSET + signalNumber;
 
 const SIGINT_CODE = 2;
+const SIGTERM_CODE = 15;
+const SIGQUIT_CODE = 3;
 
 export const SIGNAL_EXIT_CODES = (): Record<SignalName, number> => {
   const isWindowsRuntime = os.platform() === 'win32';
   return {
     SIGINT: isWindowsRuntime ? SIGINT_CODE : unixSignalExitCode(SIGINT_CODE),
-    SIGTERM: unixSignalExitCode(15),
-    SIGQUIT: unixSignalExitCode(3),
+    SIGTERM: unixSignalExitCode(SIGTERM_CODE),
+    SIGQUIT: unixSignalExitCode(SIGQUIT_CODE),
   };
 };
 
@@ -39,6 +39,7 @@ export type ExitHandlerOptions = {
 };
 
 export function installExitHandlers(options: ExitHandlerOptions = {}): void {
+  // eslint-disable-next-line functional/no-let
   let closedReason: CloseReason | undefined;
   const {
     onClose,
@@ -49,40 +50,47 @@ export function installExitHandlers(options: ExitHandlerOptions = {}): void {
   } = options;
 
   const close = (code: number, reason: CloseReason) => {
-    if (closedReason) return;
+    if (closedReason) {
+      return;
+    }
     closedReason = reason;
     onClose?.(code, reason);
   };
 
   process.on('uncaughtException', err => {
     onError?.(err, 'uncaughtException');
-    if (fatalExit)
+    if (fatalExit) {
       close(fatalExitCode, {
         kind: 'fatal',
         fatal: 'uncaughtException',
       });
+    }
   });
 
   process.on('unhandledRejection', reason => {
     onError?.(reason, 'unhandledRejection');
-    if (fatalExit)
+    if (fatalExit) {
       close(fatalExitCode, {
         kind: 'fatal',
         fatal: 'unhandledRejection',
       });
+    }
   });
 
   (['SIGINT', 'SIGTERM', 'SIGQUIT'] as const).forEach(signal => {
     process.on(signal, () => {
       close(SIGNAL_EXIT_CODES()[signal], { kind: 'signal', signal });
       if (signalExit) {
+        // eslint-disable-next-line n/no-process-exit
         process.exit(SIGNAL_EXIT_CODES()[signal]);
       }
     });
   });
 
   process.on('exit', code => {
-    if (closedReason) return;
+    if (closedReason) {
+      return;
+    }
     close(code, { kind: 'exit' });
   });
 }

packages/utils/src/lib/exit-process.unit.test.ts

@@ -1,3 +1,4 @@
+import os from 'node:os';
 import process from 'node:process';
 import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
 import { SIGNAL_EXIT_CODES, installExitHandlers } from './exit-process.js';
@@ -215,28 +216,22 @@ describe('exit-process tests', () => {
     expect(onClose).toHaveBeenCalledTimes(1);
   });
 
-  it('should have correct SIGINT exit code based on platform', () => {
-    const os = require('node:os');
-    const isWindows = os.platform() === 'win32';
-    const SIGINT_CODE = 2;
-    const UNIX_SIGNAL_EXIT_CODE_OFFSET = 128;
-
-    const expectedSigintCode = isWindows
-      ? SIGINT_CODE
-      : UNIX_SIGNAL_EXIT_CODE_OFFSET + SIGINT_CODE;
-
-    if (isWindows) {
-      expect(expectedSigintCode).toBe(2);
-    } else {
-      expect(expectedSigintCode).toBe(130);
-      expect(SIGNAL_EXIT_CODES().SIGINT).toBe(130);
-    }
+  it('should have correct SIGINT exit code on Windows', () => {
+    const osSpy = vi.spyOn(os, 'platform').mockReturnValue('win32');
+    const exitCodes = SIGNAL_EXIT_CODES();
+    expect(exitCodes.SIGINT).toBe(2);
+    osSpy.mockRestore();
+  });
+
+  it('should have correct SIGINT exit code on Unix-like systems', () => {
+    const osSpy = vi.spyOn(os, 'platform').mockReturnValue('linux');
+    const exitCodes = SIGNAL_EXIT_CODES();
+    expect(exitCodes.SIGINT).toBe(130);
+    osSpy.mockRestore();
   });
 
   it('should calculate Windows exit codes correctly when platform is mocked to Windows', () => {
-    const osSpy = vi
-      .spyOn(require('node:os'), 'platform')
-      .mockReturnValue('win32');
+    const osSpy = vi.spyOn(os, 'platform').mockReturnValue('win32');
 
     const exitCodes = SIGNAL_EXIT_CODES();