refactor: rename options

Author: John Doe

packages/utils/src/lib/exit-process.int.test.ts

@@ -4,7 +4,7 @@ import { SIGNAL_EXIT_CODES, installExitHandlers } from './exit-process.js';
 
 describe('installExitHandlers', () => {
   const onError = vi.fn();
-  const onClose = vi.fn();
+  const onExit = vi.fn();
   const processOnSpy = vi.spyOn(process, 'on');
   const processExitSpy = vi.spyOn(process, 'exit').mockImplementation(vi.fn());
 
@@ -26,7 +26,7 @@ describe('installExitHandlers', () => {
   });
 
   it('should install event listeners for all expected events', () => {
-    expect(() => installExitHandlers({ onError, onClose })).not.toThrow();
+    expect(() => installExitHandlers({ onError, onExit })).not.toThrow();
 
     expect(processOnSpy).toHaveBeenCalledWith(
       'uncaughtException',
@@ -51,7 +51,7 @@ describe('installExitHandlers', () => {
 
     expect(onError).toHaveBeenCalledWith(testError, 'uncaughtException');
     expect(onError).toHaveBeenCalledTimes(1);
-    expect(onClose).not.toHaveBeenCalled();
+    expect(onExit).not.toHaveBeenCalled();
   });
 
   it('should call onError with reason and kind for unhandledRejection', () => {
@@ -63,55 +63,55 @@ describe('installExitHandlers', () => {
 
     expect(onError).toHaveBeenCalledWith(testReason, 'unhandledRejection');
     expect(onError).toHaveBeenCalledTimes(1);
-    expect(onClose).not.toHaveBeenCalled();
+    expect(onExit).not.toHaveBeenCalled();
   });
 
-  it('should call onClose and exit with code 0 for SIGINT', () => {
-    expect(() => installExitHandlers({ onClose })).not.toThrow();
+  it('should call onExit and exit with code 0 for SIGINT', () => {
+    expect(() => installExitHandlers({ onExit })).not.toThrow();
 
     (process as any).emit('SIGINT');
 
-    expect(onClose).toHaveBeenCalledTimes(1);
-    expect(onClose).toHaveBeenCalledWith(SIGNAL_EXIT_CODES().SIGINT, {
+    expect(onExit).toHaveBeenCalledTimes(1);
+    expect(onExit).toHaveBeenCalledWith(SIGNAL_EXIT_CODES().SIGINT, {
       kind: 'signal',
       signal: 'SIGINT',
     });
     expect(onError).not.toHaveBeenCalled();
   });
 
-  it('should call onClose and exit with code 0 for SIGTERM', () => {
-    expect(() => installExitHandlers({ onClose })).not.toThrow();
+  it('should call onExit and exit with code 0 for SIGTERM', () => {
+    expect(() => installExitHandlers({ onExit })).not.toThrow();
 
     (process as any).emit('SIGTERM');
 
-    expect(onClose).toHaveBeenCalledTimes(1);
-    expect(onClose).toHaveBeenCalledWith(SIGNAL_EXIT_CODES().SIGTERM, {
+    expect(onExit).toHaveBeenCalledTimes(1);
+    expect(onExit).toHaveBeenCalledWith(SIGNAL_EXIT_CODES().SIGTERM, {
       kind: 'signal',
       signal: 'SIGTERM',
     });
     expect(onError).not.toHaveBeenCalled();
   });
 
-  it('should call onClose and exit with code 0 for SIGQUIT', () => {
-    expect(() => installExitHandlers({ onClose })).not.toThrow();
+  it('should call onExit and exit with code 0 for SIGQUIT', () => {
+    expect(() => installExitHandlers({ onExit })).not.toThrow();
 
     (process as any).emit('SIGQUIT');
 
-    expect(onClose).toHaveBeenCalledTimes(1);
-    expect(onClose).toHaveBeenCalledWith(SIGNAL_EXIT_CODES().SIGQUIT, {
+    expect(onExit).toHaveBeenCalledTimes(1);
+    expect(onExit).toHaveBeenCalledWith(SIGNAL_EXIT_CODES().SIGQUIT, {
       kind: 'signal',
       signal: 'SIGQUIT',
     });
     expect(onError).not.toHaveBeenCalled();
   });
 
-  it('should call onClose for normal exit', () => {
-    expect(() => installExitHandlers({ onClose })).not.toThrow();
+  it('should call onExit for normal exit', () => {
+    expect(() => installExitHandlers({ onExit })).not.toThrow();
 
     (process as any).emit('exit');
 
-    expect(onClose).toHaveBeenCalledTimes(1);
-    expect(onClose).toHaveBeenCalledWith(undefined, { kind: 'exit' });
+    expect(onExit).toHaveBeenCalledTimes(1);
+    expect(onExit).toHaveBeenCalledWith(undefined, { kind: 'exit' });
     expect(onError).not.toHaveBeenCalled();
     expect(processExitSpy).not.toHaveBeenCalled();
   });

packages/utils/src/lib/exit-process.ts

@@ -31,21 +31,21 @@ export type CloseReason =
   | { kind: 'exit' };
 
 export type ExitHandlerOptions = {
-  onClose?: (code: number, reason: CloseReason) => void;
+  onExit?: (code: number, reason: CloseReason) => void;
   onError?: (err: unknown, kind: FatalKind) => void;
-  fatalExit?: boolean;
-  signalExit?: boolean;
+  exitOnFatal?: boolean;
+  exitOnSignal?: boolean;
   fatalExitCode?: number;
 };
 
 export function installExitHandlers(options: ExitHandlerOptions = {}): void {
   // eslint-disable-next-line functional/no-let
   let closedReason: CloseReason | undefined;
   const {
-    onClose,
+    onExit,
     onError,
-    fatalExit,
-    signalExit,
+    exitOnFatal,
+    exitOnSignal,
     fatalExitCode = DEFAULT_FATAL_EXIT_CODE,
   } = options;
 
@@ -54,12 +54,12 @@ export function installExitHandlers(options: ExitHandlerOptions = {}): void {
       return;
     }
     closedReason = reason;
-    onClose?.(code, reason);
+    onExit?.(code, reason);
   };
 
   process.on('uncaughtException', err => {
     onError?.(err, 'uncaughtException');
-    if (fatalExit) {
+    if (exitOnFatal) {
       close(fatalExitCode, {
         kind: 'fatal',
         fatal: 'uncaughtException',
@@ -69,7 +69,7 @@ export function installExitHandlers(options: ExitHandlerOptions = {}): void {
 
   process.on('unhandledRejection', reason => {
     onError?.(reason, 'unhandledRejection');
-    if (fatalExit) {
+    if (exitOnFatal) {
       close(fatalExitCode, {
         kind: 'fatal',
         fatal: 'unhandledRejection',
@@ -80,7 +80,7 @@ export function installExitHandlers(options: ExitHandlerOptions = {}): void {
   (['SIGINT', 'SIGTERM', 'SIGQUIT'] as const).forEach(signal => {
     process.on(signal, () => {
       close(SIGNAL_EXIT_CODES()[signal], { kind: 'signal', signal });
-      if (signalExit) {
+      if (exitOnSignal) {
         // eslint-disable-next-line n/no-process-exit
         process.exit(SIGNAL_EXIT_CODES()[signal]);
       }