refactor: wip

Author: BioPhoton

packages/utils/src/index.ts

@@ -114,7 +114,6 @@ export {
   settlePromise,
 } from './lib/promises.js';
 export { generateRandomId } from './lib/random.js';
-// export { profiler } from './lib/profiler/profiler.js'; // Disabled - requires WAL functionality
 export {
   CODE_PUSHUP_DOMAIN,
   CODE_PUSHUP_UNICODE_LOGO,

packages/utils/src/lib/performance-observer.unit.test.ts

@@ -29,7 +29,7 @@ describe('PerformanceObserverSink', () => {
     options = {
       sink,
       encode,
-      // we test buffered behavior separately
+
       flushThreshold: 1,
     };
 
@@ -51,24 +51,21 @@ describe('PerformanceObserverSink', () => {
         }),
     ).not.toThrow();
     expect(MockPerformanceObserver.instances).toHaveLength(0);
-    // Instance creation covers the default flushThreshold assignment
   });
 
   it('automatically flushes when pendingCount reaches flushThreshold', () => {
     const observer = new PerformanceObserverSink({
       sink,
       encode,
-      flushThreshold: 2, // Set threshold to 2
+      flushThreshold: 2,
     });
     observer.subscribe();
 
     const mockObserver = MockPerformanceObserver.lastInstance();
 
-    // Emit 1 entry - should not trigger flush yet (pendingCount = 1 < 2)
     mockObserver?.emitMark('first-mark');
     expect(sink.getWrittenItems()).toStrictEqual([]);
 
-    // Emit 1 more entry - should trigger flush (pendingCount = 2 >= 2)
     mockObserver?.emitMark('second-mark');
     expect(sink.getWrittenItems()).toStrictEqual([
       'first-mark:mark',
@@ -143,7 +140,7 @@ describe('PerformanceObserverSink', () => {
   it('internal PerformanceObserver should process observed entries', () => {
     const observer = new PerformanceObserverSink({
       ...options,
-      flushThreshold: 20, // Disable automatic flushing for this test
+      flushThreshold: 20,
     });
     observer.subscribe();
 
@@ -318,7 +315,6 @@ describe('PerformanceObserverSink', () => {
   });
 
   it('accepts custom sinks with append method', () => {
-    // Create a simple in-memory sink that just collects items
     const collectedItems: string[] = [];
     const customSink = {
       append: (item: string) => collectedItems.push(item),

packages/utils/src/lib/wal.unit.test.ts

@@ -51,7 +51,7 @@ describe('createTolerantCodec', () => {
       },
     });
     expect(c.decode(c.encode(42))).toBe(42);
-    // Invalid decode should return InvalidEntry, and encoding that should return the raw value
+
     const invalid = c.decode('x');
     expect(invalid).toStrictEqual({ __invalid: true, raw: 'x' });
     expect(c.encode(invalid)).toBe('x');
@@ -188,11 +188,9 @@ describe('WriteAheadLogFile', () => {
     const w = wal('/test/a.log');
     expect(w.isClosed()).toBe(true);
 
-    // First open should open the file
     w.open();
     expect(w.isClosed()).toBe(false);
 
-    // Subsequent opens should be no-ops
     w.open();
     expect(w.isClosed()).toBe(false);
     w.open();
@@ -221,7 +219,6 @@ describe('WriteAheadLogFile', () => {
   });
 
   it('returns empty result when file does not exist', () => {
-    // File '/test/nonexistent.log' does not exist
     const w = wal('/test/nonexistent.log');
     const result = w.recover();
 
@@ -236,7 +233,7 @@ describe('WriteAheadLogFile', () => {
     vol.mkdirSync('/test', { recursive: true });
     write('/test/a.log', 'line1\nline2\n');
     const w = wal('/test/a.log');
-    // Profiler WAL can recover without opening - it reads the file directly
+
     const result = w.recover();
     expect(result.records).toEqual(['line1', 'line2']);
     expect(result.errors).toEqual([]);
@@ -292,7 +289,6 @@ describe('WriteAheadLogFile', () => {
       },
     });
 
-    // With tolerant codec, repack should succeed and preserve all entries (valid and invalid)
     wal('/test/a.log', tolerantCodec).repack();
     expect(read('/test/a.log')).toBe('ok\nbad\n');
   });
@@ -309,7 +305,6 @@ describe('WriteAheadLogFile', () => {
     const content = 'good\nbad\ngood\n';
     const result = recoverFromContent(content, failingCodec.decode);
 
-    // Should have decode errors
     expect(result.errors).toHaveLength(1);
     expect(result.errors[0].error.message).toBe('Bad record during recovery');
     expect(result.records).toEqual(['good', 'good']);
@@ -390,17 +385,14 @@ describe('stringCodec', () => {
   });
 
   it('should maintain type safety with generics', () => {
-    // Test with string type
     const stringCodecInstance = stringCodec<string>();
     const str: string = stringCodecInstance.decode('test');
     expect(typeof str).toBe('string');
 
-    // Test with object type
     const objectCodecInstance = stringCodec<{ id: number; name: string }>();
     const obj = objectCodecInstance.decode('{"id":1,"name":"test"}');
     expect(obj).toEqual({ id: 1, name: 'test' });
 
-    // Test with union type
     const unionCodecInstance = stringCodec<string | number[]>();
     expect(unionCodecInstance.decode('string')).toBe('string');
     expect(unionCodecInstance.decode('[1,2,3]')).toEqual([1, 2, 3]);
@@ -474,7 +466,6 @@ describe('getShardedGroupId', () => {
   const originalTimeOrigin = performance.timeOrigin;
 
   afterEach(() => {
-    // Restore original timeOrigin
     Object.defineProperty(performance, 'timeOrigin', {
       value: originalTimeOrigin,
       writable: true,
@@ -549,6 +540,6 @@ describe('getShardedGroupId', () => {
 
     const result = getShardedGroupId();
 
-    expect(result).toBe('-124'); // Math.floor(-123.456) = -124
+    expect(result).toBe('-124');
   });
 });