refactor(nx-plugin): explicit import extensions

matejchalk · BioPhoton · commit a75439339496 · 2025-03-10T13:50:25.000+01:00
diff --git a/packages/nx-plugin/src/executors/cli/executor.ts b/packages/nx-plugin/src/executors/cli/executor.ts
@@ -1,9 +1,9 @@
 import { type ExecutorContext, logger } from '@nx/devkit';
 import { execSync } from 'node:child_process';
-import { createCliCommand } from '../internal/cli';
-import { normalizeContext } from '../internal/context';
-import type { AutorunCommandExecutorOptions } from './schema';
-import { mergeExecutorOptions, parseAutorunExecutorOptions } from './utils';
+import { createCliCommand } from '../internal/cli.js';
+import { normalizeContext } from '../internal/context.js';
+import type { AutorunCommandExecutorOptions } from './schema.js';
+import { mergeExecutorOptions, parseAutorunExecutorOptions } from './utils.js';
 
 export type ExecutorOutput = {
   success: boolean;
diff --git a/packages/nx-plugin/src/executors/cli/schema.ts b/packages/nx-plugin/src/executors/cli/schema.ts
@@ -4,7 +4,7 @@ import type {
   GeneralExecutorOnlyOptions,
   GlobalExecutorOptions,
   ProjectExecutorOnlyOptions,
-} from '../internal/types';
+} from '../internal/types.js';
 
 export type AutorunCommandExecutorOnlyOptions = ProjectExecutorOnlyOptions &
   CollectExecutorOnlyOptions &
diff --git a/packages/nx-plugin/src/executors/cli/utils.integration.test.ts b/packages/nx-plugin/src/executors/cli/utils.integration.test.ts
@@ -1,8 +1,8 @@
 import { expect, vi } from 'vitest';
 import type { UploadConfig } from '@code-pushup/models';
-import { normalizedExecutorContext } from '../../../mock/utils/executor';
-import * as config from '../internal/config';
-import { parseAutorunExecutorOptions } from './utils';
+import { normalizedExecutorContext } from '../../../mock/utils/executor.js';
+import * as config from '../internal/config.js';
+import { parseAutorunExecutorOptions } from './utils.js';
 
 describe('parseAutorunExecutorOptions', () => {
   const persistConfigSpy = vi.spyOn(config, 'persistConfig');
diff --git a/packages/nx-plugin/src/executors/cli/utils.ts b/packages/nx-plugin/src/executors/cli/utils.ts
@@ -1,9 +1,13 @@
-import { globalConfig, persistConfig, uploadConfig } from '../internal/config';
-import type { NormalizedExecutorContext } from '../internal/context';
+import {
+  globalConfig,
+  persistConfig,
+  uploadConfig,
+} from '../internal/config.js';
+import type { NormalizedExecutorContext } from '../internal/context.js';
 import type {
   AutorunCommandExecutorOnlyOptions,
   AutorunCommandExecutorOptions,
-} from './schema';
+} from './schema.js';
 
 export function parseAutorunExecutorOnlyOptions(
   options: Partial<AutorunCommandExecutorOnlyOptions>,
diff --git a/packages/nx-plugin/src/executors/cli/utils.unit.test.ts b/packages/nx-plugin/src/executors/cli/utils.unit.test.ts
@@ -1,11 +1,11 @@
 import { type MockInstance, expect, vi } from 'vitest';
 import { osAgnosticPath } from '@code-pushup/test-utils';
-import type { Command } from '../internal/types';
+import type { Command } from '../internal/types.js';
 import {
   mergeExecutorOptions,
   parseAutorunExecutorOnlyOptions,
   parseAutorunExecutorOptions,
-} from './utils';
+} from './utils.js';
 
 describe('parseAutorunExecutorOnlyOptions', () => {
   it('should provide NO default projectPrefix', () => {
diff --git a/packages/nx-plugin/src/executors/internal/cli.unit.test.ts b/packages/nx-plugin/src/executors/internal/cli.unit.test.ts
@@ -1,5 +1,5 @@
 import { describe, expect, it } from 'vitest';
-import { createCliCommand, objectToCliArgs } from './cli';
+import { createCliCommand, objectToCliArgs } from './cli.js';
 
 describe('objectToCliArgs', () => {
   it('should empty params', () => {
diff --git a/packages/nx-plugin/src/executors/internal/config.integration.test.ts b/packages/nx-plugin/src/executors/internal/config.integration.test.ts
@@ -1,5 +1,5 @@
 import { describe, expect } from 'vitest';
-import { ENV } from '../../../mock/fixtures/env';
+import { ENV } from '../../../mock/fixtures/env.js';
 import { uploadConfig } from './config.js';
 import * as env from './env.js';
 
diff --git a/packages/nx-plugin/src/executors/internal/config.ts b/packages/nx-plugin/src/executors/internal/config.ts
@@ -1,11 +1,11 @@
 import * as path from 'node:path';
 import type { PersistConfig, UploadConfig } from '@code-pushup/models';
-import { parseEnv } from './env';
+import { parseEnv } from './env.js';
 import type {
   BaseNormalizedExecutorContext,
   GlobalExecutorOptions,
   ProjectExecutorOnlyOptions,
-} from './types';
+} from './types.js';
 
 export function globalConfig(
   options: Partial<GlobalExecutorOptions & Record<string, unknown>>,
diff --git a/packages/nx-plugin/src/executors/internal/context.ts b/packages/nx-plugin/src/executors/internal/context.ts
@@ -1,5 +1,5 @@
 import type { ExecutorContext } from 'nx/src/config/misc-interfaces';
-import type { BaseNormalizedExecutorContext } from './types';
+import type { BaseNormalizedExecutorContext } from './types.js';
 
 export type NormalizedExecutorContext = BaseNormalizedExecutorContext & {
   projectName: string;
diff --git a/packages/nx-plugin/src/executors/internal/context.unit.test.ts b/packages/nx-plugin/src/executors/internal/context.unit.test.ts
@@ -1,5 +1,5 @@
 import { describe, expect, it } from 'vitest';
-import { normalizeContext } from './context';
+import { normalizeContext } from './context.js';
 
 describe('normalizeContext', () => {
   it('should normalizeContext', () => {
diff --git a/packages/nx-plugin/src/executors/internal/env.unit.test.ts b/packages/nx-plugin/src/executors/internal/env.unit.test.ts
@@ -1,5 +1,5 @@
 import { describe, expect } from 'vitest';
-import { parseEnv } from './env';
+import { parseEnv } from './env.js';
 
 describe('parseEnv', () => {
   it('should parse empty env vars', () => {
diff --git a/packages/nx-plugin/src/generators/configuration/code-pushup-config.integration.test.ts b/packages/nx-plugin/src/generators/configuration/code-pushup-config.integration.test.ts
@@ -3,7 +3,7 @@ import { formatFiles } from '@nx/devkit';
 import { createTreeWithEmptyWorkspace } from '@nx/devkit/testing';
 import * as path from 'node:path';
 import { describe, expect, it } from 'vitest';
-import { generateCodePushupConfig } from './code-pushup-config';
+import { generateCodePushupConfig } from './code-pushup-config.js';
 
 describe('generateCodePushupConfig options', () => {
   let tree: devKit.Tree;
diff --git a/packages/nx-plugin/src/generators/configuration/code-pushup-config.ts b/packages/nx-plugin/src/generators/configuration/code-pushup-config.ts
@@ -2,13 +2,13 @@ import { type Tree, generateFiles, logger } from '@nx/devkit';
 import * as path from 'node:path';
 import type { PersistConfig, UploadConfig } from '@code-pushup/models';
 import type { ItemOrArray } from '@code-pushup/utils';
-import type { ExecutableCode } from './types';
+import type { ExecutableCode } from './types.js';
 import {
   formatArrayToLinesOfJsString,
   formatObjectToFormattedJsString,
   normalizeExecutableCode,
   normalizeItemOrArray,
-} from './utils';
+} from './utils.js';
 
 export const DEFAULT_IMPORTS = [
   "import type { CoreConfig } from '@code-pushup/models';",
diff --git a/packages/nx-plugin/src/generators/configuration/generator.integration.test.ts b/packages/nx-plugin/src/generators/configuration/generator.integration.test.ts
@@ -7,8 +7,8 @@ import {
 import { createTreeWithEmptyWorkspace } from '@nx/devkit/testing';
 import * as path from 'node:path';
 import { afterEach, describe, expect, it, vi } from 'vitest';
-import { DEFAULT_TARGET_NAME, PACKAGE_NAME } from '../../internal/constants';
-import { addTargetToProject, configurationGenerator } from './generator';
+import { DEFAULT_TARGET_NAME, PACKAGE_NAME } from '../../internal/constants.js';
+import { addTargetToProject, configurationGenerator } from './generator.js';
 
 describe('addTargetToProject', () => {
   let tree: Tree;
diff --git a/packages/nx-plugin/src/generators/configuration/generator.ts b/packages/nx-plugin/src/generators/configuration/generator.ts
@@ -6,9 +6,9 @@ import {
   updateProjectConfiguration,
 } from '@nx/devkit';
 import type { ProjectConfiguration } from 'nx/src/config/workspace-json-project-json';
-import { DEFAULT_TARGET_NAME, PACKAGE_NAME } from '../../internal/constants';
-import { generateCodePushupConfig } from './code-pushup-config';
-import type { ConfigurationGeneratorOptions } from './schema';
+import { DEFAULT_TARGET_NAME, PACKAGE_NAME } from '../../internal/constants.js';
+import { generateCodePushupConfig } from './code-pushup-config.js';
+import type { ConfigurationGeneratorOptions } from './schema.js';
 
 export async function configurationGenerator(
   tree: Tree,
diff --git a/packages/nx-plugin/src/generators/configuration/schema.d.ts b/packages/nx-plugin/src/generators/configuration/schema.d.ts
@@ -1,4 +1,4 @@
-import type { DynamicTargetOptions } from '../../internal/types';
+import type { DynamicTargetOptions } from '../../internal/types.js';
 
 export type ConfigurationGeneratorOptions = {
   project: string;
diff --git a/packages/nx-plugin/src/generators/configuration/utils.ts b/packages/nx-plugin/src/generators/configuration/utils.ts
@@ -1,5 +1,5 @@
 import type { ExtractArrays } from '@code-pushup/utils';
-import type { ExecutableCode } from './types';
+import type { ExecutableCode } from './types.js';
 
 export function normalizeExecutableCode(
   executableCode: ExecutableCode,
diff --git a/packages/nx-plugin/src/generators/init/generator.integration.test.ts b/packages/nx-plugin/src/generators/init/generator.integration.test.ts
@@ -1,7 +1,7 @@
 import { type Tree, logger, readJson, readNxJson } from '@nx/devkit';
 import { createTreeWithEmptyWorkspace } from '@nx/devkit/testing';
 import { describe, expect, it, vi } from 'vitest';
-import { initGenerator } from './generator';
+import { initGenerator } from './generator.js';
 
 type PackageJson = {
   devDependencies: Record<string, string>;
diff --git a/packages/nx-plugin/src/generators/init/generator.ts b/packages/nx-plugin/src/generators/init/generator.ts
@@ -12,14 +12,14 @@ import {
   updateNxJson,
 } from '@nx/devkit';
 import type { PackageJson } from 'nx/src/utils/package-json';
-import { PACKAGE_NAME } from '../../internal/constants';
+import { PACKAGE_NAME } from '../../internal/constants.js';
 import {
   cpCliVersion,
   cpModelVersion,
   cpNxPluginVersion,
   cpUtilsVersion,
-} from '../../internal/versions';
-import type { InitGeneratorSchema } from './schema';
+} from '../../internal/versions.js';
+import type { InitGeneratorSchema } from './schema.js';
 
 function checkDependenciesInstalled(host: Tree) {
   const packageJson = readJson<PackageJson>(host, 'package.json');
diff --git a/packages/nx-plugin/src/index.ts b/packages/nx-plugin/src/index.ts
@@ -1,15 +1,18 @@
-import { createNodes } from './plugin/index';
+import { createNodes } from './plugin/index.js';
 
 // default export for nx.json#plugins
 export default createNodes;
 
-export * from './internal/versions';
-export { type InitGeneratorSchema } from './generators/init/schema';
-export { initGenerator, initSchematic } from './generators/init/generator';
-export type { ConfigurationGeneratorOptions } from './generators/configuration/schema';
-export { configurationGenerator } from './generators/configuration/generator';
-export { generateCodePushupConfig } from './generators/configuration/code-pushup-config';
-export { createNodes } from './plugin/index';
-export { executeProcess, type ProcessConfig } from './internal/execute-process';
-export { objectToCliArgs } from './executors/internal/cli';
 export type { AutorunCommandExecutorOptions } from './executors/cli/schema.js';
+export { objectToCliArgs } from './executors/internal/cli.js';
+export { generateCodePushupConfig } from './generators/configuration/code-pushup-config.js';
+export { configurationGenerator } from './generators/configuration/generator.js';
+export type { ConfigurationGeneratorOptions } from './generators/configuration/schema.js';
+export { initGenerator, initSchematic } from './generators/init/generator.js';
+export { type InitGeneratorSchema } from './generators/init/schema.js';
+export {
+  executeProcess,
+  type ProcessConfig,
+} from './internal/execute-process.js';
+export * from './internal/versions.js';
+export { createNodes } from './plugin/index.js';
diff --git a/packages/nx-plugin/src/internal/execute-process.unit.test.ts b/packages/nx-plugin/src/internal/execute-process.unit.test.ts
@@ -1,6 +1,6 @@
 import { describe, expect, it, vi } from 'vitest';
 import { getAsyncProcessRunnerConfig } from '@code-pushup/test-utils';
-import { type ProcessObserver, executeProcess } from './execute-process';
+import { type ProcessObserver, executeProcess } from './execute-process.js';
 
 describe('executeProcess', () => {
   const spyObserver: ProcessObserver = {
diff --git a/packages/nx-plugin/src/plugin/index.ts b/packages/nx-plugin/src/plugin/index.ts
@@ -1,2 +1,2 @@
-export { createNodes } from './plugin';
-export type { CreateNodesOptions } from './types';
+export { createNodes } from './plugin.js';
+export type { CreateNodesOptions } from './types.js';
diff --git a/packages/nx-plugin/src/plugin/plugin.ts b/packages/nx-plugin/src/plugin/plugin.ts
@@ -3,10 +3,10 @@ import type {
   CreateNodesContext,
   CreateNodesResult,
 } from '@nx/devkit';
-import { PROJECT_JSON_FILE_NAME } from '../internal/constants';
-import { createTargets } from './target/targets';
-import type { CreateNodesOptions } from './types';
-import { normalizedCreateNodesContext } from './utils';
+import { PROJECT_JSON_FILE_NAME } from '../internal/constants.js';
+import { createTargets } from './target/targets.js';
+import type { CreateNodesOptions } from './types.js';
+import { normalizedCreateNodesContext } from './utils.js';
 
 // name has to be "createNodes" to get picked up by Nx <v20
 export const createNodes: CreateNodes = [
diff --git a/packages/nx-plugin/src/plugin/plugin.unit.test.ts b/packages/nx-plugin/src/plugin/plugin.unit.test.ts
@@ -2,9 +2,9 @@ import type { CreateNodesContext } from '@nx/devkit';
 import { vol } from 'memfs';
 import { describe, expect } from 'vitest';
 import { invokeCreateNodesOnVirtualFiles } from '@code-pushup/test-nx-utils';
-import { PACKAGE_NAME, PROJECT_JSON_FILE_NAME } from '../internal/constants';
-import { CP_TARGET_NAME } from './constants';
-import { createNodes } from './plugin';
+import { PACKAGE_NAME, PROJECT_JSON_FILE_NAME } from '../internal/constants.js';
+import { CP_TARGET_NAME } from './constants.js';
+import { createNodes } from './plugin.js';
 
 describe('@code-pushup/nx-plugin/plugin', () => {
   let context: CreateNodesContext;
diff --git a/packages/nx-plugin/src/plugin/target/configuration-target.ts b/packages/nx-plugin/src/plugin/target/configuration-target.ts
@@ -1,8 +1,8 @@
 import type { TargetConfiguration } from '@nx/devkit';
 import type { RunCommandsOptions } from 'nx/src/executors/run-commands/run-commands.impl';
-import { objectToCliArgs } from '../../executors/internal/cli';
-import { PACKAGE_NAME } from '../../internal/constants';
-import { CP_TARGET_NAME } from '../constants';
+import { objectToCliArgs } from '../../executors/internal/cli.js';
+import { PACKAGE_NAME } from '../../internal/constants.js';
+import { CP_TARGET_NAME } from '../constants.js';
 
 export function createConfigurationTarget(options?: {
   targetName?: string;
diff --git a/packages/nx-plugin/src/plugin/target/configuration.target.unit.test.ts b/packages/nx-plugin/src/plugin/target/configuration.target.unit.test.ts
@@ -1,6 +1,6 @@
 import { expect } from 'vitest';
-import { PACKAGE_NAME } from '../../internal/constants';
-import { createConfigurationTarget } from './configuration-target';
+import { PACKAGE_NAME } from '../../internal/constants.js';
+import { createConfigurationTarget } from './configuration-target.js';
 
 describe('createConfigurationTarget', () => {
   it('should return code-pushup--configuration target for given project', () => {
diff --git a/packages/nx-plugin/src/plugin/target/executor-target.ts b/packages/nx-plugin/src/plugin/target/executor-target.ts
@@ -1,6 +1,6 @@
 import type { TargetConfiguration } from '@nx/devkit';
-import { PACKAGE_NAME } from '../../internal/constants';
-import type { ProjectPrefixOptions } from '../types';
+import { PACKAGE_NAME } from '../../internal/constants.js';
+import type { ProjectPrefixOptions } from '../types.js';
 
 export function createExecutorTarget(options?: {
   bin?: string;
diff --git a/packages/nx-plugin/src/plugin/target/executor.target.unit.test.ts b/packages/nx-plugin/src/plugin/target/executor.target.unit.test.ts
@@ -1,5 +1,5 @@
 import { expect } from 'vitest';
-import { createExecutorTarget } from './executor-target';
+import { createExecutorTarget } from './executor-target.js';
 
 describe('createExecutorTarget', () => {
   it('should return executor target without project name', () => {
diff --git a/packages/nx-plugin/src/plugin/target/targets.ts b/packages/nx-plugin/src/plugin/target/targets.ts
@@ -1,12 +1,12 @@
 import { readdir } from 'node:fs/promises';
-import { CP_TARGET_NAME } from '../constants';
+import { CP_TARGET_NAME } from '../constants.js';
 import type {
   CreateNodesOptions,
   ProjectConfigurationWithName,
-} from '../types';
-import { createConfigurationTarget } from './configuration-target';
-import { CODE_PUSHUP_CONFIG_REGEX } from './constants';
-import { createExecutorTarget } from './executor-target';
+} from '../types.js';
+import { createConfigurationTarget } from './configuration-target.js';
+import { CODE_PUSHUP_CONFIG_REGEX } from './constants.js';
+import { createExecutorTarget } from './executor-target.js';
 
 export type CreateTargetsOptions = {
   projectJson: ProjectConfigurationWithName;
diff --git a/packages/nx-plugin/src/plugin/target/targets.unit.test.ts b/packages/nx-plugin/src/plugin/target/targets.unit.test.ts
@@ -2,10 +2,10 @@ import { vol } from 'memfs';
 import { rm } from 'node:fs/promises';
 import { afterEach, beforeEach, expect } from 'vitest';
 import { MEMFS_VOLUME } from '@code-pushup/test-utils';
-import { DEFAULT_TARGET_NAME, PACKAGE_NAME } from '../../internal/constants';
-import { CP_TARGET_NAME } from '../constants';
-import type { NormalizedCreateNodesContext } from '../types';
-import { createTargets } from './targets';
+import { DEFAULT_TARGET_NAME, PACKAGE_NAME } from '../../internal/constants.js';
+import { CP_TARGET_NAME } from '../constants.js';
+import type { NormalizedCreateNodesContext } from '../types.js';
+import { createTargets } from './targets.js';
 
 describe('createTargets', () => {
   beforeEach(async () => {
diff --git a/packages/nx-plugin/src/plugin/types.ts b/packages/nx-plugin/src/plugin/types.ts
@@ -4,8 +4,8 @@ import type {
   ProjectConfiguration,
 } from '@nx/devkit';
 import type { WithRequired } from '@code-pushup/utils';
-import type { DynamicTargetOptions } from '../internal/types';
-import type { CreateTargetsOptions } from './target/targets';
+import type { DynamicTargetOptions } from '../internal/types.js';
+import type { CreateTargetsOptions } from './target/targets.js';
 
 export type ProjectPrefixOptions = {
   projectPrefix?: string;
diff --git a/packages/nx-plugin/src/plugin/utils.ts b/packages/nx-plugin/src/plugin/utils.ts
@@ -1,13 +1,13 @@
 import type { CreateNodesContext, CreateNodesContextV2 } from '@nx/devkit';
 import { readFile } from 'node:fs/promises';
 import * as path from 'node:path';
-import { CP_TARGET_NAME } from './constants';
+import { CP_TARGET_NAME } from './constants.js';
 import type {
   CreateNodesOptions,
   NormalizedCreateNodesContext,
   NormalizedCreateNodesV2Context,
   ProjectConfigurationWithName,
-} from './types';
+} from './types.js';
 
 export async function normalizedCreateNodesContext(
   context: CreateNodesContext,
diff --git a/packages/nx-plugin/src/plugin/utils.unit.test.ts b/packages/nx-plugin/src/plugin/utils.unit.test.ts
@@ -2,7 +2,7 @@ import { vol } from 'memfs';
 import { describe, expect } from 'vitest';
 import { createNodesContext } from '@code-pushup/test-nx-utils';
 import { MEMFS_VOLUME } from '@code-pushup/test-utils';
-import { normalizedCreateNodesContext } from './utils';
+import { normalizedCreateNodesContext } from './utils.js';
 
 describe('normalizedCreateNodesContext', () => {
   it('should provide workspaceRoot', async () => {
