refactor: fix lint

Author: John Doe

packages/nx-plugin/src/executors/cli/executor.ts

@@ -1,4 +1,4 @@
-import { type ExecutorContext } from '@nx/devkit';
+import type { ExecutorContext } from '@nx/devkit';
 import { executeProcess } from '../../internal/execute-process.js';
 import type { AutorunCommandExecutorOptions } from './schema.js';
 
@@ -8,13 +8,13 @@ export type ExecutorOutput = {
   error?: Error;
 };
 
+/* eslint-disable max-lines-per-function */
 export default async function runAutorunExecutor(
   terminalAndExecutorOptions: AutorunCommandExecutorOptions,
   { cwd }: ExecutorContext,
 ): Promise<ExecutorOutput> {
   const { logger, stringifyError, objectToCliArgs, formatCommand } =
     await import('@code-pushup/utils');
-
   const {
     dryRun,
     verbose,
@@ -23,7 +23,6 @@ export default async function runAutorunExecutor(
     bin,
     ...argsObj
   } = terminalAndExecutorOptions;
-
   const command = bin ? `node` : 'npx';
   const positionals = [
     bin ?? '@code-pushup/cli',
@@ -35,7 +34,6 @@ export default async function runAutorunExecutor(
     ...env,
     ...(verbose && { CP_VERBOSE: 'true' }),
   };
-
   const binString = `${command} ${positionals.join(' ')} ${args.join(' ')}`;
   const formattedBinString = formatCommand(binString, {
     env: envVariables,
@@ -67,3 +65,4 @@ export default async function runAutorunExecutor(
     command: formattedBinString,
   };
 }
+/* eslint-enable max-lines-per-function */

packages/nx-plugin/src/executors/internal/cli.ts

@@ -23,7 +23,7 @@ export function globalConfig(
 
 export function persistConfig(
   options: Partial<PersistConfig & ProjectExecutorOnlyOptions>,
-  context: BaseNormalizedExecutorContext,
+  _context: BaseNormalizedExecutorContext,
 ): Partial<PersistConfig> {
   const {
     format,

packages/nx-plugin/src/executors/internal/config.ts

@@ -10,9 +10,8 @@ export async function createConfigurationTarget(options?: {
   const args = objectToCliArgs({
     ...(projectName ? { project: projectName } : {}),
   });
-  const argsString = args.length > 0 ? args.join(' ') : '';
-  const baseCommand = `nx g ${PACKAGE_NAME}:configuration`;
+  const argsString = args.length > 0 ? ` ${args.join(' ')}` : '';
   return {
-    command: `nx g ${PACKAGE_NAME}:configuration${args.length > 0 ? ` ${args.join(' ')}` : ''}`,
+    command: `nx g ${PACKAGE_NAME}:configuration${argsString}`,
   };
 }

packages/nx-plugin/src/plugin/target/configuration-target.ts

@@ -4,15 +4,15 @@ import { createConfigurationTarget } from './configuration-target.js';
 
 describe('createConfigurationTarget', () => {
   it('should return code-pushup--configuration target for given project', async () => {
-    expect(
-      await createConfigurationTarget({ projectName: 'my-project' }),
-    ).toStrictEqual({
+    await expect(
+      createConfigurationTarget({ projectName: 'my-project' }),
+    ).resolves.toStrictEqual({
       command: `nx g ${PACKAGE_NAME}:configuration --project="my-project"`,
     });
   });
 
   it('should return code-pushup--configuration target without project name', async () => {
-    expect(await createConfigurationTarget()).toStrictEqual({
+    await expect(createConfigurationTarget()).resolves.toStrictEqual({
       command: `nx g ${PACKAGE_NAME}:configuration`,
     });
   });

packages/nx-plugin/src/plugin/target/configuration.target.unit.test.ts

@@ -554,9 +554,9 @@ export function formatCommand(
   const cwdPrefix = cwd ? ansis.blue(cwd) : '';
   const envString =
     options?.env && Object.keys(options.env).length > 0
-      ? Object.entries(options.env).map(([key, value]) => {
-          return ansis.gray(`${key}="${value}"`);
-        })
+      ? Object.entries(options.env).map(([key, value]) =>
+          ansis.gray(`${key}="${value}"`),
+        )
       : [];
   const statusColor =
     status === 'pending'

packages/utils/src/lib/logger.ts

@@ -102,7 +102,7 @@ export function objectToCliArgs<
       return [`${prefix}${value ? '' : 'no-'}${key}`];
     }
 
-    if (value === null || value === undefined) {
+    if (value == null) {
       return [];
     }