Skip to content

Commit b8c4659

Browse files
author
John Doe
committed
refactor: wip
1 parent 9a1558e commit b8c4659

File tree

5 files changed

+13
-11
lines changed

5 files changed

+13
-11
lines changed

packages/nx-plugin/src/executors/cli/executor.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,10 @@ export default async function runAutorunExecutor(
1212
terminalAndExecutorOptions: AutorunCommandExecutorOptions,
1313
{ cwd }: ExecutorContext,
1414
): Promise<ExecutorOutput> {
15-
const { logger, stringifyError, formatCommand, objectToCliArgs } =
16-
await import('@code-pushup/utils');
15+
const { logger, stringifyError, formatCommand } = await import(
16+
'@code-pushup/utils'
17+
);
18+
const { objectToCliArgs } = await import('@code-pushup/utils');
1719

1820
const {
1921
dryRun,

packages/nx-plugin/src/plugin/target/configuration-target.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
import type { TargetConfiguration } from '@nx/devkit';
22
import type { RunCommandsOptions } from 'nx/src/executors/run-commands/run-commands.impl';
3-
import { objectToCliArgs } from '../../executors/internal/cli.js';
43
import { PACKAGE_NAME } from '../../internal/constants.js';
54

6-
export function createConfigurationTarget(options?: {
5+
export async function createConfigurationTarget(options?: {
76
projectName?: string;
8-
}): TargetConfiguration<RunCommandsOptions> {
7+
}): Promise<TargetConfiguration<RunCommandsOptions>> {
98
const { projectName } = options ?? {};
9+
const { objectToCliArgs } = await import('@code-pushup/utils');
1010
const args = objectToCliArgs({
1111
...(projectName ? { project: projectName } : {}),
1212
});

packages/nx-plugin/src/plugin/target/configuration.target.unit.test.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,16 @@ import { PACKAGE_NAME } from '../../internal/constants.js';
33
import { createConfigurationTarget } from './configuration-target.js';
44

55
describe('createConfigurationTarget', () => {
6-
it('should return code-pushup--configuration target for given project', () => {
6+
it('should return code-pushup--configuration target for given project', async () => {
77
expect(
8-
createConfigurationTarget({ projectName: 'my-project' }),
8+
await createConfigurationTarget({ projectName: 'my-project' }),
99
).toStrictEqual({
1010
command: `nx g ${PACKAGE_NAME}:configuration --project="my-project"`,
1111
});
1212
});
1313

14-
it('should return code-pushup--configuration target without project name', () => {
15-
expect(createConfigurationTarget()).toStrictEqual({
14+
it('should return code-pushup--configuration target without project name', async () => {
15+
expect(await createConfigurationTarget()).toStrictEqual({
1616
command: `nx g ${PACKAGE_NAME}:configuration`,
1717
});
1818
});

packages/nx-plugin/src/plugin/target/targets.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ export async function createTargets(normalizedContext: CreateTargetsOptions) {
2828
}
2929
: // if NO code-pushup.config.*.(ts|js|mjs) is present return configuration target
3030
{
31-
[`${targetName}--configuration`]: createConfigurationTarget({
31+
[`${targetName}--configuration`]: await createConfigurationTarget({
3232
projectName: normalizedContext.projectJson.name,
3333
}),
3434
};

tools/src/debug/debug.plugin.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import type { CreateNodes, CreateNodesContext } from '@nx/devkit';
22
import { dirname } from 'node:path';
3-
import { objectToCliArgs } from '../../../packages/nx-plugin/src/executors/internal/cli.js';
3+
import { objectToCliArgs } from '@code-pushup/utils';
44
import { TOOLS_TSCONFIG_PATH } from '../constants.js';
55
import { KILL_PROCESS_BIN, LIST_PROCESS_BIN } from './constants.js';
66

0 commit comments

Comments
 (0)