Merge pull request #18 from code-store-platform/feat/optional-promise-for-getPublicationDate-and-getDisplayDate

feat/optional promise for getPublicationDate and getDisplayDate

Author: ellankz

CHANGELOG.md

@@ -1,5 +1,11 @@
 # @code.store/arcxp-sdk-ts
 
+## 4.43.2
+
+### Patch Changes
+
+- MaybePromise for getPublicationDate and getDisplayDate
+
 ## 4.43.1
 
 ### Patch Changes

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@code.store/arcxp-sdk-ts",
-  "version": "4.43.1",
+  "version": "4.43.2",
   "description": "A strongly typed set of ArcXP API's and utilities reduce the amount of work required to develop with ArcXP, starting with reducing the boilerplate code you have to write.",
   "type": "commonjs",
   "main": "./dist/index.js",

src/mapper/doc.ts

@@ -115,15 +115,15 @@ export abstract class Document<ANS extends ANSContent> {
     return date.toISOString();
   }
 
-  protected getDisplayDate(): Optional<Date> {
+  protected getDisplayDate(): MaybePromise<Optional<Date>> {
     return new Date();
   }
 
   protected async getContentElements(): Promise<ArcTypes.ContentElements.ContentElementType<any>[]> {
     return [];
   }
 
-  protected getPublicationDate(): Optional<Date> {
+  protected getPublicationDate(): MaybePromise<Optional<Date>> {
     return new Date();
   }
 

src/mapper/story.ts

@@ -28,7 +28,8 @@ export abstract class Story<ANS extends ANSContent = Types.Story.AStory> extends
     const id = await this.arcId();
     const version = this.version();
     const type = this.type();
-    const publicationDate = this.getPublicationDate();
+    const publicationDate = await this.getPublicationDate();
+    const displayDate = await this.getDisplayDate();
     const headlines = this.getHeadlines();
     const subheadlines = this.getSubheadlines();
     const description = this.getDescription();
@@ -76,7 +77,7 @@ export abstract class Story<ANS extends ANSContent = Types.Story.AStory> extends
       created_date: this.formatDate(new Date()),
       first_publish_date: this.formatDate(publicationDate),
       publish_date: this.formatDate(publicationDate),
-      display_date: this.formatDate(this.getDisplayDate()),
+      display_date: this.formatDate(displayDate),
       source,
       comments,
       taxonomy: {