Do not read all response before JSON decode

anahan · anahan · commit bfa74574fb13 · 2023-07-20T10:15:48.000+02:00
diff --git a/pkg/phpfpm/status.go b/pkg/phpfpm/status.go
@@ -43,12 +43,8 @@ func GetStats(net, addr, statusPath string) (*Status, error) {
 	}
 	defer tryClose(resp.Body)
 
-	content, err := io.ReadAll(resp.Body)
-	if err != nil {
-		return nil, err
-	}
 	s := Status{}
-	err = json.Unmarshal(content, &s)
+	err = json.NewDecoder(resp.Body).Decode(&s)
 	if err != nil {
 		return nil, err
 	}

Original file line number	Diff line number	Diff line change
`@@ -43,12 +43,8 @@ func GetStats(net, addr, statusPath string) (*Status, error) {`
`43`	`43`	`}`
`44`	`44`	`defer tryClose(resp.Body)`
`45`	`45`
`46`		`- content, err := io.ReadAll(resp.Body)`
`47`		`- if err != nil {`
`48`		`- return nil, err`
`49`		`- }`
`50`	`46`	`s := Status{}`
`51`		`- err = json.Unmarshal(content, &s)`
	`47`	`+ err = json.NewDecoder(resp.Body).Decode(&s)`
`52`	`48`	`if err != nil {`
`53`	`49`	`return nil, err`
`54`	`50`	`}`