Merge pull request #2 from andrew-demb/patch-1

allflame · web-flow · commit 7d504e96dd7a · 2019-10-23T15:34:11.000+03:00
Fix return type for Connection::connect() in wrapper
diff --git a/src/Wrapper/JaegerConnectionWrapper.php b/src/Wrapper/JaegerConnectionWrapper.php
@@ -33,11 +33,11 @@ public function setTracer(TracerInterface $tracer)
     public function connect()
     {
         if ($this->isConnected()) {
-            return;
+            return false;
         }
         $span = $this->tracer->start('dbal.connect');
         try {
-            parent::connect();
+            return parent::connect();
         } catch (\Exception $e) {
             $span->addTag(new DbalErrorCodeTag($e->getCode()))
                 ->addTag(new ErrorTag());

Original file line number	Diff line number	Diff line change
`@@ -33,11 +33,11 @@ public function setTracer(TracerInterface $tracer)`
`33`	`33`	`public function connect()`
`34`	`34`	`{`
`35`	`35`	`if ($this->isConnected()) {`
`36`		`- return;`
	`36`	`+ return false;`
`37`	`37`	`}`
`38`	`38`	`$span = $this->tracer->start('dbal.connect');`
`39`	`39`	`try {`
`40`		`- parent::connect();`
	`40`	`+ return parent::connect();`
`41`	`41`	`} catch (\Exception $e) {`
`42`	`42`	`$span->addTag(new DbalErrorCodeTag($e->getCode()))`
`43`	`43`	`->addTag(new ErrorTag());`