Do not trigger exception in finally

allflame · allflame · commit 9b2ca17b5856 · 2018-09-26T11:57:19.000+03:00
diff --git a/src/Wrapper/JaegerConnectionWrapper.php b/src/Wrapper/JaegerConnectionWrapper.php
@@ -48,7 +48,10 @@ public function connect()
                 ->addTag(new ErrorTag());
             throw $e;
         } finally {
-            $this->tracer->finish($span->addTag(new DbType($this->getDatabasePlatform()->getName())));
+            if ($this->isConnected()) {
+                $span->addTag(new DbType($this->getDatabasePlatform()->getName()));
+            }
+            $this->tracer->finish($span);
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,10 @@ public function connect()`
`48`	`48`	`->addTag(new ErrorTag());`
`49`	`49`	`throw $e;`
`50`	`50`	`} finally {`
`51`		`- $this->tracer->finish($span->addTag(new DbType($this->getDatabasePlatform()->getName())));`
	`51`	`+ if ($this->isConnected()) {`
	`52`	`+ $span->addTag(new DbType($this->getDatabasePlatform()->getName()));`
	`53`	`+ }`
	`54`	`+ $this->tracer->finish($span);`
`52`	`55`	`}`
`53`	`56`	`}`
`54`	`57`