Skip to content

Commit 28de452

Browse files
authored
Merge pull request #16 from dozer111/fix-php8.4-deprecation
fix PHP8.4 deprecation "Implicitly nullable parameter declarations deprecated
2 parents 8f43170 + ac19a28 commit 28de452

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/Tracer/Tracer.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ public function debug(string $operationName, array $tags = []): SpanInterface
8989
return $span;
9090
}
9191

92-
public function start(string $operationName, array $tags = [], SpanContext $userContext = null): SpanInterface
92+
public function start(string $operationName, array $tags = [], ?SpanContext $userContext = null): SpanInterface
9393
{
9494
if (null === ($context = $userContext ?: $this->manager->getContext())) {
9595
$span = $this->factory->parent($this, $operationName, $this->debugId, $tags);
@@ -101,7 +101,7 @@ public function start(string $operationName, array $tags = [], SpanContext $user
101101
return $span;
102102
}
103103

104-
public function getContext(SpanContext $userContext = null): ?SpanContext
104+
public function getContext(?SpanContext $userContext = null): ?SpanContext
105105
{
106106
return $this->manager->getContext();
107107
}

src/Tracer/TracerInterface.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,5 @@
88

99
interface TracerInterface extends FinishableInterface
1010
{
11-
public function start(string $operationName, array $tags = [], SpanContext $context = null): SpanInterface;
11+
public function start(string $operationName, array $tags = [], ?SpanContext $context = null): SpanInterface;
1212
}

0 commit comments

Comments
 (0)