📦 Ensure retrieved data from event. Drop unused variable. Check controller only for null value

Author: andrew-demb

src/Name/Generator/CommandNameGenerator.php

@@ -36,10 +36,11 @@ public static function getSubscribedEvents(): array
 
     public function onCommand(ConsoleCommandEvent $event): void
     {
-        if (null === $event->getCommand()) {
+        if (null === $command = $event->getCommand()) {
             return;
         }
-        $this->name = (string)$event->getCommand()->getName();
+
+        $this->name = (string)$command->getName();
     }
 
     public function onTerminate(): CommandNameGenerator

src/Name/Generator/DefaultNameGenerator.php

@@ -26,22 +26,24 @@ public static function getSubscribedEvents(): array
 
     public function onCommand(ConsoleCommandEvent $event): void
     {
-        if (null === $event->getCommand()) {
+        if (null === $command = $event->getCommand()) {
             return;
         }
 
-        $this->name = (string)$event->getCommand()->getName();
+        $this->name = (string)$command->getName();
     }
 
     public function onRequest(RequestEvent $event): void
     {
         $request = $event->getRequest();
-        if (null !== ($fragment = $request->attributes->get('is_fragment'))) {
-            $this->name = ($controller = $request->attributes->get('_controller', null))
+        if (null !== $request->attributes->get('is_fragment')) {
+            $this->name = (null !== $controller = $request->attributes->get('_controller', null))
                 ? sprintf('fragment.%s', $controller)
                 : 'fragment';
+
             return;
         }
+
         $this->name = $request->attributes->get('_route', $request->getRequestUri());
     }