Skip to content

Commit 51e9c3f

Browse files
committed
Pass time as int
1 parent 59d94a7 commit 51e9c3f

File tree

2 files changed

+20
-18
lines changed

2 files changed

+20
-18
lines changed

src/Bridge/GlobalSpanListener.php

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ public function onRequest(GetResponseEvent $event)
5454
}
5555

5656
$request = $event->getRequest();
57-
$requestSpan = $this->tracer->start(
57+
$this->span = $this->tracer->start(
5858
$this->nameGenerator->generate(),
5959
[
6060
new HttpMethodTag($request->getMethod()),
@@ -63,10 +63,7 @@ public function onRequest(GetResponseEvent $event)
6363
new SymfonyComponentTag(),
6464
new SymfonyVersionTag()
6565
]
66-
);
67-
$this->span = $requestSpan->start(
68-
(int)(1000000 * $request->server->get('REQUEST_TIME_FLOAT', microtime(true)))
69-
);
66+
)->start((int)(1000000 * $request->server->get('REQUEST_TIME_FLOAT', microtime(true))));
7067

7168
return $this;
7269
}

src/Bridge/RequestSpanListener.php

Lines changed: 18 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,10 @@ public static function getSubscribedEvents()
4242

4343
public function onResponse(FilterResponseEvent $event)
4444
{
45+
if (HttpKernelInterface::MASTER_REQUEST === $event->getRequestType()) {
46+
return $this;
47+
}
48+
4549
if ($this->spans->isEmpty()) {
4650
return $this;
4751
}
@@ -52,22 +56,23 @@ public function onResponse(FilterResponseEvent $event)
5256

5357
public function onRequest(GetResponseEvent $event)
5458
{
55-
$request = $event->getRequest();
56-
$requestSpan = $this->tracer->start(
57-
$this->nameGenerator->generate(),
58-
[
59-
new HttpMethodTag($request->getMethod()),
60-
new HttpUriTag($request->getRequestUri()),
61-
new SpanKindServerTag(),
62-
new SymfonyComponentTag(),
63-
new SymfonyVersionTag()
64-
]
65-
);
6659
if (HttpKernelInterface::MASTER_REQUEST === $event->getRequestType()) {
67-
$requestSpan->start((int)(1000000 * $request->server->get('REQUEST_TIME_FLOAT', microtime(true))));
60+
return $this;
6861
}
6962

70-
$this->spans->push($requestSpan);
63+
$request = $event->getRequest();
64+
$this->spans->push(
65+
$this->tracer->start(
66+
$this->nameGenerator->generate(),
67+
[
68+
new HttpMethodTag($request->getMethod()),
69+
new HttpUriTag($request->getRequestUri()),
70+
new SpanKindServerTag(),
71+
new SymfonyComponentTag(),
72+
new SymfonyVersionTag()
73+
]
74+
)
75+
);
7176

7277
return $this;
7378
}

0 commit comments

Comments
 (0)