Merge pull request #13 from eugy-scroodgee/fix-rateilimiting-sampler-creating

allflame · web-flow · commit 7d3f068b8dfc · 2020-10-15T16:43:36.000+03:00
added typecast for param when creating RateLimitingSampler
diff --git a/src/Bridge/JaegerSamplerFactory.php b/src/Bridge/JaegerSamplerFactory.php
@@ -38,7 +38,7 @@ public function sampler(string $type, $param): SamplerInterface
                     return new ProbabilisticSampler((float)$param);
                 }
 
-                return new RateLimitingSampler($param, new ConstGenerator());
+                return new RateLimitingSampler((float)$param, new ConstGenerator());
             case 'adaptive':
                 if (false === $this->isApcuOn()) {
                     return new ProbabilisticSampler((float)$param);

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ public function sampler(string $type, $param): SamplerInterface`
`38`	`38`	`return new ProbabilisticSampler((float)$param);`
`39`	`39`	`}`
`40`	`40`
`41`		`- return new RateLimitingSampler($param, new ConstGenerator());`
	`41`	`+ return new RateLimitingSampler((float)$param, new ConstGenerator());`
`42`	`42`	`case 'adaptive':`
`43`	`43`	`if (false === $this->isApcuOn()) {`
`44`	`44`	`return new ProbabilisticSampler((float)$param);`