Added docs for the regexp, moved regexp generation to the configuration

Author: allflame

README.md

@@ -41,7 +41,7 @@ jaeger:
 ## Name generation options
 
 You can specify just the suffix, if you name generator service is named as `jaeger.name.generator.*` or if you have any other naming scheme you can put the whole name into the configuration.
-Keys are considered regular expressions that `route` of the request or `name` of the command should match to use alternative generator.
+Keys are considered body of the regular expression pattern, do not put any modifiers (e.g. `/i`, `/g`) or slashes; `route` of the request or `name` of the command should match to use alternative generator.
 Expressions are checked top to bottom, if no match is found, default generator will be used
 
 Example bundle config with name generation feature:
@@ -52,7 +52,7 @@ jaeger:
   name_generator:
     max_length: 32
     command:  
-      '.*': 'controller'
+      .* : 'controller'
     request:
       'brand_routes_\d+': 'my_service_generator_alias'
 ```

src/DependencyInjection/JaegerExtension.php

@@ -29,30 +29,32 @@ public function load(array $configs, ContainerBuilder $container)
         if ($this->isConfigEnabled($container, $config['name_generator'])) {
             $container->setParameter('jaeger.name.max_length', (int)$config['name_generator']['max_length']);
             foreach ($config['name_generator']['request'] as $item => $customGeneratorId) {
+                $regexp = \sprintf('/%s/', $item);
                 $shortenedGeneratorId = \sprintf('jaeger.name.generator.%s', $customGeneratorId);
                 if ($container->has($shortenedGeneratorId)) {
                     $container->getDefinition('jaeger.name.generator.request')->addMethodCall(
                         'add',
-                        [$item, new Reference($shortenedGeneratorId)]
+                        [$regexp, new Reference($shortenedGeneratorId)]
                     );
                 } else {
                     $container->getDefinition('jaeger.name.generator.request')->addMethodCall(
                         'add',
-                        [$item, new Reference($customGeneratorId)]
+                        [$regexp, new Reference($customGeneratorId)]
                     );
                 }
             }
             foreach ($config['name_generator']['command'] as $item => $customGeneratorId) {
+                $regexp = \sprintf('/%s/', $item);
                 $shortenedGeneratorId = \sprintf('jaeger.name.generator.%s', $customGeneratorId);
                 if ($container->has($shortenedGeneratorId)) {
                     $container->getDefinition('jaeger.name.generator.command')->addMethodCall(
                         'add',
-                        [$item, new Reference($shortenedGeneratorId)]
+                        [$regexp, new Reference($shortenedGeneratorId)]
                     );
                 } else {
                     $container->getDefinition('jaeger.name.generator.command')->addMethodCall(
                         'add',
-                        [$item, new Reference($customGeneratorId)]
+                        [$regexp, new Reference($customGeneratorId)]
                     );
                 }
             }

src/Name/Generator/CommandNameGenerator.php

@@ -20,7 +20,7 @@ public function __construct(array $generators = [])
 
     public function add(string $regexp, NameGeneratorInterface $generator): CommandNameGenerator
     {
-        $this->generators[sprintf('/%s/', $regexp)] = $generator;
+        $this->generators[$regexp] = $generator;
 
         return $this;
     }

src/Name/Generator/RequestNameGenerator.php

@@ -20,7 +20,7 @@ public function __construct(array $generators = [])
 
     public function add(string $regexp, NameGeneratorInterface $generator): RequestNameGenerator
     {
-        $this->generators[sprintf('/%s/', $regexp)] = $generator;
+        $this->generators[$regexp] = $generator;
 
         return $this;
     }