PHP5 Compliance

Author: allflame

src/Bridge/ContextInjector.php

@@ -29,7 +29,7 @@ public static function getSubscribedEvents()
         ];
     }
 
-    public function inject(): ContextInjector
+    public function inject()
     {
         if (null === ($context = $this->extractor->extract())) {
             return $this;

src/Context/Extractor/ContextExtractorChain.php

@@ -1,6 +1,4 @@
 <?php
-declare(strict_types=1);
-
 namespace Jaeger\Symfony\Context\Extractor;
 
 use Jaeger\Span\Context\SpanContext;
@@ -14,14 +12,23 @@ public function __construct(\SplPriorityQueue $queue)
         $this->queue = $queue;
     }
 
-    public function add(ContextExtractorInterface $extractor, int $priority = 0): ContextExtractorChain
+    /**
+     * @param ContextExtractorInterface $extractor
+     * @param int                       $priority
+     *
+     * @return ContextExtractorChain
+     */
+    public function add(ContextExtractorInterface $extractor, $priority = 0)
     {
-        $this->queue->insert($extractor, $priority);
+        $this->queue->insert($extractor, (int)$priority);
 
         return $this;
     }
 
-    public function extract(): ?SpanContext
+    /**
+     * @return SpanContext|null
+     */
+    public function extract()
     {
         $queue = clone $this->queue;
         while (false === $queue->isEmpty()) {

src/Context/Extractor/ContextExtractorInterface.php

@@ -1,11 +1,12 @@
 <?php
-declare(strict_types=1);
-
 namespace Jaeger\Symfony\Context\Extractor;
 
 use Jaeger\Span\Context\SpanContext;
 
 interface ContextExtractorInterface
 {
-    public function extract() : ?SpanContext;
+    /**
+     * @return SpanContext|null
+     */
+    public function extract();
 }

src/Context/Extractor/EnvContextExtractor.php

@@ -1,5 +1,4 @@
 <?php
-declare(strict_types=1);
 
 namespace Jaeger\Symfony\Context\Extractor;
 
@@ -21,14 +20,24 @@ class EnvContextExtractor implements ContextExtractorInterface
 
     private $context;
 
-    public function __construct(CodecRegistry $registry, string $format, string $envName)
+    /**
+     * EnvContextExtractor constructor.
+     *
+     * @param CodecRegistry $registry
+     * @param string        $format
+     * @param string        $envName
+     */
+    public function __construct(CodecRegistry $registry, $format, $envName)
     {
         $this->registry = $registry;
-        $this->format = $format;
-        $this->envName = $envName;
+        $this->format = (string)$format;
+        $this->envName = (string)$envName;
     }
 
-    public function extract(): ?SpanContext
+    /**
+     * @return SpanContext|null
+     */
+    public function extract()
     {
         return $this->context;
     }
@@ -42,7 +51,11 @@ public static function getSubscribedEvents()
 
     public function onCommand()
     {
-        if (null === ($data = $_ENV[$this->envName] ?? null)) {
+        if (false === array_key_exists($this->envName, $_ENV)) {
+            return $this;
+        }
+
+        if (null === ($data = $_ENV[$this->envName])) {
             return $this;
         }
 

src/Context/Extractor/HeaderContextExtractor.php

@@ -1,6 +1,4 @@
 <?php
-declare(strict_types=1);
-
 namespace Jaeger\Symfony\Context\Extractor;
 
 use Jaeger\Codec\CodecInterface;
@@ -23,14 +21,24 @@ class HeaderContextExtractor implements ContextExtractorInterface
 
     private $context;
 
-    public function __construct(CodecRegistry $registry, string $format, string $headerName)
+    /**
+     * HeaderContextExtractor constructor.
+     *
+     * @param CodecRegistry $registry
+     * @param string        $format
+     * @param string        $headerName
+     */
+    public function __construct(CodecRegistry $registry, $format, $headerName)
     {
         $this->registry = $registry;
-        $this->format = $format;
-        $this->headerName = $headerName;
+        $this->format = (string)$format;
+        $this->headerName = (string)$headerName;
     }
 
-    public function extract(): ?SpanContext
+    /**
+     * @return SpanContext|null
+     */
+    public function extract()
     {
         return $this->context;
     }

src/Resources/DependencyInjection/ExtractorChainCompilerPass.php

@@ -1,6 +1,4 @@
 <?php
-declare(strict_types=1);
-
 namespace Jaeger\Symfony\Resources\DependencyInjection;
 
 use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
@@ -25,7 +23,7 @@ public function process(ContainerBuilder $container)
                         sprintf('Required tag field %s is missing from definition', 'alias')
                     );
                 }
-                $priority = $tag['priority'] ?? 0;
+                $priority = array_key_exists('priority', $tag) ? $tag['priority'] : 0;
                 $definition->addMethodCall('add', [new Reference($id), $priority]);
             }
         }