Skip to content

Commit e46e29f

Browse files
committed
Spllit ContextInjector into 2 classes
1 parent 1adb99b commit e46e29f

File tree

4 files changed

+12
-15
lines changed

4 files changed

+12
-15
lines changed

src/Bridge/AppStartSpanListener.php

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11
<?php
2-
declare(strict_types=1);
3-
42
namespace Jaeger\Symfony\Bridge;
53

64
use Jaeger\Tracer\TracerInterface;
@@ -19,7 +17,12 @@ public function __construct(TracerInterface $tracer)
1917
$this->tracer = $tracer;
2018
}
2119

22-
public function getStartTime(Request $request): int
20+
/**
21+
* @param Request $request
22+
*
23+
* @return int
24+
*/
25+
public function getStartTime(Request $request)
2326
{
2427
return (int)($request->server->get('REQUEST_TIME_FLOAT', microtime(true)) * 1000000);
2528
}

src/Bridge/ContextInjector.php

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11
<?php
2-
declare(strict_types=1);
3-
42
namespace Jaeger\Symfony\Bridge;
53

64
use Jaeger\Codec\CodecInterface;
@@ -34,9 +32,9 @@ public function __construct(
3432
InjectableInterface $injectable,
3533
TracerInterface $tracer,
3634
CodecRegistry $registry,
37-
string $format,
38-
string $envName,
39-
string $headerName
35+
$format,
36+
$envName,
37+
$headerName
4038
) {
4139
$this->injectable = $injectable;
4240
$this->tracer = $tracer;
@@ -56,7 +54,7 @@ public static function getSubscribedEvents()
5654

5755
public function onCommand()
5856
{
59-
if (($data = $_ENV[$this->envName] ?? null)
57+
if (($data = $_ENV[$this->envName] ? $_ENV[$this->envName]: null)
6058
&& $context = $this->registry[$this->format]->decode($data)) {
6159
$this->injectable->assign($context);
6260
}

src/Bridge/RequestSpanListener.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11
<?php
2-
declare(strict_types=1);
3-
42
namespace Jaeger\Symfony\Bridge;
53

64
use Jaeger\Http\HttpCodeTag;

src/Bridge/TracerBridge.php

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11
<?php
2-
declare(strict_types=1);
3-
42
namespace Jaeger\Symfony\Bridge;
53

64
use Jaeger\Tracer\FlushableInterface;
@@ -20,8 +18,8 @@ public function __construct(FlushableInterface $tracer)
2018
public static function getSubscribedEvents()
2119
{
2220
return [
23-
ConsoleEvents::TERMINATE => [['onTerminate']],
24-
KernelEvents::TERMINATE => [['onTerminate']],
21+
ConsoleEvents::TERMINATE => ['onTerminate'],
22+
KernelEvents::TERMINATE => ['onTerminate'],
2523
];
2624
}
2725

0 commit comments

Comments
 (0)