Skip to content

Commit 90059ec

Browse files
author
anahan
committed
Class naming refactoring
1 parent a562943 commit 90059ec

5 files changed

+17
-7
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ How to use
66
\MongoDB\Driver\Monitoring\addSubscriber(
77
new \CodeTool\Jaeger\MongoDb\JaegerMongoDbQueryTimeCollector(
88
$tracer,
9-
new \CodeTool\Jaeger\MongoDb\CommandToStringConvertor()
9+
new \CodeTool\Jaeger\MongoDb\JaegerMongoDbCommandConvertor()
1010
)
1111
);
1212
```

src/CommandToStringConvertor.php renamed to src/JaegerMongoDbCommandConvertor.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
use MongoDB\BSON\Type;
88

9-
class CommandToStringConvertor
9+
class JaegerMongoDbCommandConvertor implements JaegerMongoDbCommandConvertorInterface
1010
{
1111
/**
1212
* @var int
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
<?php
2+
3+
declare(strict_types = 1);
4+
5+
namespace CodeTool\Jaeger\MongoDb;
6+
7+
interface JaegerMongoDbCommandConvertorInterface
8+
{
9+
public function convert(object $command): string;
10+
}

src/JaegerMongoDbQueryTimeCollector.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?php
22

3-
declare(strict_types=1);
3+
declare(strict_types = 1);
44

55
namespace CodeTool\Jaeger\MongoDb;
66

@@ -30,11 +30,11 @@ class JaegerMongoDbQueryTimeCollector implements CommandSubscriber
3030
private $requestIdToSpan = [];
3131

3232
/**
33-
* @var CommandToStringConvertor
33+
* @var JaegerMongoDbCommandConvertorInterface
3434
*/
3535
private $convertor;
3636

37-
public function __construct(TracerInterface $tracer, CommandToStringConvertor $convertor)
37+
public function __construct(TracerInterface $tracer, JaegerMongoDbCommandConvertorInterface $convertor)
3838
{
3939
$this->tracer = $tracer;
4040
$this->convertor = $convertor;

test/CommandToStringConvertorTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
namespace CodeTool\Jaeger\Tests\MongoDb;
66

7-
use CodeTool\Jaeger\MongoDb\CommandToStringConvertor;
7+
use CodeTool\Jaeger\MongoDb\JaegerMongoDbCommandConvertor;
88
use MongoDB\BSON\UTCDateTime;
99
use PHPUnit\Framework\TestCase;
1010

@@ -51,7 +51,7 @@ private function array2object($array)
5151
*/
5252
public function testConvert($command, string $expected): void
5353
{
54-
$convertor = new CommandToStringConvertor();
54+
$convertor = new JaegerMongoDbCommandConvertor();
5555

5656
$data = $command;
5757
if (\is_array($command)) {

0 commit comments

Comments
 (0)