Skip to content

Commit 9a549ed

Browse files
committed
Fixed copy pasted data
1 parent 1705aa3 commit 9a549ed

File tree

2 files changed

+5
-13
lines changed

2 files changed

+5
-13
lines changed

composer.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
11
{
22
"name": "code-tool/jaeger-mongodb-collector",
3+
"description": "Jaeger mongodb time collectior",
34
"type": "library",
45
"license": "MIT",
56
"require": {
67
"php": "^7.2",
78
"ext-mongodb": "*",
8-
"code-tool/jaeger-client-php": "^2.1.4"
9+
"code-tool/jaeger-client-php": "^3"
910
},
1011
"autoload": {
1112
"psr-4": {

src/JaegerMongoDbQueryTimeCollector.php

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,10 @@
11
<?php
2-
3-
declare(strict_types = 1);
2+
declare(strict_types=1);
43

54
namespace CodeTool\Jaeger\MongoDb;
65

76
use Jaeger\Log\ErrorLog;
87
use Jaeger\Span\SpanInterface;
9-
use Jaeger\Tag\BoolTag;
108
use Jaeger\Tag\ComponentTag;
119
use Jaeger\Tag\DbInstanceTag;
1210
use Jaeger\Tag\DbStatementTag;
@@ -45,17 +43,14 @@ public function commandStarted(CommandStartedEvent $event)
4543
{
4644
/** @var MongoDB\Driver\Server $server */
4745
$server = $event->getServer();
48-
4946
$this->requestIdToSpan[$event->getRequestId()] = $this->tracer->start(
5047
sprintf('mongodb.%s', $event->getCommandName()),
5148
[
5249
new SpanKindClientTag(),
5350
new ComponentTag('php-mongodb'),
54-
5551
new DbType('mongo'),
5652
new DbInstanceTag($event->getDatabaseName()),
5753
new DbStatementTag($this->convertor->convert($event->getCommand())),
58-
5954
new PeerHostnameTag($server->getHost()),
6055
new PeerPortTag($server->getPort()),
6156
]
@@ -68,7 +63,6 @@ private function getSpanByEvent($event): ?SpanInterface
6863
// warning, should not happen!
6964
return null;
7065
}
71-
7266
$span = $this->requestIdToSpan[$event->getRequestId()];
7367
unset($this->requestIdToSpan[$event->getRequestId()]);
7468

@@ -80,19 +74,16 @@ public function commandFailed(CommandFailedEvent $event)
8074
if (null === $span = $this->getSpanByEvent($event)) {
8175
return;
8276
}
83-
8477
$span->addTag(new ErrorTag());
8578
$span->addLog(new ErrorLog($event->getError()->getMessage(), $event->getError()->getTraceAsString()));
86-
87-
$this->tracer->finish($span, $event->getDurationMicros());
79+
$span->finish($event->getDurationMicros());
8880
}
8981

9082
public function commandSucceeded(CommandSucceededEvent $event)
9183
{
9284
if (null === $span = $this->getSpanByEvent($event)) {
9385
return;
9486
}
95-
96-
$this->tracer->finish($span, $event->getDurationMicros());
87+
$span->finish($event->getDurationMicros());
9788
}
9889
}

0 commit comments

Comments
 (0)