Add type hinting

Author: joelwurtz

src/Client.php

@@ -105,7 +105,7 @@ public function sendRequest(RequestInterface $request): ResponseInterface
      *
      * @return resource Socket resource
      */
-    protected function createSocket(RequestInterface $request, $remote, $useSsl)
+    protected function createSocket(RequestInterface $request, string $remote, bool $useSsl)
     {
         $errNo = null;
         $errMsg = null;

src/RequestWriter.php

@@ -18,11 +18,10 @@ trait RequestWriter
      * Write a request to a socket.
      *
      * @param resource $socket
-     * @param int      $bufferSize
      *
      * @throws BrokenPipeException
      */
-    protected function writeRequest($socket, RequestInterface $request, $bufferSize = 8192)
+    protected function writeRequest($socket, RequestInterface $request, int $bufferSize = 8192)
     {
         if (false === $this->fwrite($socket, $this->transformRequestHeadersToString($request))) {
             throw new BrokenPipeException('Failed to send request, underlying socket not accessible, (BROKEN EPIPE)', $request);
@@ -37,11 +36,10 @@ protected function writeRequest($socket, RequestInterface $request, $bufferSize
      * Write Body of the request.
      *
      * @param resource $socket
-     * @param int      $bufferSize
      *
      * @throws BrokenPipeException
      */
-    protected function writeBody($socket, RequestInterface $request, $bufferSize = 8192)
+    protected function writeBody($socket, RequestInterface $request, int $bufferSize = 8192)
     {
         $body = $request->getBody();
 
@@ -60,11 +58,8 @@ protected function writeBody($socket, RequestInterface $request, $bufferSize = 8
 
     /**
      * Produce the header of request as a string based on a PSR Request.
-     *
-     *
-     * @return string
      */
-    protected function transformRequestHeadersToString(RequestInterface $request)
+    protected function transformRequestHeadersToString(RequestInterface $request): string
     {
         $message = vsprintf('%s %s HTTP/%s', [
             strtoupper($request->getMethod()),
@@ -87,11 +82,10 @@ protected function transformRequestHeadersToString(RequestInterface $request)
      * @see https://secure.phabricator.com/rPHU69490c53c9c2ef2002bc2dd4cecfe9a4b080b497
      *
      * @param resource $stream The stream resource
-     * @param string   $bytes  Bytes written in the stream
      *
      * @return bool|int false if pipe is broken, number of bytes written otherwise
      */
-    private function fwrite($stream, $bytes)
+    private function fwrite($stream, string $bytes)
     {
         if (!strlen($bytes)) {
             return 0;

src/ResponseReader.php

@@ -29,10 +29,8 @@ trait ResponseReader
      *
      * @throws TimeoutException    When the socket timed out
      * @throws BrokenPipeException When the response cannot be read
-     *
-     * @return ResponseInterface
      */
-    protected function readResponse(RequestInterface $request, $socket)
+    protected function readResponse(RequestInterface $request, $socket): ResponseInterface
     {
         $headers = [];
         $reason = null;
@@ -87,11 +85,9 @@ protected function readResponse(RequestInterface $request, $socket)
     /**
      * Create the stream.
      *
-     * @param $socket
-     *
-     * @return Stream
+     * @param resource $socket
      */
-    protected function createStream($socket, ResponseInterface $response)
+    protected function createStream($socket, ResponseInterface $response): Stream
     {
         $size = null;
 

src/Stream.php

@@ -48,7 +48,7 @@ class Stream implements StreamInterface
      * @param resource $socket
      * @param int      $size
      */
-    public function __construct($socket, $size = null)
+    public function __construct($socket, ?int $size = null)
     {
         $this->socket = $socket;
         $this->size = $size;