Remove vesync unused extra attributes, refine enums (home-assistant#153171)

Author: cdnninja

homeassistant/components/vesync/fan.py

@@ -156,17 +156,27 @@ def extra_state_attributes(self) -> dict[str, Any]:
         if hasattr(self.device.state, "active_time"):
             attr["active_time"] = self.device.state.active_time
 
-        if hasattr(self.device.state, "display_status"):
+        if (
+            hasattr(self.device.state, "display_status")
+            and self.device.state.display_status is not None
+        ):
             attr["display_status"] = getattr(
                 self.device.state.display_status, "value", None
             )
 
-        if hasattr(self.device.state, "child_lock"):
+        if (
+            hasattr(self.device.state, "child_lock")
+            and self.device.state.child_lock is not None
+        ):
             attr["child_lock"] = self.device.state.child_lock
 
-        if hasattr(self.device.state, "nightlight_status"):
-            attr["night_light"] = self.device.state.nightlight_status
-
+        if (
+            hasattr(self.device.state, "nightlight_status")
+            and self.device.state.nightlight_status is not None
+        ):
+            attr["night_light"] = getattr(
+                self.device.state.nightlight_status, "value", None
+            )
         if hasattr(self.device.state, "mode"):
             attr["mode"] = self.device.state.mode
 

tests/components/vesync/snapshots/test_fan.ambr

@@ -82,7 +82,6 @@
       'display_status': 'on',
       'friendly_name': 'Air Purifier 131s',
       'mode': 'sleep',
-      'night_light': None,
       'percentage': None,
       'percentage_step': 33.333333333333336,
       'preset_mode': 'sleep',
@@ -182,7 +181,7 @@
       'display_status': 'on',
       'friendly_name': 'Air Purifier 200s',
       'mode': 'manual',
-      'night_light': <DeviceStatus.OFF: 'off'>,
+      'night_light': 'off',
       'percentage': 33,
       'percentage_step': 33.333333333333336,
       'preset_mode': None,
@@ -282,7 +281,7 @@
       'display_status': 'on',
       'friendly_name': 'Air Purifier 400s',
       'mode': 'manual',
-      'night_light': <DeviceStatus.OFF: 'off'>,
+      'night_light': 'off',
       'percentage': 25,
       'percentage_step': 25.0,
       'preset_mode': None,
@@ -383,7 +382,7 @@
       'display_status': 'on',
       'friendly_name': 'Air Purifier 600s',
       'mode': 'manual',
-      'night_light': <DeviceStatus.OFF: 'off'>,
+      'night_light': 'off',
       'percentage': 25,
       'percentage_step': 25.0,
       'preset_mode': None,