Return default temp range if API responds 0 in Huum. (home-assistant#153871)

Author: vincentwolsink

homeassistant/components/huum/climate.py

@@ -18,6 +18,7 @@
 from homeassistant.exceptions import HomeAssistantError
 from homeassistant.helpers.entity_platform import AddConfigEntryEntitiesCallback
 
+from .const import CONFIG_DEFAULT_MAX_TEMP, CONFIG_DEFAULT_MIN_TEMP
 from .coordinator import HuumConfigEntry, HuumDataUpdateCoordinator
 from .entity import HuumBaseEntity
 
@@ -55,12 +56,12 @@ def __init__(self, coordinator: HuumDataUpdateCoordinator) -> None:
     @property
     def min_temp(self) -> int:
         """Return configured minimal temperature."""
-        return self.coordinator.data.sauna_config.min_temp
+        return self.coordinator.data.sauna_config.min_temp or CONFIG_DEFAULT_MIN_TEMP
 
     @property
     def max_temp(self) -> int:
         """Return configured maximum temperature."""
-        return self.coordinator.data.sauna_config.max_temp
+        return self.coordinator.data.sauna_config.max_temp or CONFIG_DEFAULT_MAX_TEMP
 
     @property
     def hvac_mode(self) -> HVACMode:

homeassistant/components/huum/const.py

@@ -9,3 +9,6 @@
 CONFIG_STEAMER = 1
 CONFIG_LIGHT = 2
 CONFIG_STEAMER_AND_LIGHT = 3
+
+CONFIG_DEFAULT_MIN_TEMP = 40
+CONFIG_DEFAULT_MAX_TEMP = 110

tests/components/huum/test_climate.py

@@ -11,6 +11,10 @@
     SERVICE_SET_TEMPERATURE,
     HVACMode,
 )
+from homeassistant.components.huum.const import (
+    CONFIG_DEFAULT_MAX_TEMP,
+    CONFIG_DEFAULT_MIN_TEMP,
+)
 from homeassistant.const import ATTR_ENTITY_ID, ATTR_TEMPERATURE, Platform
 from homeassistant.core import HomeAssistant
 from homeassistant.helpers import entity_registry as er
@@ -76,3 +80,39 @@ async def test_set_temperature(
     )
 
     mock_huum.turn_on.assert_called_once_with(60)
+
+
+async def test_temperature_range(
+    hass: HomeAssistant,
+    mock_huum: AsyncMock,
+    mock_config_entry: MockConfigEntry,
+) -> None:
+    """Test the temperature range."""
+    await setup_with_selected_platforms(hass, mock_config_entry, [Platform.CLIMATE])
+
+    # API response.
+    state = hass.states.get(ENTITY_ID)
+    assert state.attributes["min_temp"] == 40
+    assert state.attributes["max_temp"] == 110
+
+    # Empty/unconfigured API response should return default values.
+    mock_huum.sauna_config.min_temp = 0
+    mock_huum.sauna_config.max_temp = 0
+
+    await mock_config_entry.runtime_data.async_refresh()
+    await hass.async_block_till_done()
+
+    state = hass.states.get(ENTITY_ID)
+    assert state.attributes["min_temp"] == CONFIG_DEFAULT_MIN_TEMP
+    assert state.attributes["max_temp"] == CONFIG_DEFAULT_MAX_TEMP
+
+    # Custom configured API response.
+    mock_huum.sauna_config.min_temp = 50
+    mock_huum.sauna_config.max_temp = 80
+
+    await mock_config_entry.runtime_data.async_refresh()
+    await hass.async_block_till_done()
+
+    state = hass.states.get(ENTITY_ID)
+    assert state.attributes["min_temp"] == 50
+    assert state.attributes["max_temp"] == 80