Skip to content

Commit 214731e

Browse files
authored
Component asuswrt: Type check is redundant for this value (home-assistant#154535)
1 parent c4b09c9 commit 214731e

File tree

2 files changed

+6
-12
lines changed

2 files changed

+6
-12
lines changed

homeassistant/components/asuswrt/bridge.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,8 +111,6 @@ async def _wrapper(
111111

112112
if isinstance(data, dict):
113113
return dict(zip(keys, list(data.values()), strict=False))
114-
if not isinstance(data, (list, tuple)):
115-
raise UpdateFailed("Received invalid data type")
116114
return dict(zip(keys, data, strict=False))
117115

118116
return _wrapper

tests/components/asuswrt/test_sensor.py

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -616,12 +616,10 @@ async def test_decorator_errors(
616616
config_entry.add_to_hass(hass)
617617

618618
mock_available_temps[1] = True
619-
connect_legacy.return_value.async_get_bytes_total.return_value = "bad_response"
620-
connect_legacy.return_value.async_get_current_transfer_rates.return_value = (
621-
"bad_response"
622-
)
623-
connect_legacy.return_value.async_get_temperature.return_value = "bad_response"
624-
connect_legacy.return_value.async_get_loadavg.return_value = "bad_response"
619+
connect_legacy.return_value.async_get_bytes_total.return_value = None
620+
connect_legacy.return_value.async_get_current_transfer_rates.return_value = None
621+
connect_legacy.return_value.async_get_temperature.return_value = None
622+
connect_legacy.return_value.async_get_loadavg.return_value = None
625623

626624
# initial devices setup
627625
assert await hass.config_entries.async_setup(config_entry.entry_id)
@@ -631,7 +629,5 @@ async def test_decorator_errors(
631629
await hass.async_block_till_done()
632630

633631
for sensor_name in sensors:
634-
assert (
635-
hass.states.get(f"{sensor_prefix}_{slugify(sensor_name)}").state
636-
== STATE_UNAVAILABLE
637-
)
632+
sensor = hass.states.get(f"{sensor_prefix}_{slugify(sensor_name)}")
633+
assert sensor and sensor.state == STATE_UNAVAILABLE

0 commit comments

Comments
 (0)