Fix Shelly RPC cover update when the device is not initialized (home-assistant#154159)

Author: thecode

homeassistant/components/shelly/cover.py

@@ -226,6 +226,8 @@ async def update_position(self) -> None:
     def _update_callback(self) -> None:
         """Handle device update. Use a task when opening/closing is in progress."""
         super()._update_callback()
+        if not self.coordinator.device.initialized:
+            return
         if self.is_closing or self.is_opening:
             self.launch_update_task()
 

tests/components/shelly/test_cover.py

@@ -23,7 +23,7 @@
     CoverState,
 )
 from homeassistant.components.shelly.const import RPC_COVER_UPDATE_TIME_SEC
-from homeassistant.const import ATTR_ENTITY_ID
+from homeassistant.const import ATTR_ENTITY_ID, STATE_UNAVAILABLE
 from homeassistant.core import HomeAssistant
 from homeassistant.helpers.entity_registry import EntityRegistry
 
@@ -417,3 +417,20 @@ async def test_update_position_no_movement(
     assert (state := hass.states.get(entity_id))
     assert state.state == CoverState.OPEN
     assert state.attributes[ATTR_CURRENT_POSITION] == 100
+
+
+async def test_rpc_not_initialized_update(
+    hass: HomeAssistant, mock_rpc_device: Mock, monkeypatch: pytest.MonkeyPatch
+) -> None:
+    """Test update not called when device is not initialized."""
+    entity_id = "cover.test_name_test_cover_0"
+    await init_integration(hass, 2)
+
+    assert (state := hass.states.get(entity_id))
+    assert state.state == CoverState.OPEN
+
+    monkeypatch.setattr(mock_rpc_device, "initialized", False)
+    mock_rpc_device.mock_update()
+
+    assert (state := hass.states.get(entity_id))
+    assert state.state == STATE_UNAVAILABLE