Move Shelly binary sensor translation logic to base class (home-assistant#157127)

Signed-off-by: David Rapan <[email protected]>

Author: davidrapan

homeassistant/components/shelly/binary_sensor.py

@@ -38,8 +38,6 @@
     async_remove_orphaned_entities,
     get_blu_trv_device_info,
     get_device_entry_gen,
-    get_entity_translation_attributes,
-    get_rpc_channel_name,
     get_rpc_custom_name,
     get_rpc_key,
     is_block_momentary_input,
@@ -83,27 +81,14 @@ def __init__(
         super().__init__(coordinator, key, attribute, description)
 
         if not description.role:
-            if description.key == "input":
-                if custom_name := get_rpc_custom_name(coordinator.device, key):
-                    self._attr_name = custom_name
-                else:
-                    _, _, component_id = get_rpc_key(key)
-                    self._attr_translation_placeholders = {"input_number": component_id}
-                    self._attr_translation_key = "input_with_number"
+            if description.key != "input":
+                self.configure_translation_attributes()
+            elif custom_name := get_rpc_custom_name(coordinator.device, key):
+                self._attr_name = custom_name
             else:
-                translation_placeholders, translation_key = (
-                    get_entity_translation_attributes(
-                        get_rpc_channel_name(coordinator.device, key),
-                        description.translation_key,
-                        description.device_class,
-                        self._default_to_device_class_name(),
-                    )
-                )
-
-                if translation_placeholders:
-                    self._attr_translation_placeholders = translation_placeholders
-                    if translation_key:
-                        self._attr_translation_key = translation_key
+                _, _, component_id = get_rpc_key(key)
+                self._attr_translation_placeholders = {"input_number": component_id}
+                self._attr_translation_key = "input_with_number"
 
     @property
     def is_on(self) -> bool:
@@ -508,19 +493,7 @@ def __init__(
         super().__init__(coordinator, key, attribute, description, entry)
 
         if coordinator.device.initialized:
-            translation_placeholders, translation_key = (
-                get_entity_translation_attributes(
-                    get_rpc_channel_name(coordinator.device, key),
-                    description.translation_key,
-                    description.device_class,
-                    self._default_to_device_class_name(),
-                )
-            )
-
-            if translation_placeholders:
-                self._attr_translation_placeholders = translation_placeholders
-                if translation_key:
-                    self._attr_translation_key = translation_key
+            self.configure_translation_attributes()
 
     async def async_added_to_hass(self) -> None:
         """Handle entity which will be added."""

homeassistant/components/shelly/entity.py

@@ -25,6 +25,7 @@
 from .utils import (
     async_remove_shelly_entity,
     get_block_device_info,
+    get_entity_translation_attributes,
     get_rpc_channel_name,
     get_rpc_device_info,
     get_rpc_key,
@@ -595,6 +596,20 @@ def available(self) -> bool:
 
         return self.entity_description.available(self.sub_status)
 
+    def configure_translation_attributes(self) -> None:
+        """Configure translation attributes."""
+        translation_placeholders, translation_key = get_entity_translation_attributes(
+            get_rpc_channel_name(self.coordinator.device, self.key),
+            self.entity_description.translation_key,
+            self.entity_description.device_class,
+            self._default_to_device_class_name(),
+        )
+
+        if translation_placeholders:
+            self._attr_translation_placeholders = translation_placeholders
+            if translation_key:
+                self._attr_translation_key = translation_key
+
 
 class ShellySleepingBlockAttributeEntity(ShellyBlockAttributeEntity):
     """Represent a shelly sleeping block attribute entity."""