Miele refrigerators cause index out of range errors when offline (home-assistant#151299)

Author: aturri

homeassistant/components/miele/climate.py

@@ -8,7 +8,7 @@
 from typing import Any, Final, cast
 
 import aiohttp
-from pymiele import MieleDevice
+from pymiele import MieleDevice, MieleTemperature
 
 from homeassistant.components.climate import (
     ClimateEntity,
@@ -31,6 +31,15 @@
 _LOGGER = logging.getLogger(__name__)
 
 
+def _get_temperature_value(
+    temperatures: list[MieleTemperature], index: int
+) -> float | None:
+    """Return the temperature value for the given index."""
+    if len(temperatures) > index:
+        return cast(int, temperatures[index].temperature) / 100.0
+    return None
+
+
 @dataclass(frozen=True, kw_only=True)
 class MieleClimateDescription(ClimateEntityDescription):
     """Class describing Miele climate entities."""
@@ -62,11 +71,10 @@ class MieleClimateDefinition:
         description=MieleClimateDescription(
             key="thermostat",
             value_fn=(
-                lambda value: cast(int, value.state_temperatures[0].temperature) / 100.0
+                lambda value: _get_temperature_value(value.state_temperatures, 0)
             ),
             target_fn=(
-                lambda value: cast(int, value.state_target_temperature[0].temperature)
-                / 100.0
+                lambda value: _get_temperature_value(value.state_target_temperature, 0)
             ),
             zone=1,
         ),
@@ -84,11 +92,10 @@ class MieleClimateDefinition:
         description=MieleClimateDescription(
             key="thermostat2",
             value_fn=(
-                lambda value: cast(int, value.state_temperatures[1].temperature) / 100.0
+                lambda value: _get_temperature_value(value.state_temperatures, 1)
             ),
             target_fn=(
-                lambda value: cast(int, value.state_target_temperature[1].temperature)
-                / 100.0
+                lambda value: _get_temperature_value(value.state_target_temperature, 1)
             ),
             translation_key="zone_2",
             zone=2,
@@ -107,11 +114,10 @@ class MieleClimateDefinition:
         description=MieleClimateDescription(
             key="thermostat3",
             value_fn=(
-                lambda value: cast(int, value.state_temperatures[2].temperature) / 100.0
+                lambda value: _get_temperature_value(value.state_temperatures, 2)
             ),
             target_fn=(
-                lambda value: cast(int, value.state_target_temperature[2].temperature)
-                / 100.0
+                lambda value: _get_temperature_value(value.state_target_temperature, 2)
             ),
             translation_key="zone_3",
             zone=3,
@@ -219,6 +225,8 @@ def target_temperature(self) -> float | None:
     @property
     def max_temp(self) -> float:
         """Return the maximum target temperature."""
+        if len(self.action.target_temperature) < self.entity_description.zone:
+            return super().max_temp
         return cast(
             float,
             self.action.target_temperature[self.entity_description.zone - 1].max,
@@ -227,6 +235,8 @@ def max_temp(self) -> float:
     @property
     def min_temp(self) -> float:
         """Return the minimum target temperature."""
+        if len(self.action.target_temperature) < self.entity_description.zone:
+            return super().min_temp
         return cast(
             float,
             self.action.target_temperature[self.entity_description.zone - 1].min,

tests/components/miele/fixtures/action_offline.json

@@ -0,0 +1,15 @@
+{
+  "processAction": [],
+  "light": [],
+  "ambientLight": [],
+  "startTime": [],
+  "ventilationStep": [],
+  "programId": [],
+  "targetTemperature": [],
+  "deviceName": false,
+  "powerOn": false,
+  "powerOff": false,
+  "colors": [],
+  "modes": [],
+  "runOnTime": []
+}

tests/components/miele/fixtures/fridge_freezer.json

@@ -110,5 +110,82 @@
       "ecoFeedback": null,
       "batteryLevel": null
     }
+  },
+  "DummyAppliance_Fridge_Freezer_Offline": {
+    "ident": {
+      "type": {
+        "key_localized": "Device type",
+        "value_raw": 21,
+        "value_localized": "Fridge freezer"
+      },
+      "deviceName": "",
+      "protocolVersion": 203,
+      "deviceIdentLabel": {
+        "fabNumber": "**REDACTED**",
+        "fabIndex": "00",
+        "techType": "KFN 7734 C",
+        "matNumber": "12336150",
+        "swids": []
+      },
+      "xkmIdentLabel": {
+        "techType": "EK037LHBM",
+        "releaseVersion": "32.33"
+      }
+    },
+    "state": {
+      "ProgramID": {
+        "value_raw": null,
+        "value_localized": "",
+        "key_localized": "Program name"
+      },
+      "status": {
+        "value_raw": 255,
+        "value_localized": "Not connected",
+        "key_localized": "status"
+      },
+      "programType": {
+        "value_raw": null,
+        "value_localized": "",
+        "key_localized": "Program type"
+      },
+      "programPhase": {
+        "value_raw": null,
+        "value_localized": "",
+        "key_localized": "Program phase"
+      },
+      "remainingTime": [],
+      "startTime": [],
+      "targetTemperature": [],
+      "coreTargetTemperature": [],
+      "temperature": [],
+      "coreTemperature": [],
+      "remoteEnable": {
+        "fullRemoteControl": false,
+        "smartGrid": false,
+        "mobileStart": null
+      },
+      "ambientLight": null,
+      "light": null,
+      "elapsedTime": [],
+      "spinningSpeed": {
+        "unit": "rpm",
+        "value_raw": null,
+        "value_localized": null,
+        "key_localized": "Spin speed"
+      },
+      "dryingStep": {
+        "value_raw": null,
+        "value_localized": "",
+        "key_localized": "Drying level"
+      },
+      "ventilationStep": {
+        "value_raw": null,
+        "value_localized": "",
+        "key_localized": "Fan level"
+      },
+      "plateStep": [],
+      "ecoFeedback": null,
+      "batteryLevel": null
+    }
   }
 }