Make Speed optional for GoToPreset ONVIF command (home-assistant#149636)

Co-authored-by: Abílio Costa <[email protected]>

Author: carlos-sarmiento

homeassistant/components/onvif/camera.py

@@ -70,7 +70,7 @@ async def async_setup_entry(
             vol.Optional(ATTR_TILT): vol.In([DIR_UP, DIR_DOWN]),
             vol.Optional(ATTR_ZOOM): vol.In([ZOOM_OUT, ZOOM_IN]),
             vol.Optional(ATTR_DISTANCE, default=0.1): cv.small_float,
-            vol.Optional(ATTR_SPEED, default=0.5): cv.small_float,
+            vol.Optional(ATTR_SPEED): cv.small_float,
             vol.Optional(ATTR_MOVE_MODE, default=RELATIVE_MOVE): vol.In(
                 [
                     CONTINUOUS_MOVE,
@@ -210,10 +210,10 @@ async def _async_get_stream_uri(self) -> str:
     async def async_perform_ptz(
         self,
         distance,
-        speed,
         move_mode,
         continuous_duration,
         preset,
+        speed=None,
         pan=None,
         tilt=None,
         zoom=None,

homeassistant/components/onvif/device.py

@@ -602,10 +602,11 @@ async def async_perform_ptz(
                     return
 
                 req.PresetToken = preset_val
-                req.Speed = {
-                    "PanTilt": {"x": speed_val, "y": speed_val},
-                    "Zoom": {"x": speed_val},
-                }
+                if speed_val is not None:
+                    req.Speed = {
+                        "PanTilt": {"x": speed_val, "y": speed_val},
+                        "Zoom": {"x": speed_val},
+                    }
                 await ptz_service.GotoPreset(req)
             elif move_mode == STOP_MOVE:
                 await ptz_service.Stop(req)

homeassistant/components/onvif/services.yaml

@@ -30,7 +30,6 @@ ptz:
           max: 1
           step: 0.01
     speed:
-      default: 0.5
       selector:
         number:
           min: 0