Improve mobile_app device_tracker tests (home-assistant#154584)

Co-authored-by: Martin Hjelmare <[email protected]>

Author: emontnemery

tests/components/mobile_app/test_device_tracker.py

@@ -4,31 +4,126 @@
 from typing import Any
 
 from aiohttp.test_utils import TestClient
+import pytest
 
+from homeassistant.components import zone
 from homeassistant.const import Platform
 from homeassistant.core import HomeAssistant
+from homeassistant.setup import async_setup_component
 
 
+@pytest.fixture
+async def setup_zone(hass: HomeAssistant) -> None:
+    """Set up a zone for testing."""
+    await async_setup_component(
+        hass,
+        zone.DOMAIN,
+        {
+            "zone": [
+                {
+                    "name": "Home",
+                    "latitude": 10.0,
+                    "longitude": 20.0,
+                    "radius": 250,
+                },
+                {
+                    "name": "Office",
+                    "latitude": 20.0,
+                    "longitude": 30.0,
+                    "radius": 250,
+                },
+                {
+                    "name": "School",
+                    "latitude": 30.0,
+                    "longitude": 40.0,
+                    "radius": 250,
+                },
+            ]
+        },
+    )
+    await hass.async_block_till_done()
+
+
+@pytest.mark.usefixtures("setup_zone")
+@pytest.mark.parametrize(
+    ("extra_webhook_data", "expected_attributes", "expected_state"),
+    [
+        # Send coordinates + location_name: Location name has precedence
+        (
+            {"gps": [10, 20], "location_name": "home"},
+            {"latitude": 10, "longitude": 20, "gps_accuracy": 30},
+            "home",
+        ),
+        (
+            {"gps": [20, 30], "location_name": "office"},
+            {"latitude": 20, "longitude": 30, "gps_accuracy": 30},
+            "office",
+        ),
+        (
+            {"gps": [30, 40], "location_name": "school"},
+            {"latitude": 30, "longitude": 40, "gps_accuracy": 30},
+            "school",
+        ),
+        # Send wrong coordinates + location_name: Location name has precedence
+        (
+            {"gps": [10, 10], "location_name": "home"},
+            {"latitude": 10, "longitude": 10, "gps_accuracy": 30},
+            "home",
+        ),
+        (
+            {"gps": [10, 10], "location_name": "office"},
+            {"latitude": 10, "longitude": 10, "gps_accuracy": 30},
+            "office",
+        ),
+        (
+            {"gps": [10, 10], "location_name": "school"},
+            {"latitude": 10, "longitude": 10, "gps_accuracy": 30},
+            "school",
+        ),
+        # Send location_name only
+        ({"location_name": "home"}, {}, "home"),
+        ({"location_name": "office"}, {}, "office"),
+        ({"location_name": "school"}, {}, "school"),
+        # Send coordinates only - location is determined by coordinates
+        (
+            {"gps": [10, 20]},
+            {"latitude": 10, "longitude": 20, "gps_accuracy": 30},
+            "home",
+        ),
+        (
+            {"gps": [20, 30]},
+            {"latitude": 20, "longitude": 30, "gps_accuracy": 30},
+            "Office",
+        ),
+        (
+            {"gps": [30, 40]},
+            {"latitude": 30, "longitude": 40, "gps_accuracy": 30},
+            "School",
+        ),
+    ],
+)
 async def test_sending_location(
     hass: HomeAssistant,
     create_registrations: tuple[dict[str, Any], dict[str, Any]],
     webhook_client: TestClient,
+    extra_webhook_data: dict[str, Any],
+    expected_attributes: dict[str, Any],
+    expected_state: str,
 ) -> None:
     """Test sending a location via a webhook."""
     resp = await webhook_client.post(
         f"/api/webhook/{create_registrations[1]['webhook_id']}",
         json={
             "type": "update_location",
             "data": {
-                "gps": [10, 20],
                 "gps_accuracy": 30,
                 "battery": 40,
                 "altitude": 50,
                 "course": 60,
                 "speed": 70,
                 "vertical_accuracy": 80,
-                "location_name": "bar",
-            },
+            }
+            | extra_webhook_data,
         },
     )
 
@@ -37,16 +132,20 @@ async def test_sending_location(
     state = hass.states.get("device_tracker.test_1_2")
     assert state is not None
     assert state.name == "Test 1"
-    assert state.state == "bar"
-    assert state.attributes["source_type"] == "gps"
-    assert state.attributes["latitude"] == 10
-    assert state.attributes["longitude"] == 20
-    assert state.attributes["gps_accuracy"] == 30
-    assert state.attributes["battery_level"] == 40
-    assert state.attributes["altitude"] == 50
-    assert state.attributes["course"] == 60
-    assert state.attributes["speed"] == 70
-    assert state.attributes["vertical_accuracy"] == 80
+    assert state.state == expected_state
+    assert (
+        state.attributes
+        == {
+            "friendly_name": "Test 1",
+            "source_type": "gps",
+            "battery_level": 40,
+            "altitude": 50.0,
+            "course": 60,
+            "speed": 70,
+            "vertical_accuracy": 80,
+        }
+        | expected_attributes
+    )
 
     resp = await webhook_client.post(
         f"/api/webhook/{create_registrations[1]['webhook_id']}",
@@ -70,15 +169,18 @@ async def test_sending_location(
     state = hass.states.get("device_tracker.test_1_2")
     assert state is not None
     assert state.state == "not_home"
-    assert state.attributes["source_type"] == "gps"
-    assert state.attributes["latitude"] == 1
-    assert state.attributes["longitude"] == 2
-    assert state.attributes["gps_accuracy"] == 3
-    assert state.attributes["battery_level"] == 4
-    assert state.attributes["altitude"] == 5
-    assert state.attributes["course"] == 6
-    assert state.attributes["speed"] == 7
-    assert state.attributes["vertical_accuracy"] == 8
+    assert state.attributes == {
+        "friendly_name": "Test 1",
+        "source_type": "gps",
+        "latitude": 1.0,
+        "longitude": 2.0,
+        "gps_accuracy": 3,
+        "battery_level": 4,
+        "altitude": 5.0,
+        "course": 6,
+        "speed": 7,
+        "vertical_accuracy": 8,
+    }
 
 
 async def test_restoring_location(