Record last_reported for KNX sensor entitiy states (home-assistant#154169)

Author: farmio

homeassistant/components/knx/sensor.py

@@ -136,7 +136,7 @@ def _create_sensor(xknx: XKNX, config: ConfigType) -> XknxSensor:
         name=config[CONF_NAME],
         group_address_state=config[SensorSchema.CONF_STATE_ADDRESS],
         sync_state=config[SensorSchema.CONF_SYNC_STATE],
-        always_callback=config[SensorSchema.CONF_ALWAYS_CALLBACK],
+        always_callback=True,
         value_type=config[CONF_TYPE],
     )
 
@@ -159,7 +159,7 @@ def __init__(self, knx_module: KNXModule, config: ConfigType) -> None:
                 SensorDeviceClass, self._device.ha_device_class()
             )
 
-        self._attr_force_update = self._device.always_callback
+        self._attr_force_update = config[SensorSchema.CONF_ALWAYS_CALLBACK]
         self._attr_entity_category = config.get(CONF_ENTITY_CATEGORY)
         self._attr_unique_id = str(self._device.sensor_value.group_address_state)
         self._attr_native_unit_of_measurement = self._device.unit_of_measurement()

tests/components/knx/test_sensor.py

@@ -1,13 +1,15 @@
 """Test KNX sensor."""
 
+from freezegun.api import FrozenDateTimeFactory
+
 from homeassistant.components.knx.const import CONF_STATE_ADDRESS, CONF_SYNC_STATE
 from homeassistant.components.knx.schema import SensorSchema
 from homeassistant.const import CONF_NAME, CONF_TYPE, STATE_UNKNOWN
 from homeassistant.core import HomeAssistant
 
 from .conftest import KNXTestKit
 
-from tests.common import async_capture_events
+from tests.common import async_capture_events, async_fire_time_changed
 
 
 async def test_sensor(hass: HomeAssistant, knx: KNXTestKit) -> None:
@@ -41,6 +43,41 @@ async def test_sensor(hass: HomeAssistant, knx: KNXTestKit) -> None:
     await knx.assert_no_telegram()
 
 
+async def test_last_reported(
+    hass: HomeAssistant,
+    knx: KNXTestKit,
+    freezer: FrozenDateTimeFactory,
+) -> None:
+    """Test KNX sensor with last_reported."""
+
+    await knx.setup_integration(
+        {
+            SensorSchema.PLATFORM: [
+                {
+                    CONF_NAME: "test",
+                    CONF_STATE_ADDRESS: "1/1/1",
+                    CONF_SYNC_STATE: False,
+                    CONF_TYPE: "percentU8",
+                },
+            ]
+        }
+    )
+    events = async_capture_events(hass, "state_changed")
+
+    # receive initial telegram
+    await knx.receive_write("1/1/1", (0x42,))
+    first_reported = hass.states.get("sensor.test").last_reported
+    assert len(events) == 1
+
+    # receive second telegram with identical payload
+    freezer.tick(1)
+    async_fire_time_changed(hass)
+    await knx.receive_write("1/1/1", (0x42,))
+
+    assert first_reported != hass.states.get("sensor.test").last_reported
+    assert len(events) == 1, events  # last_reported shall not fire state_changed
+
+
 async def test_always_callback(hass: HomeAssistant, knx: KNXTestKit) -> None:
     """Test KNX sensor with always_callback."""