Fix broken invalid_config tests (home-assistant#148965)

Author: karwosts

tests/components/counter/test_init.py

@@ -73,12 +73,14 @@ async def _storage(items=None, config=None):
     return _storage
 
 
-async def test_config(hass: HomeAssistant) -> None:
+@pytest.mark.parametrize(
+    "invalid_config",
+    [None, 1, {"name with space": None}],
+)
+async def test_config(hass: HomeAssistant, invalid_config) -> None:
     """Test config."""
-    invalid_configs = [None, 1, {}, {"name with space": None}]
 
-    for cfg in invalid_configs:
-        assert not await async_setup_component(hass, DOMAIN, {DOMAIN: cfg})
+    assert not await async_setup_component(hass, DOMAIN, {DOMAIN: invalid_config})
 
 
 async def test_config_options(hass: HomeAssistant) -> None:

tests/components/input_boolean/test_init.py

@@ -54,12 +54,14 @@ async def _storage(items=None, config=None):
     return _storage
 
 
-async def test_config(hass: HomeAssistant) -> None:
+@pytest.mark.parametrize(
+    "invalid_config",
+    [None, 1, {"name with space": None}],
+)
+async def test_config(hass: HomeAssistant, invalid_config) -> None:
     """Test config."""
-    invalid_configs = [None, 1, {}, {"name with space": None}]
 
-    for cfg in invalid_configs:
-        assert not await async_setup_component(hass, DOMAIN, {DOMAIN: cfg})
+    assert not await async_setup_component(hass, DOMAIN, {DOMAIN: invalid_config})
 
 
 async def test_methods(hass: HomeAssistant) -> None:

tests/components/input_button/test_init.py

@@ -47,12 +47,14 @@ async def _storage(items=None, config=None):
     return _storage
 
 
-async def test_config(hass: HomeAssistant) -> None:
+@pytest.mark.parametrize(
+    "invalid_config",
+    [None, 1, {"name with space": None}],
+)
+async def test_config(hass: HomeAssistant, invalid_config) -> None:
     """Test config."""
-    invalid_configs = [None, 1, {}, {"name with space": None}]
 
-    for cfg in invalid_configs:
-        assert not await async_setup_component(hass, DOMAIN, {DOMAIN: cfg})
+    assert not await async_setup_component(hass, DOMAIN, {DOMAIN: invalid_config})
 
 
 async def test_config_options(hass: HomeAssistant) -> None:

tests/components/input_number/test_init.py

@@ -98,16 +98,19 @@ async def decrement(hass: HomeAssistant, entity_id: str) -> None:
     )
 
 
-async def test_config(hass: HomeAssistant) -> None:
-    """Test config."""
-    invalid_configs = [
+@pytest.mark.parametrize(
+    "invalid_config",
+    [
         None,
-        {},
         {"name with space": None},
         {"test_1": {"min": 50, "max": 50}},
-    ]
-    for cfg in invalid_configs:
-        assert not await async_setup_component(hass, DOMAIN, {DOMAIN: cfg})
+        {"test_1": {"min": 0, "max": 10, "initial": 11}},
+    ],
+)
+async def test_config(hass: HomeAssistant, invalid_config) -> None:
+    """Test config."""
+
+    assert not await async_setup_component(hass, DOMAIN, {DOMAIN: invalid_config})
 
 
 async def test_set_value(hass: HomeAssistant, caplog: pytest.LogCaptureFixture) -> None:

tests/components/input_select/test_init.py

@@ -70,17 +70,18 @@ async def _storage(items=None, config=None, minor_version=STORAGE_VERSION_MINOR)
     return _storage
 
 
-async def test_config(hass: HomeAssistant) -> None:
-    """Test config."""
-    invalid_configs = [
+@pytest.mark.parametrize(
+    "invalid_config",
+    [
         None,
-        {},
         {"name with space": None},
         {"bad_initial": {"options": [1, 2], "initial": 3}},
-    ]
+    ],
+)
+async def test_config(hass: HomeAssistant, invalid_config) -> None:
+    """Test config."""
 
-    for cfg in invalid_configs:
-        assert not await async_setup_component(hass, DOMAIN, {DOMAIN: cfg})
+    assert not await async_setup_component(hass, DOMAIN, {DOMAIN: invalid_config})
 
 
 async def test_select_option(hass: HomeAssistant) -> None:

tests/components/schedule/test_init.py

@@ -131,16 +131,11 @@ async def _schedule_setup(
     return _schedule_setup
 
 
-async def test_invalid_config(hass: HomeAssistant) -> None:
+@pytest.mark.parametrize("invalid_config", [None, {"name with space": None}])
+async def test_invalid_config(hass: HomeAssistant, invalid_config) -> None:
     """Test invalid configs."""
-    invalid_configs = [
-        None,
-        {},
-        {"name with space": None},
-    ]
 
-    for cfg in invalid_configs:
-        assert not await async_setup_component(hass, DOMAIN, {DOMAIN: cfg})
+    assert not await async_setup_component(hass, DOMAIN, {DOMAIN: invalid_config})
 
 
 @pytest.mark.parametrize(

tests/components/timer/test_init.py

@@ -92,12 +92,11 @@ async def _storage(items=None, config=None):
     return _storage
 
 
-async def test_config(hass: HomeAssistant) -> None:
+@pytest.mark.parametrize("invalid_config", [None, 1, {"name with space": None}])
+async def test_config(hass: HomeAssistant, invalid_config) -> None:
     """Test config."""
-    invalid_configs = [None, 1, {}, {"name with space": None}]
 
-    for cfg in invalid_configs:
-        assert not await async_setup_component(hass, DOMAIN, {DOMAIN: cfg})
+    assert not await async_setup_component(hass, DOMAIN, {DOMAIN: invalid_config})
 
 
 async def test_config_options(hass: HomeAssistant) -> None: