Skip to content

Commit 67a0d6a

Browse files
authored
Mock arguments to ClientResponseError() in miele tests (home-assistant#156676)
1 parent abb52bc commit 67a0d6a

File tree

8 files changed

+18
-18
lines changed

8 files changed

+18
-18
lines changed

tests/components/miele/test_button.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
"""Tests for Miele button module."""
22

3-
from unittest.mock import MagicMock
3+
from unittest.mock import MagicMock, Mock
44

55
from aiohttp import ClientResponseError
66
import pytest
@@ -70,7 +70,7 @@ async def test_api_failure(
7070
setup_platform: MockConfigEntry,
7171
) -> None:
7272
"""Test handling of exception from API."""
73-
mock_miele_client.send_action.side_effect = ClientResponseError("test", "Test")
73+
mock_miele_client.send_action.side_effect = ClientResponseError(Mock(), Mock())
7474

7575
with pytest.raises(
7676
HomeAssistantError, match=f"Failed to set state for {ENTITY_ID}"

tests/components/miele/test_climate.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
"""Tests for miele climate module."""
22

3-
from unittest.mock import MagicMock
3+
from unittest.mock import MagicMock, Mock
44

55
from aiohttp import ClientResponseError
66
import pytest
@@ -108,7 +108,7 @@ async def test_api_failure(
108108
) -> None:
109109
"""Test handling of exception from API."""
110110
mock_miele_client.set_target_temperature.side_effect = ClientResponseError(
111-
"test", "Test"
111+
Mock(), Mock()
112112
)
113113

114114
with pytest.raises(

tests/components/miele/test_fan.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
"""Tests for miele fan module."""
22

33
from typing import Any
4-
from unittest.mock import MagicMock
4+
from unittest.mock import MagicMock, Mock
55

66
from aiohttp import ClientResponseError
77
import pytest
@@ -141,7 +141,7 @@ async def test_api_failure(
141141
service: str,
142142
) -> None:
143143
"""Test handling of exception from API."""
144-
mock_miele_client.send_action.side_effect = ClientResponseError("test", "Test")
144+
mock_miele_client.send_action.side_effect = ClientResponseError(Mock(), Mock())
145145

146146
with pytest.raises(HomeAssistantError):
147147
await hass.services.async_call(
@@ -156,7 +156,7 @@ async def test_set_percentage(
156156
setup_platform: None,
157157
) -> None:
158158
"""Test handling of exception at set_percentage."""
159-
mock_miele_client.send_action.side_effect = ClientResponseError("test", "Test")
159+
mock_miele_client.send_action.side_effect = ClientResponseError(Mock(), Mock())
160160

161161
with pytest.raises(
162162
HomeAssistantError, match=f"Failed to set state for {ENTITY_ID}"

tests/components/miele/test_init.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
from datetime import timedelta
44
import http
55
import time
6-
from unittest.mock import MagicMock, patch
6+
from unittest.mock import MagicMock, Mock, patch
77

88
from aiohttp import ClientConnectionError, ClientResponseError
99
from freezegun.api import FrozenDateTimeFactory
@@ -215,7 +215,7 @@ async def test_setup_all_platforms(
215215
@pytest.mark.parametrize(
216216
"side_effect",
217217
[
218-
ClientResponseError("test", "Test"),
218+
ClientResponseError(Mock(), Mock()),
219219
TimeoutError,
220220
],
221221
ids=[

tests/components/miele/test_light.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
"""Tests for miele light module."""
22

3-
from unittest.mock import MagicMock
3+
from unittest.mock import MagicMock, Mock
44

55
from aiohttp import ClientResponseError
66
import pytest
@@ -84,7 +84,7 @@ async def test_api_failure(
8484
service: str,
8585
) -> None:
8686
"""Test handling of exception from API."""
87-
mock_miele_client.send_action.side_effect = ClientResponseError("test", "Test")
87+
mock_miele_client.send_action.side_effect = ClientResponseError(Mock(), Mock())
8888

8989
with pytest.raises(
9090
HomeAssistantError, match=f"Failed to set state for {ENTITY_ID}"

tests/components/miele/test_services.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
"""Tests the services provided by the miele integration."""
22

33
from datetime import timedelta
4-
from unittest.mock import MagicMock
4+
from unittest.mock import MagicMock, Mock
55

66
from aiohttp import ClientResponseError
77
import pytest
@@ -138,7 +138,7 @@ async def test_service_api_errors(
138138
device = device_registry.async_get_device(identifiers={(DOMAIN, TEST_APPLIANCE)})
139139

140140
# Test http error
141-
mock_miele_client.set_program.side_effect = ClientResponseError("TestInfo", "test")
141+
mock_miele_client.set_program.side_effect = ClientResponseError(Mock(), Mock())
142142
with pytest.raises(HomeAssistantError, match=error):
143143
await hass.services.async_call(
144144
DOMAIN,
@@ -162,7 +162,7 @@ async def test_get_service_api_errors(
162162
device = device_registry.async_get_device(identifiers={(DOMAIN, TEST_APPLIANCE)})
163163

164164
# Test http error
165-
mock_miele_client.get_programs.side_effect = ClientResponseError("TestInfo", "test")
165+
mock_miele_client.get_programs.side_effect = ClientResponseError(Mock(), Mock())
166166
with pytest.raises(HomeAssistantError, match="'Get programs' action failed"):
167167
await hass.services.async_call(
168168
DOMAIN,

tests/components/miele/test_switch.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
"""Tests for miele switch module."""
22

3-
from unittest.mock import MagicMock
3+
from unittest.mock import MagicMock, Mock
44

55
from aiohttp import ClientResponseError
66
import pytest
@@ -99,7 +99,7 @@ async def test_api_failure(
9999
entity: str,
100100
) -> None:
101101
"""Test handling of exception from API."""
102-
mock_miele_client.send_action.side_effect = ClientResponseError("test", "Test")
102+
mock_miele_client.send_action.side_effect = ClientResponseError(Mock(), Mock())
103103

104104
with pytest.raises(HomeAssistantError, match=f"Failed to set state for {entity}"):
105105
await hass.services.async_call(

tests/components/miele/test_vacuum.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
"""Tests for miele vacuum module."""
22

3-
from unittest.mock import MagicMock
3+
from unittest.mock import MagicMock, Mock
44

55
from aiohttp import ClientResponseError
66
from pymiele import MieleDevices
@@ -142,7 +142,7 @@ async def test_api_failure(
142142
service: str,
143143
) -> None:
144144
"""Test handling of exception from API."""
145-
mock_miele_client.send_action.side_effect = ClientResponseError("test", "Test")
145+
mock_miele_client.send_action.side_effect = ClientResponseError(Mock(), Mock())
146146

147147
with pytest.raises(
148148
HomeAssistantError, match=f"Failed to set state for {ENTITY_ID}"

0 commit comments

Comments
 (0)