Add Velux initial quality scale assessment (home-assistant#154615)

Author: wollew

homeassistant/components/velux/config_flow.py

@@ -85,7 +85,7 @@ async def async_step_dhcp(
             updates={CONF_HOST: self.discovery_data[CONF_HOST]}
         )
 
-        # Abort if config_entry already exists without unigue_id configured.
+        # Abort if config_entry already exists without unique_id configured.
         for entry in self.hass.config_entries.async_entries(DOMAIN):
             if (
                 entry.data[CONF_HOST] == self.discovery_data[CONF_HOST]

homeassistant/components/velux/quality_scale.yaml

@@ -0,0 +1,76 @@
+rules:
+  # Bronze
+  action-setup:
+    status: todo
+    comment: needs to move to async_setup
+  appropriate-polling: done
+  brands: done
+  common-modules: done
+  config-flow-test-coverage: done
+  config-flow: done
+  dependency-transparency:
+    status: todo
+    comment: release-builds need CI
+  docs-actions: done
+  docs-high-level-description: done
+  docs-installation-instructions: done
+  docs-removal-instructions: done
+  entity-event-setup:
+    status: todo
+    comment: subscribe is ok, unsubscribe needs to be added
+  entity-unique-id: done
+  has-entity-name:
+    status: todo
+    comment: scenes need fixing
+  runtime-data: done
+  test-before-configure: done
+  test-before-setup:
+    status: todo
+    comment: needs rework, failure to setup currently only returns false
+  unique-config-entry: done
+
+  # Silver
+  action-exceptions: todo
+  config-entry-unloading: todo
+  docs-configuration-parameters: todo
+  docs-installation-parameters: todo
+  entity-unavailable: todo
+  integration-owner: done
+  log-when-unavailable: todo
+  parallel-updates:
+    status: todo
+    comment: button still needs it
+  reauthentication-flow: todo
+  test-coverage:
+    status: todo
+    comment: cleanup mock_config_entry vs mock_user_config_entry, cleanup mock_pyvlx vs mock_velux_client, remove unused freezer in test_cover_closed, add tests where missing
+
+  # Gold
+  devices:
+    status: todo
+    comment: scenes need devices
+  diagnostics: todo
+  discovery-update-info: todo
+  discovery: done
+  docs-data-update: todo
+  docs-examples: todo
+  docs-known-limitations: todo
+  docs-supported-devices: todo
+  docs-supported-functions: todo
+  docs-troubleshooting: todo
+  docs-use-cases: todo
+  dynamic-devices: todo
+  entity-category: todo
+  entity-device-class: todo
+  entity-disabled-by-default: todo
+  entity-translations: todo
+  exception-translations: todo
+  icon-translations: todo
+  reconfiguration-flow: todo
+  repair-issues: todo
+  stale-devices: todo
+
+  # Platinum
+  async-dependency: todo
+  inject-websession: todo
+  strict-typing: todo

script/hassfest/quality_scale.py

@@ -1034,7 +1034,6 @@ class Rule:
     "v2c",
     "vallox",
     "vasttrafik",
-    "velux",
     "venstar",
     "vera",
     "verisure",