Improve parametrize in tuya light tests (home-assistant#156581)

Author: epenet

tests/components/tuya/test_light.py

@@ -45,9 +45,10 @@ async def test_platform_setup_and_discovery(
     ["dj_mki13ie507rlry4r"],
 )
 @pytest.mark.parametrize(
-    ("turn_on_input", "expected_commands"),
+    ("service", "service_data", "expected_commands"),
     [
         (
+            SERVICE_TURN_ON,
             {
                 ATTR_WHITE: True,
             },
@@ -58,6 +59,7 @@ async def test_platform_setup_and_discovery(
             ],
         ),
         (
+            SERVICE_TURN_ON,
             {
                 ATTR_BRIGHTNESS: 150,
             },
@@ -67,6 +69,7 @@ async def test_platform_setup_and_discovery(
             ],
         ),
         (
+            SERVICE_TURN_ON,
             {
                 ATTR_WHITE: True,
                 ATTR_BRIGHTNESS: 150,
@@ -78,6 +81,7 @@ async def test_platform_setup_and_discovery(
             ],
         ),
         (
+            SERVICE_TURN_ON,
             {
                 ATTR_WHITE: 150,
             },
@@ -87,61 +91,38 @@ async def test_platform_setup_and_discovery(
                 {"code": "bright_value_v2", "value": 592},
             ],
         ),
+        (
+            SERVICE_TURN_OFF,
+            {},
+            [{"code": "switch_led", "value": False}],
+        ),
     ],
 )
-async def test_turn_on_white(
+async def test_action(
     hass: HomeAssistant,
     mock_manager: Manager,
     mock_config_entry: MockConfigEntry,
     mock_device: CustomerDevice,
-    turn_on_input: dict[str, Any],
+    service: str,
+    service_data: dict[str, Any],
     expected_commands: list[dict[str, Any]],
 ) -> None:
-    """Test turn_on service."""
+    """Test service action."""
     entity_id = "light.garage_light"
     await initialize_entry(hass, mock_manager, mock_config_entry, mock_device)
 
     state = hass.states.get(entity_id)
     assert state is not None, f"{entity_id} does not exist"
     await hass.services.async_call(
         LIGHT_DOMAIN,
-        SERVICE_TURN_ON,
+        service,
         {
             ATTR_ENTITY_ID: entity_id,
-            **turn_on_input,
+            **service_data,
         },
         blocking=True,
     )
     mock_manager.send_commands.assert_called_once_with(
         mock_device.id,
         expected_commands,
     )
-
-
-@pytest.mark.parametrize(
-    "mock_device_code",
-    ["dj_mki13ie507rlry4r"],
-)
-async def test_turn_off(
-    hass: HomeAssistant,
-    mock_manager: Manager,
-    mock_config_entry: MockConfigEntry,
-    mock_device: CustomerDevice,
-) -> None:
-    """Test turn_off service."""
-    entity_id = "light.garage_light"
-    await initialize_entry(hass, mock_manager, mock_config_entry, mock_device)
-
-    state = hass.states.get(entity_id)
-    assert state is not None, f"{entity_id} does not exist"
-    await hass.services.async_call(
-        LIGHT_DOMAIN,
-        SERVICE_TURN_OFF,
-        {
-            ATTR_ENTITY_ID: entity_id,
-        },
-        blocking=True,
-    )
-    mock_manager.send_commands.assert_called_once_with(
-        mock_device.id, [{"code": "switch_led", "value": False}]
-    )