Respect hdmi isActiveInput for chromecast devices (home-assistant#149150)

Co-authored-by: Joost Lekkerkerker <[email protected]>
Co-authored-by: Erik Montnemery <[email protected]>

Author: 3 people

homeassistant/components/cast/media_player.py

@@ -816,13 +816,20 @@ def state(self) -> MediaPlayerState | None:
                 return MediaPlayerState.PAUSED
             if media_status.player_is_idle:
                 return MediaPlayerState.IDLE
-        if self.app_id is not None and self.app_id != pychromecast.IDLE_APP_ID:
-            if self.app_id in APP_IDS_UNRELIABLE_MEDIA_INFO:
-                # Some apps don't report media status, show the player as playing
-                return MediaPlayerState.PLAYING
-            return MediaPlayerState.IDLE
+
         if self._chromecast is not None and self._chromecast.is_idle:
+            # If library consider us idle, that is our off state
+            # it takes HDMI status into account for cast devices.
             return MediaPlayerState.OFF
+
+        if self.app_id in APP_IDS_UNRELIABLE_MEDIA_INFO:
+            # Some apps don't report media status, show the player as playing
+            return MediaPlayerState.PLAYING
+
+        if self.app_id is not None:
+            # We have an active app
+            return MediaPlayerState.IDLE
+
         return None
 
     @property

tests/components/cast/test_media_player.py

@@ -68,6 +68,7 @@ def get_fake_chromecast(info: ChromecastInfo):
     mock = MagicMock(uuid=info.uuid)
     mock.app_id = None
     mock.media_controller.status = None
+    mock.is_idle = True
     return mock
 
 
@@ -887,6 +888,7 @@ async def test_entity_cast_status(
     assert not state.attributes.get("is_volume_muted")
 
     chromecast.app_id = "1234"
+    chromecast.is_idle = False
     cast_status = MagicMock()
     cast_status.volume_level = 0.5
     cast_status.volume_muted = False
@@ -1599,6 +1601,7 @@ async def test_entity_media_states(
 
     # App id updated, but no media status
     chromecast.app_id = app_id
+    chromecast.is_idle = False
     cast_status = MagicMock()
     cast_status_cb(cast_status)
     await hass.async_block_till_done()
@@ -1641,13 +1644,15 @@ async def test_entity_media_states(
 
     # App no longer running
     chromecast.app_id = pychromecast.IDLE_APP_ID
+    chromecast.is_idle = True
     cast_status = MagicMock()
     cast_status_cb(cast_status)
     await hass.async_block_till_done()
     state = hass.states.get(entity_id)
     assert state.state == "off"
 
     # No cast status
+    chromecast.app_id = None
     chromecast.is_idle = False
     cast_status_cb(None)
     await hass.async_block_till_done()
@@ -1722,6 +1727,7 @@ async def test_entity_media_states_lovelace_app(
     state = hass.states.get(entity_id)
     assert state.state == "off"
 
+    chromecast.app_id = None
     chromecast.is_idle = False
     media_status_cb(media_status)
     await hass.async_block_till_done()