Simplify blink service actions (home-assistant#146508)

Author: epenet

homeassistant/components/blink/__init__.py

@@ -25,7 +25,7 @@
 
 from .const import DEFAULT_SCAN_INTERVAL, DOMAIN, PLATFORMS
 from .coordinator import BlinkConfigEntry, BlinkUpdateCoordinator
-from .services import setup_services
+from .services import async_setup_services
 
 _LOGGER = logging.getLogger(__name__)
 
@@ -72,7 +72,7 @@ async def async_migrate_entry(hass: HomeAssistant, entry: BlinkConfigEntry) -> b
 async def async_setup(hass: HomeAssistant, config: ConfigType) -> bool:
     """Set up Blink."""
 
-    setup_services(hass)
+    async_setup_services(hass)
 
     return True
 

homeassistant/components/blink/services.py

@@ -6,7 +6,7 @@
 
 from homeassistant.config_entries import ConfigEntryState
 from homeassistant.const import CONF_PIN
-from homeassistant.core import HomeAssistant, ServiceCall
+from homeassistant.core import HomeAssistant, ServiceCall, callback
 from homeassistant.exceptions import HomeAssistantError, ServiceValidationError
 from homeassistant.helpers import config_validation as cv
 
@@ -21,34 +21,36 @@
 )
 
 
-def setup_services(hass: HomeAssistant) -> None:
-    """Set up the services for the Blink integration."""
-
-    async def send_pin(call: ServiceCall):
-        """Call blink to send new pin."""
-        config_entry: BlinkConfigEntry | None
-        for entry_id in call.data[ATTR_CONFIG_ENTRY_ID]:
-            if not (config_entry := hass.config_entries.async_get_entry(entry_id)):
-                raise ServiceValidationError(
-                    translation_domain=DOMAIN,
-                    translation_key="integration_not_found",
-                    translation_placeholders={"target": DOMAIN},
-                )
-            if config_entry.state != ConfigEntryState.LOADED:
-                raise HomeAssistantError(
-                    translation_domain=DOMAIN,
-                    translation_key="not_loaded",
-                    translation_placeholders={"target": config_entry.title},
-                )
-            coordinator = config_entry.runtime_data
-            await coordinator.api.auth.send_auth_key(
-                coordinator.api,
-                call.data[CONF_PIN],
+async def _send_pin(call: ServiceCall) -> None:
+    """Call blink to send new pin."""
+    config_entry: BlinkConfigEntry | None
+    for entry_id in call.data[ATTR_CONFIG_ENTRY_ID]:
+        if not (config_entry := call.hass.config_entries.async_get_entry(entry_id)):
+            raise ServiceValidationError(
+                translation_domain=DOMAIN,
+                translation_key="integration_not_found",
+                translation_placeholders={"target": DOMAIN},
+            )
+        if config_entry.state != ConfigEntryState.LOADED:
+            raise HomeAssistantError(
+                translation_domain=DOMAIN,
+                translation_key="not_loaded",
+                translation_placeholders={"target": config_entry.title},
             )
+        coordinator = config_entry.runtime_data
+        await coordinator.api.auth.send_auth_key(
+            coordinator.api,
+            call.data[CONF_PIN],
+        )
+
+
+@callback
+def async_setup_services(hass: HomeAssistant) -> None:
+    """Set up the services for the Blink integration."""
 
     hass.services.async_register(
         DOMAIN,
         SERVICE_SEND_PIN,
-        send_pin,
+        _send_pin,
         schema=SERVICE_SEND_PIN_SCHEMA,
     )