Record last_reported for KNX BinarySensor entitiy states (home-assistant#154392)

Author: farmio

homeassistant/components/knx/binary_sensor.py

@@ -125,6 +125,7 @@ def __init__(self, knx_module: KNXModule, config: ConfigType) -> None:
                 ignore_internal_state=config[CONF_IGNORE_INTERNAL_STATE],
                 context_timeout=config.get(CONF_CONTEXT_TIMEOUT),
                 reset_after=config.get(CONF_RESET_AFTER),
+                always_callback=True,
             ),
         )
         self._attr_entity_category = config.get(CONF_ENTITY_CATEGORY)
@@ -159,5 +160,6 @@ def __init__(
             ),
             context_timeout=knx_conf.get(CONF_CONTEXT_TIMEOUT),
             reset_after=knx_conf.get(CONF_RESET_AFTER),
+            always_callback=True,
         )
         self._attr_force_update = self._device.ignore_internal_state

tests/components/knx/test_binary_sensor.py

@@ -109,6 +109,40 @@ async def test_binary_sensor(hass: HomeAssistant, knx: KNXTestKit) -> None:
     await knx.assert_telegram_count(0)
 
 
+async def test_last_reported(
+    hass: HomeAssistant,
+    knx: KNXTestKit,
+    freezer: FrozenDateTimeFactory,
+) -> None:
+    """Test KNX binary sensor properly sets last_reported."""
+
+    await knx.setup_integration(
+        {
+            BinarySensorSchema.PLATFORM: [
+                {
+                    CONF_NAME: "test",
+                    CONF_STATE_ADDRESS: "1/1/1",
+                    CONF_SYNC_STATE: False,
+                },
+            ]
+        }
+    )
+    events = async_capture_events(hass, "state_changed")
+
+    # receive initial telegram
+    await knx.receive_write("1/1/1", True)
+    first_reported = hass.states.get("binary_sensor.test").last_reported
+    assert len(events) == 1
+
+    # receive second telegram with identical payload
+    freezer.tick(1)
+    async_fire_time_changed(hass)
+    await knx.receive_write("1/1/1", True)
+
+    assert first_reported != hass.states.get("binary_sensor.test").last_reported
+    assert len(events) == 1, events  # last_reported shall not fire state_changed
+
+
 async def test_binary_sensor_ignore_internal_state(
     hass: HomeAssistant, knx: KNXTestKit
 ) -> None:

tests/components/knx/test_sensor.py

@@ -48,7 +48,7 @@ async def test_last_reported(
     knx: KNXTestKit,
     freezer: FrozenDateTimeFactory,
 ) -> None:
-    """Test KNX sensor with last_reported."""
+    """Test KNX sensor properly sets last_reported."""
 
     await knx.setup_integration(
         {