Raise UpdateFailed if API returns None in sfr_box (home-assistant#157434)

Author: epenet

homeassistant/components/sfr_box/binary_sensor.py

@@ -97,6 +97,4 @@ class SFRBoxBinarySensor[_T](SFRCoordinatorEntity[_T], BinarySensorEntity):
     @property
     def is_on(self) -> bool | None:
         """Return the native value of the device."""
-        if self.coordinator.data is None:
-            return None
         return self.entity_description.value_fn(self.coordinator.data)

homeassistant/components/sfr_box/coordinator.py

@@ -33,7 +33,7 @@ class SFRRuntimeData:
     wan: SFRDataUpdateCoordinator[WanInfo]
 
 
-class SFRDataUpdateCoordinator[_DataT](DataUpdateCoordinator[_DataT | None]):
+class SFRDataUpdateCoordinator[_DataT](DataUpdateCoordinator[_DataT]):
     """Coordinator to manage data updates."""
 
     config_entry: SFRConfigEntry
@@ -57,9 +57,11 @@ def __init__(
             update_interval=_SCAN_INTERVAL,
         )
 
-    async def _async_update_data(self) -> _DataT | None:
+    async def _async_update_data(self) -> _DataT:
         """Update data."""
         try:
-            return await self._method(self.box)
+            if data := await self._method(self.box):
+                return data
         except SFRBoxError as err:
             raise UpdateFailed from err
+        raise UpdateFailed("No data received from SFR Box")

homeassistant/components/sfr_box/sensor.py

@@ -253,6 +253,4 @@ class SFRBoxSensor[_T](SFRCoordinatorEntity[_T], SensorEntity):
     @property
     def native_value(self) -> StateType:
         """Return the native value of the device."""
-        if self.coordinator.data is None:
-            return None
         return self.entity_description.value_fn(self.coordinator.data)