Add config flow exceptions to IOMeter (home-assistant#154604)

Co-authored-by: Copilot <[email protected]>

Author: jukrebs

homeassistant/components/iometer/config_flow.py

@@ -2,7 +2,12 @@
 
 from typing import Any, Final
 
-from iometer import IOmeterClient, IOmeterConnectionError
+from iometer import (
+    IOmeterClient,
+    IOmeterConnectionError,
+    IOmeterNoReadingsError,
+    IOmeterNoStatusError,
+)
 import voluptuous as vol
 
 from homeassistant.config_entries import ConfigFlow, ConfigFlowResult
@@ -34,6 +39,11 @@ async def async_step_zeroconf(
         client = IOmeterClient(host=host, session=session)
         try:
             status = await client.get_current_status()
+            _ = await client.get_current_reading()
+        except IOmeterNoStatusError:
+            return self.async_abort(reason="no_status")
+        except IOmeterNoReadingsError:
+            return self.async_abort(reason="no_readings")
         except IOmeterConnectionError:
             return self.async_abort(reason="cannot_connect")
 
@@ -70,6 +80,11 @@ async def async_step_user(
             client = IOmeterClient(host=self._host, session=session)
             try:
                 status = await client.get_current_status()
+                _ = await client.get_current_reading()
+            except IOmeterNoStatusError:
+                errors["base"] = "no_status"
+            except IOmeterNoReadingsError:
+                errors["base"] = "no_readings"
             except IOmeterConnectionError:
                 errors["base"] = "cannot_connect"
             else:

homeassistant/components/iometer/strings.json

@@ -20,6 +20,8 @@
       "already_in_progress": "[%key:common::config_flow::abort::already_in_progress%]"
     },
     "error": {
+      "no_status": "No status received from the IOmeter. Check your device status in the IOmeter app",
+      "no_readings": "No readings received from the IOmeter. Please attach the IOmeter Core to the electricity meter and wait for the first reading.",
       "cannot_connect": "[%key:common::config_flow::error::cannot_connect%]",
       "unknown": "[%key:common::config_flow::error::unknown%]"
     }

tests/components/iometer/test_config_flow.py

@@ -3,7 +3,8 @@
 from ipaddress import ip_address
 from unittest.mock import AsyncMock
 
-from iometer import IOmeterConnectionError
+from iometer import IOmeterConnectionError, IOmeterNoReadingsError, IOmeterNoStatusError
+import pytest
 
 from homeassistant.components import zeroconf
 from homeassistant.components.iometer.const import DOMAIN
@@ -93,29 +94,54 @@ async def test_zeroconf_flow_abort_duplicate(
     assert result["reason"] == "already_configured"
 
 
-async def test_zeroconf_flow_connection_error(
+@pytest.mark.parametrize(
+    ("method_name", "exception", "reason"),
+    [
+        ("get_current_status", IOmeterConnectionError(), "cannot_connect"),
+        ("get_current_status", IOmeterNoStatusError(), "no_status"),
+        ("get_current_reading", IOmeterNoReadingsError(), "no_readings"),
+    ],
+    ids=["status-connection", "status-missing", "reading-missing"],
+)
+async def test_zeroconf_flow_abort_errors(
     hass: HomeAssistant,
     mock_iometer_client: AsyncMock,
+    method_name: str,
+    exception: Exception,
+    reason: str,
 ) -> None:
-    """Test zeroconf flow."""
-    mock_iometer_client.get_current_status.side_effect = IOmeterConnectionError()
+    """Test zeroconf flow aborts when the client raises an exception."""
+    getattr(mock_iometer_client, method_name).side_effect = exception
+
     result = await hass.config_entries.flow.async_init(
         DOMAIN,
         context={"source": SOURCE_ZEROCONF},
         data=ZEROCONF_DISCOVERY,
     )
     await hass.async_block_till_done()
     assert result["type"] is FlowResultType.ABORT
-    assert result["reason"] == "cannot_connect"
+    assert result["reason"] == reason
 
 
-async def test_user_flow_connection_error(
+@pytest.mark.parametrize(
+    ("method_name", "exception", "error_key"),
+    [
+        ("get_current_status", IOmeterConnectionError(), "cannot_connect"),
+        ("get_current_status", IOmeterNoStatusError(), "no_status"),
+        ("get_current_reading", IOmeterNoReadingsError(), "no_readings"),
+    ],
+    ids=["status-connection", "status-missing", "reading-missing"],
+)
+async def test_user_flow_errors(
     hass: HomeAssistant,
     mock_iometer_client: AsyncMock,
     mock_setup_entry: AsyncMock,
+    method_name: str,
+    exception: Exception,
+    error_key: str,
 ) -> None:
-    """Test flow error."""
-    mock_iometer_client.get_current_status.side_effect = IOmeterConnectionError()
+    """Test user flow returns errors for client exceptions."""
+    getattr(mock_iometer_client, method_name).side_effect = exception
 
     result = await hass.config_entries.flow.async_init(
         DOMAIN,
@@ -130,11 +156,10 @@ async def test_user_flow_connection_error(
         {CONF_HOST: IP_ADDRESS},
     )
     await hass.async_block_till_done()
-
     assert result["type"] is FlowResultType.FORM
-    assert result["errors"] == {"base": "cannot_connect"}
+    assert result["errors"] == {"base": error_key}
 
-    mock_iometer_client.get_current_status.side_effect = None
+    getattr(mock_iometer_client, method_name).side_effect = None
 
     result = await hass.config_entries.flow.async_configure(
         result["flow_id"],