Fix bug with the hardcoded configuration_url (asuswrt) (home-assistant#151858)

Author: Vaskivskyi

homeassistant/components/asuswrt/bridge.py

@@ -120,11 +120,17 @@ def get_bridge(
 
     def __init__(self, host: str) -> None:
         """Initialize Bridge."""
+        self._configuration_url = f"http://{host}"
         self._host = host
         self._firmware: str | None = None
         self._label_mac: str | None = None
         self._model: str | None = None
 
+    @property
+    def configuration_url(self) -> str:
+        """Return configuration URL."""
+        return self._configuration_url
+
     @property
     def host(self) -> str:
         """Return hostname."""
@@ -359,6 +365,7 @@ async def async_connect(self) -> None:
         # get main router properties
         if mac := _identity.mac:
             self._label_mac = format_mac(mac)
+        self._configuration_url = self._api.webpanel
         self._firmware = str(_identity.firmware)
         self._model = _identity.model
 

homeassistant/components/asuswrt/router.py

@@ -388,11 +388,11 @@ def update_options(self, new_options: Mapping[str, Any]) -> bool:
     def device_info(self) -> DeviceInfo:
         """Return the device information."""
         info = DeviceInfo(
+            configuration_url=self._api.configuration_url,
             identifiers={(DOMAIN, self._entry.unique_id or "AsusWRT")},
             name=self.host,
             model=self._api.model or "Asus Router",
             manufacturer="Asus",
-            configuration_url=f"http://{self.host}",
         )
         if self._api.firmware:
             info["sw_version"] = self._api.firmware

tests/components/asuswrt/conftest.py

@@ -12,6 +12,7 @@
 
 from .common import (
     ASUSWRT_BASE,
+    HOST,
     MOCK_MACS,
     PROTOCOL_HTTP,
     PROTOCOL_SSH,
@@ -155,6 +156,9 @@ def mock_controller_connect_http(mock_devices_http):
         # Simulate connection status
         instance.connected = True
 
+        # Set the webpanel address
+        instance.webpanel = f"http://{HOST}:80"
+
         # Identity
         instance.async_get_identity.return_value = AsusDevice(
             mac=ROUTER_MAC_ADDR,