Move available property to entity.py for Squeezebox (home-assistant#146531)

Author: peteS-UK

homeassistant/components/squeezebox/button.py

@@ -153,11 +153,6 @@ def __init__(
             f"{format_mac(self._player.player_id)}_{entity_description.key}"
         )
 
-    @property
-    def available(self) -> bool:
-        """Return True if entity is available."""
-        return self.coordinator.available and super().available
-
     async def async_press(self) -> None:
         """Execute the button action."""
         await self._player.async_query("button", self.entity_description.press_action)

homeassistant/components/squeezebox/entity.py

@@ -33,6 +33,13 @@ def __init__(self, coordinator: SqueezeBoxPlayerUpdateCoordinator) -> None:
             manufacturer=self._player.creator,
         )
 
+    @property
+    def available(self) -> bool:
+        """Return True if entity is available."""
+        # super().available refers to CoordinatorEntity.available (self.coordinator.last_update_success)
+        # self.coordinator.available is the custom availability flag from SqueezeBoxPlayerUpdateCoordinator
+        return self.coordinator.available and super().available
+
 
 class LMSStatusEntity(CoordinatorEntity[LMSStatusDataUpdateCoordinator]):
     """Defines a base status sensor entity."""

homeassistant/components/squeezebox/media_player.py

@@ -246,11 +246,6 @@ def browse_limit(self) -> int:
             CONF_BROWSE_LIMIT, DEFAULT_BROWSE_LIMIT
         )
 
-    @property
-    def available(self) -> bool:
-        """Return True if entity is available."""
-        return self.coordinator.available and super().available
-
     @property
     def extra_state_attributes(self) -> dict[str, Any]:
         """Return device-specific attributes."""