Skip to content

Commit bd10da1

Browse files
bouwewbouwew
authored
Revisit diagnostic-category assignments for Plugwise (home-assistant#156279)
1 parent b73a792 commit bd10da1

File tree

4 files changed

+30
-32
lines changed

4 files changed

+30
-32
lines changed

‎homeassistant/components/plugwise/select.py‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ class PlugwiseSelectEntityDescription(SelectEntityDescription):
3737
PlugwiseSelectEntityDescription(
3838
key=SELECT_SCHEDULE,
3939
translation_key=SELECT_SCHEDULE,
40+
entity_category=EntityCategory.CONFIG,
4041
options_key="available_schedules",
4142
),
4243
PlugwiseSelectEntityDescription(

‎homeassistant/components/plugwise/sensor.py‎

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -48,29 +48,25 @@ class PlugwiseSensorEntityDescription(SensorEntityDescription):
4848
native_unit_of_measurement=UnitOfTemperature.CELSIUS,
4949
device_class=SensorDeviceClass.TEMPERATURE,
5050
state_class=SensorStateClass.MEASUREMENT,
51-
entity_category=EntityCategory.DIAGNOSTIC,
5251
),
5352
PlugwiseSensorEntityDescription(
5453
key="setpoint_high",
5554
translation_key="cooling_setpoint",
5655
native_unit_of_measurement=UnitOfTemperature.CELSIUS,
5756
device_class=SensorDeviceClass.TEMPERATURE,
5857
state_class=SensorStateClass.MEASUREMENT,
59-
entity_category=EntityCategory.DIAGNOSTIC,
6058
),
6159
PlugwiseSensorEntityDescription(
6260
key="setpoint_low",
6361
translation_key="heating_setpoint",
6462
native_unit_of_measurement=UnitOfTemperature.CELSIUS,
6563
device_class=SensorDeviceClass.TEMPERATURE,
6664
state_class=SensorStateClass.MEASUREMENT,
67-
entity_category=EntityCategory.DIAGNOSTIC,
6865
),
6966
PlugwiseSensorEntityDescription(
7067
key="temperature",
7168
native_unit_of_measurement=UnitOfTemperature.CELSIUS,
7269
device_class=SensorDeviceClass.TEMPERATURE,
73-
entity_category=EntityCategory.DIAGNOSTIC,
7470
state_class=SensorStateClass.MEASUREMENT,
7571
),
7672
PlugwiseSensorEntityDescription(
@@ -94,6 +90,7 @@ class PlugwiseSensorEntityDescription(SensorEntityDescription):
9490
translation_key="outdoor_temperature",
9591
native_unit_of_measurement=UnitOfTemperature.CELSIUS,
9692
device_class=SensorDeviceClass.TEMPERATURE,
93+
entity_category=EntityCategory.DIAGNOSTIC,
9794
state_class=SensorStateClass.MEASUREMENT,
9895
),
9996
PlugwiseSensorEntityDescription(
@@ -352,8 +349,8 @@ class PlugwiseSensorEntityDescription(SensorEntityDescription):
352349
key="illuminance",
353350
native_unit_of_measurement=LIGHT_LUX,
354351
device_class=SensorDeviceClass.ILLUMINANCE,
355-
state_class=SensorStateClass.MEASUREMENT,
356352
entity_category=EntityCategory.DIAGNOSTIC,
353+
state_class=SensorStateClass.MEASUREMENT,
357354
),
358355
PlugwiseSensorEntityDescription(
359356
key="modulation_level",
@@ -365,8 +362,8 @@ class PlugwiseSensorEntityDescription(SensorEntityDescription):
365362
PlugwiseSensorEntityDescription(
366363
key="valve_position",
367364
translation_key="valve_position",
368-
entity_category=EntityCategory.DIAGNOSTIC,
369365
native_unit_of_measurement=PERCENTAGE,
366+
entity_category=EntityCategory.DIAGNOSTIC,
370367
state_class=SensorStateClass.MEASUREMENT,
371368
),
372369
PlugwiseSensorEntityDescription(

‎tests/components/plugwise/snapshots/test_select.ambr‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@
141141
'device_id': <ANY>,
142142
'disabled_by': None,
143143
'domain': 'select',
144-
'entity_category': None,
144+
'entity_category': <EntityCategory.CONFIG: 'config'>,
145145
'entity_id': 'select.bathroom_thermostat_schedule',
146146
'has_entity_name': True,
147147
'hidden_by': None,
@@ -263,7 +263,7 @@
263263
'device_id': <ANY>,
264264
'disabled_by': None,
265265
'domain': 'select',
266-
'entity_category': None,
266+
'entity_category': <EntityCategory.CONFIG: 'config'>,
267267
'entity_id': 'select.living_room_thermostat_schedule',
268268
'has_entity_name': True,
269269
'hidden_by': None,
@@ -386,7 +386,7 @@
386386
'device_id': <ANY>,
387387
'disabled_by': None,
388388
'domain': 'select',
389-
'entity_category': None,
389+
'entity_category': <EntityCategory.CONFIG: 'config'>,
390390
'entity_id': 'select.badkamer_thermostat_schedule',
391391
'has_entity_name': True,
392392
'hidden_by': None,
@@ -451,7 +451,7 @@
451451
'device_id': <ANY>,
452452
'disabled_by': None,
453453
'domain': 'select',
454-
'entity_category': None,
454+
'entity_category': <EntityCategory.CONFIG: 'config'>,
455455
'entity_id': 'select.bios_thermostat_schedule',
456456
'has_entity_name': True,
457457
'hidden_by': None,
@@ -516,7 +516,7 @@
516516
'device_id': <ANY>,
517517
'disabled_by': None,
518518
'domain': 'select',
519-
'entity_category': None,
519+
'entity_category': <EntityCategory.CONFIG: 'config'>,
520520
'entity_id': 'select.jessie_thermostat_schedule',
521521
'has_entity_name': True,
522522
'hidden_by': None,
@@ -581,7 +581,7 @@
581581
'device_id': <ANY>,
582582
'disabled_by': None,
583583
'domain': 'select',
584-
'entity_category': None,
584+
'entity_category': <EntityCategory.CONFIG: 'config'>,
585585
'entity_id': 'select.woonkamer_thermostat_schedule',
586586
'has_entity_name': True,
587587
'hidden_by': None,

‎tests/components/plugwise/snapshots/test_sensor.ambr‎

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
'device_id': <ANY>,
1414
'disabled_by': None,
1515
'domain': 'sensor',
16-
'entity_category': None,
16+
'entity_category': <EntityCategory.DIAGNOSTIC: 'diagnostic'>,
1717
'entity_id': 'sensor.adam_outdoor_temperature',
1818
'has_entity_name': True,
1919
'hidden_by': None,
@@ -69,7 +69,7 @@
6969
'device_id': <ANY>,
7070
'disabled_by': None,
7171
'domain': 'sensor',
72-
'entity_category': <EntityCategory.DIAGNOSTIC: 'diagnostic'>,
72+
'entity_category': None,
7373
'entity_id': 'sensor.anna_setpoint',
7474
'has_entity_name': True,
7575
'hidden_by': None,
@@ -125,7 +125,7 @@
125125
'device_id': <ANY>,
126126
'disabled_by': None,
127127
'domain': 'sensor',
128-
'entity_category': <EntityCategory.DIAGNOSTIC: 'diagnostic'>,
128+
'entity_category': None,
129129
'entity_id': 'sensor.anna_temperature',
130130
'has_entity_name': True,
131131
'hidden_by': None,
@@ -293,7 +293,7 @@
293293
'device_id': <ANY>,
294294
'disabled_by': None,
295295
'domain': 'sensor',
296-
'entity_category': <EntityCategory.DIAGNOSTIC: 'diagnostic'>,
296+
'entity_category': None,
297297
'entity_id': 'sensor.bathroom_temperature',
298298
'has_entity_name': True,
299299
'hidden_by': None,
@@ -455,7 +455,7 @@
455455
'device_id': <ANY>,
456456
'disabled_by': None,
457457
'domain': 'sensor',
458-
'entity_category': <EntityCategory.DIAGNOSTIC: 'diagnostic'>,
458+
'entity_category': None,
459459
'entity_id': 'sensor.emma_setpoint',
460460
'has_entity_name': True,
461461
'hidden_by': None,
@@ -511,7 +511,7 @@
511511
'device_id': <ANY>,
512512
'disabled_by': None,
513513
'domain': 'sensor',
514-
'entity_category': <EntityCategory.DIAGNOSTIC: 'diagnostic'>,
514+
'entity_category': None,
515515
'entity_id': 'sensor.emma_temperature',
516516
'has_entity_name': True,
517517
'hidden_by': None,
@@ -673,7 +673,7 @@
673673
'device_id': <ANY>,
674674
'disabled_by': None,
675675
'domain': 'sensor',
676-
'entity_category': <EntityCategory.DIAGNOSTIC: 'diagnostic'>,
676+
'entity_category': None,
677677
'entity_id': 'sensor.jip_setpoint',
678678
'has_entity_name': True,
679679
'hidden_by': None,
@@ -729,7 +729,7 @@
729729
'device_id': <ANY>,
730730
'disabled_by': None,
731731
'domain': 'sensor',
732-
'entity_category': <EntityCategory.DIAGNOSTIC: 'diagnostic'>,
732+
'entity_category': None,
733733
'entity_id': 'sensor.jip_temperature',
734734
'has_entity_name': True,
735735
'hidden_by': None,
@@ -838,7 +838,7 @@
838838
'device_id': <ANY>,
839839
'disabled_by': None,
840840
'domain': 'sensor',
841-
'entity_category': <EntityCategory.DIAGNOSTIC: 'diagnostic'>,
841+
'entity_category': None,
842842
'entity_id': 'sensor.lisa_badkamer_setpoint',
843843
'has_entity_name': True,
844844
'hidden_by': None,
@@ -894,7 +894,7 @@
894894
'device_id': <ANY>,
895895
'disabled_by': None,
896896
'domain': 'sensor',
897-
'entity_category': <EntityCategory.DIAGNOSTIC: 'diagnostic'>,
897+
'entity_category': None,
898898
'entity_id': 'sensor.lisa_badkamer_temperature',
899899
'has_entity_name': True,
900900
'hidden_by': None,
@@ -1062,7 +1062,7 @@
10621062
'device_id': <ANY>,
10631063
'disabled_by': None,
10641064
'domain': 'sensor',
1065-
'entity_category': <EntityCategory.DIAGNOSTIC: 'diagnostic'>,
1065+
'entity_category': None,
10661066
'entity_id': 'sensor.living_room_temperature',
10671067
'has_entity_name': True,
10681068
'hidden_by': None,
@@ -1283,7 +1283,7 @@
12831283
'device_id': <ANY>,
12841284
'disabled_by': None,
12851285
'domain': 'sensor',
1286-
'entity_category': <EntityCategory.DIAGNOSTIC: 'diagnostic'>,
1286+
'entity_category': None,
12871287
'entity_id': 'sensor.tom_badkamer_setpoint',
12881288
'has_entity_name': True,
12891289
'hidden_by': None,
@@ -1339,7 +1339,7 @@
13391339
'device_id': <ANY>,
13401340
'disabled_by': None,
13411341
'domain': 'sensor',
1342-
'entity_category': <EntityCategory.DIAGNOSTIC: 'diagnostic'>,
1342+
'entity_category': None,
13431343
'entity_id': 'sensor.tom_badkamer_temperature',
13441344
'has_entity_name': True,
13451345
'hidden_by': None,
@@ -1556,7 +1556,7 @@
15561556
'device_id': <ANY>,
15571557
'disabled_by': None,
15581558
'domain': 'sensor',
1559-
'entity_category': <EntityCategory.DIAGNOSTIC: 'diagnostic'>,
1559+
'entity_category': None,
15601560
'entity_id': 'sensor.anna_setpoint',
15611561
'has_entity_name': True,
15621562
'hidden_by': None,
@@ -1612,7 +1612,7 @@
16121612
'device_id': <ANY>,
16131613
'disabled_by': None,
16141614
'domain': 'sensor',
1615-
'entity_category': <EntityCategory.DIAGNOSTIC: 'diagnostic'>,
1615+
'entity_category': None,
16161616
'entity_id': 'sensor.anna_temperature',
16171617
'has_entity_name': True,
16181618
'hidden_by': None,
@@ -2948,7 +2948,7 @@
29482948
'device_id': <ANY>,
29492949
'disabled_by': None,
29502950
'domain': 'sensor',
2951-
'entity_category': None,
2951+
'entity_category': <EntityCategory.DIAGNOSTIC: 'diagnostic'>,
29522952
'entity_id': 'sensor.smile_anna_p1_outdoor_temperature',
29532953
'has_entity_name': True,
29542954
'hidden_by': None,
@@ -3004,7 +3004,7 @@
30043004
'device_id': <ANY>,
30053005
'disabled_by': None,
30063006
'domain': 'sensor',
3007-
'entity_category': <EntityCategory.DIAGNOSTIC: 'diagnostic'>,
3007+
'entity_category': None,
30083008
'entity_id': 'sensor.anna_cooling_setpoint',
30093009
'has_entity_name': True,
30103010
'hidden_by': None,
@@ -3060,7 +3060,7 @@
30603060
'device_id': <ANY>,
30613061
'disabled_by': None,
30623062
'domain': 'sensor',
3063-
'entity_category': <EntityCategory.DIAGNOSTIC: 'diagnostic'>,
3063+
'entity_category': None,
30643064
'entity_id': 'sensor.anna_heating_setpoint',
30653065
'has_entity_name': True,
30663066
'hidden_by': None,
@@ -3169,7 +3169,7 @@
31693169
'device_id': <ANY>,
31703170
'disabled_by': None,
31713171
'domain': 'sensor',
3172-
'entity_category': <EntityCategory.DIAGNOSTIC: 'diagnostic'>,
3172+
'entity_category': None,
31733173
'entity_id': 'sensor.anna_temperature',
31743174
'has_entity_name': True,
31753175
'hidden_by': None,
@@ -3613,7 +3613,7 @@
36133613
'device_id': <ANY>,
36143614
'disabled_by': None,
36153615
'domain': 'sensor',
3616-
'entity_category': None,
3616+
'entity_category': <EntityCategory.DIAGNOSTIC: 'diagnostic'>,
36173617
'entity_id': 'sensor.smile_anna_outdoor_temperature',
36183618
'has_entity_name': True,
36193619
'hidden_by': None,

0 commit comments

Comments
 (0)