Skip to content

Commit d2586ca

Browse files
epenetfrenck
authored andcommitted
Remove tuya vacuum battery level attribute (home-assistant#150086)
1 parent 4e21ef5 commit d2586ca

File tree

2 files changed

+8
-15
lines changed

2 files changed

+8
-15
lines changed

homeassistant/components/tuya/sensor.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -915,6 +915,13 @@ class TuyaSensorEntityDescription(SensorEntityDescription):
915915
translation_key="rolling_brush_life",
916916
state_class=SensorStateClass.MEASUREMENT,
917917
),
918+
TuyaSensorEntityDescription(
919+
key=DPCode.ELECTRICITY_LEFT,
920+
translation_key="battery",
921+
device_class=SensorDeviceClass.BATTERY,
922+
entity_category=EntityCategory.DIAGNOSTIC,
923+
state_class=SensorStateClass.MEASUREMENT,
924+
),
918925
),
919926
# Smart Water Timer
920927
"sfkzq": (

homeassistant/components/tuya/vacuum.py

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
from . import TuyaConfigEntry
1919
from .const import TUYA_DISCOVERY_NEW, DPCode, DPType
2020
from .entity import TuyaEntity
21-
from .models import EnumTypeData, IntegerTypeData
21+
from .models import EnumTypeData
2222

2323
TUYA_MODE_RETURN_HOME = "chargego"
2424
TUYA_STATUS_TO_HA = {
@@ -77,7 +77,6 @@ class TuyaVacuumEntity(TuyaEntity, StateVacuumEntity):
7777
"""Tuya Vacuum Device."""
7878

7979
_fan_speed: EnumTypeData | None = None
80-
_battery_level: IntegerTypeData | None = None
8180
_attr_name = None
8281

8382
def __init__(self, device: CustomerDevice, device_manager: Manager) -> None:
@@ -118,19 +117,6 @@ def __init__(self, device: CustomerDevice, device_manager: Manager) -> None:
118117
self._attr_fan_speed_list = enum_type.range
119118
self._attr_supported_features |= VacuumEntityFeature.FAN_SPEED
120119

121-
if int_type := self.find_dpcode(DPCode.ELECTRICITY_LEFT, dptype=DPType.INTEGER):
122-
self._attr_supported_features |= VacuumEntityFeature.BATTERY
123-
self._battery_level = int_type
124-
125-
@property
126-
def battery_level(self) -> int | None:
127-
"""Return Tuya device state."""
128-
if self._battery_level is None or not (
129-
status := self.device.status.get(DPCode.ELECTRICITY_LEFT)
130-
):
131-
return None
132-
return round(self._battery_level.scale_value(status))
133-
134120
@property
135121
def fan_speed(self) -> str | None:
136122
"""Return the fan speed of the vacuum cleaner."""

0 commit comments

Comments
 (0)