Use is over == comparison for FlowResultType in flow tests (home-assistant#159158)

Author: epenet

tests/auth/providers/test_trusted_networks.py

@@ -267,7 +267,7 @@ async def test_login_flow(
     # not from trusted network
     flow = await provider.async_login_flow({"ip_address": ip_address("127.0.0.1")})
     step = await flow.async_step_init()
-    assert step["type"] == FlowResultType.ABORT
+    assert step["type"] is FlowResultType.ABORT
     assert step["reason"] == "not_allowed"
 
     # from trusted network, list users
@@ -282,7 +282,7 @@ async def test_login_flow(
 
     # login with valid user
     step = await flow.async_step_init({"user": user.id})
-    assert step["type"] == FlowResultType.CREATE_ENTRY
+    assert step["type"] is FlowResultType.CREATE_ENTRY
     assert step["data"]["user"] == user.id
 
 
@@ -309,7 +309,7 @@ async def test_trusted_users_login(
         {"ip_address": ip_address("127.0.0.1")}
     )
     step = await flow.async_step_init()
-    assert step["type"] == FlowResultType.ABORT
+    assert step["type"] is FlowResultType.ABORT
     assert step["reason"] == "not_allowed"
 
     # from trusted network, list users intersect trusted_users
@@ -396,7 +396,7 @@ async def test_trusted_group_login(
         {"ip_address": ip_address("127.0.0.1")}
     )
     step = await flow.async_step_init()
-    assert step["type"] == FlowResultType.ABORT
+    assert step["type"] is FlowResultType.ABORT
     assert step["reason"] == "not_allowed"
 
     # from trusted network, list users intersect trusted_users
@@ -437,15 +437,15 @@ async def test_bypass_login_flow(
         {"ip_address": ip_address("127.0.0.1")}
     )
     step = await flow.async_step_init()
-    assert step["type"] == FlowResultType.ABORT
+    assert step["type"] is FlowResultType.ABORT
     assert step["reason"] == "not_allowed"
 
     # from trusted network, only one available user, bypass the login flow
     flow = await provider_bypass_login.async_login_flow(
         {"ip_address": ip_address("192.168.0.1")}
     )
     step = await flow.async_step_init()
-    assert step["type"] == FlowResultType.CREATE_ENTRY
+    assert step["type"] is FlowResultType.CREATE_ENTRY
     assert step["data"]["user"] == owner.id
 
     user = await manager_bypass_login.async_create_user("test-user")

tests/components/actron_air/test_config_flow.py

@@ -174,7 +174,7 @@ async def test_user_flow_duplicate_account(
     result = await hass.config_entries.flow.async_configure(result["flow_id"])
 
     # Should abort because the account is already configured
-    assert result["type"] == FlowResultType.ABORT
+    assert result["type"] is FlowResultType.ABORT
     assert result["reason"] == "already_configured"
 
 

tests/components/airq/test_config_flow.py

@@ -119,13 +119,13 @@ async def test_options_flow(hass: HomeAssistant, user_input) -> None:
 
     result = await hass.config_entries.options.async_init(entry.entry_id)
 
-    assert result["type"] == FlowResultType.FORM
+    assert result["type"] is FlowResultType.FORM
     assert result["step_id"] == "init"
     assert entry.options == {}
 
     result = await hass.config_entries.options.async_configure(
         result["flow_id"], user_input=user_input
     )
 
-    assert result["type"] == FlowResultType.CREATE_ENTRY
+    assert result["type"] is FlowResultType.CREATE_ENTRY
     assert result["data"] == entry.options == DEFAULT_OPTIONS | user_input

tests/components/ambient_network/test_config_flow.py

@@ -28,7 +28,7 @@ async def test_happy_path(
     setup_result = await hass.config_entries.flow.async_init(
         DOMAIN, context={"source": SOURCE_USER}
     )
-    assert setup_result["type"] == FlowResultType.FORM
+    assert setup_result["type"] is FlowResultType.FORM
     assert setup_result["step_id"] == "user"
 
     with patch.object(
@@ -41,7 +41,7 @@ async def test_happy_path(
             {"location": {"latitude": 10.0, "longitude": 20.0, "radius": 1.0}},
         )
 
-    assert user_result["type"] == FlowResultType.FORM
+    assert user_result["type"] is FlowResultType.FORM
     assert user_result["step_id"] == "station"
 
     stations_result = await hass.config_entries.flow.async_configure(
@@ -51,7 +51,7 @@ async def test_happy_path(
         },
     )
 
-    assert stations_result["type"] == FlowResultType.CREATE_ENTRY
+    assert stations_result["type"] is FlowResultType.CREATE_ENTRY
     assert stations_result["title"] == config_entry.title
     assert stations_result["data"] == config_entry.data
     assert len(mock_setup_entry.mock_calls) == 1
@@ -67,7 +67,7 @@ async def test_no_station_found(
     setup_result = await hass.config_entries.flow.async_init(
         DOMAIN, context={"source": SOURCE_USER}
     )
-    assert setup_result["type"] == FlowResultType.FORM
+    assert setup_result["type"] is FlowResultType.FORM
     assert setup_result["step_id"] == "user"
 
     with patch.object(
@@ -80,6 +80,6 @@ async def test_no_station_found(
             {"location": {"latitude": 10.0, "longitude": 20.0, "radius": 1.0}},
         )
 
-    assert user_result["type"] == FlowResultType.FORM
+    assert user_result["type"] is FlowResultType.FORM
     assert user_result["step_id"] == "user"
     assert user_result["errors"] == {"base": "no_stations_found"}

tests/components/anova/test_config_flow.py

@@ -23,7 +23,7 @@ async def test_flow_user(hass: HomeAssistant, anova_api: AnovaApi) -> None:
         result["flow_id"],
         user_input=CONF_INPUT,
     )
-    assert result["type"] == FlowResultType.CREATE_ENTRY
+    assert result["type"] is FlowResultType.CREATE_ENTRY
     assert result["data"] == {
         CONF_USERNAME: "[email protected]",
         CONF_PASSWORD: "sample",

tests/components/anthropic/test_config_flow.py

@@ -263,7 +263,7 @@ async def test_subentry_web_search_user_location(
             "recommended": False,
         },
     )
-    assert options["type"] == FlowResultType.FORM
+    assert options["type"] is FlowResultType.FORM
     assert options["step_id"] == "advanced"
 
     # Configure advanced step
@@ -274,7 +274,7 @@ async def test_subentry_web_search_user_location(
             "chat_model": "claude-sonnet-4-5",
         },
     )
-    assert options["type"] == FlowResultType.FORM
+    assert options["type"] is FlowResultType.FORM
     assert options["step_id"] == "model"
 
     hass.config.country = "US"
@@ -354,7 +354,7 @@ async def test_model_list(
             "recommended": False,
         },
     )
-    assert options["type"] == FlowResultType.FORM
+    assert options["type"] is FlowResultType.FORM
     assert options["step_id"] == "advanced"
     assert options["data_schema"].schema["chat_model"].config["options"] == [
         {
@@ -429,7 +429,7 @@ async def test_model_list_error(
                 "recommended": False,
             },
         )
-    assert options["type"] == FlowResultType.FORM
+    assert options["type"] is FlowResultType.FORM
     assert options["step_id"] == "advanced"
     assert options["data_schema"].schema["chat_model"].config["options"] == []
 
@@ -634,7 +634,7 @@ async def test_subentry_options_switching(
     assert subentry_flow["step_id"] == "init"
 
     for step_options in new_options:
-        assert subentry_flow["type"] == FlowResultType.FORM
+        assert subentry_flow["type"] is FlowResultType.FORM
         assert not subentry_flow["errors"]
 
         # Test that current options are showed as suggested values:

tests/components/compit/test_config_flow.py

@@ -35,7 +35,7 @@ async def test_async_step_user_success(
         result["flow_id"], CONFIG_INPUT
     )
 
-    assert result["type"] == FlowResultType.CREATE_ENTRY
+    assert result["type"] is FlowResultType.CREATE_ENTRY
     assert result["title"] == CONFIG_INPUT[CONF_EMAIL]
     assert result["data"] == CONFIG_INPUT
     assert len(mock_setup_entry.mock_calls) == 1
@@ -70,14 +70,14 @@ async def test_async_step_user_failed_auth(
         result["flow_id"], CONFIG_INPUT
     )
 
-    assert result["type"] == FlowResultType.FORM
+    assert result["type"] is FlowResultType.FORM
     assert result["errors"] == {"base": expected_error}
 
     # Test success after error is cleared
     result = await hass.config_entries.flow.async_configure(
         result["flow_id"], CONFIG_INPUT
     )
-    assert result["type"] == FlowResultType.CREATE_ENTRY
+    assert result["type"] is FlowResultType.CREATE_ENTRY
     assert result["title"] == CONFIG_INPUT[CONF_EMAIL]
     assert result["data"] == CONFIG_INPUT
     assert len(mock_setup_entry.mock_calls) == 1

tests/components/config/test_config_entries.py

@@ -1028,7 +1028,7 @@ async def async_step_import(
             "test", context={"source": core_ce.SOURCE_IMPORT}, data={}
         )
 
-    assert result["type"] == FlowResultType.CREATE_ENTRY
+    assert result["type"] is FlowResultType.CREATE_ENTRY
     assert len(subscription_mock.mock_calls) == 0
 
 

tests/components/cookidoo/test_config_flow.py

@@ -47,7 +47,7 @@ async def test_flow_user_success(
         user_input=MOCK_DATA_USER_STEP,
     )
 
-    assert result["type"] == FlowResultType.FORM
+    assert result["type"] is FlowResultType.FORM
     assert result["step_id"] == "language"
 
     result = await hass.config_entries.flow.async_configure(
@@ -97,7 +97,7 @@ async def test_flow_user_init_data_unknown_error_and_recover_on_step_1(
         user_input=MOCK_DATA_USER_STEP,
     )
 
-    assert result["type"] == FlowResultType.FORM
+    assert result["type"] is FlowResultType.FORM
     assert result["step_id"] == "language"
 
     result = await hass.config_entries.flow.async_configure(
@@ -137,7 +137,7 @@ async def test_flow_user_init_data_unknown_error_and_recover_on_step_2(
         user_input=MOCK_DATA_USER_STEP,
     )
 
-    assert result["type"] == FlowResultType.FORM
+    assert result["type"] is FlowResultType.FORM
     assert result["step_id"] == "language"
 
     result = await hass.config_entries.flow.async_configure(
@@ -269,7 +269,7 @@ async def test_flow_reconfigure_init_data_unknown_error_and_recover_on_step_1(
         user_input={**MOCK_DATA_USER_STEP, CONF_COUNTRY: "DE"},
     )
 
-    assert result["type"] == FlowResultType.FORM
+    assert result["type"] is FlowResultType.FORM
     assert result["step_id"] == "language"
 
     result = await hass.config_entries.flow.async_configure(
@@ -318,7 +318,7 @@ async def test_flow_reconfigure_init_data_unknown_error_and_recover_on_step_2(
         user_input={**MOCK_DATA_USER_STEP, CONF_COUNTRY: "DE"},
     )
 
-    assert result["type"] == FlowResultType.FORM
+    assert result["type"] is FlowResultType.FORM
     assert result["step_id"] == "language"
 
     result = await hass.config_entries.flow.async_configure(

tests/components/datadog/test_config_flow.py

@@ -24,13 +24,13 @@ async def test_user_flow_success(hass: HomeAssistant) -> None:
         result = await hass.config_entries.flow.async_init(
             datadog.DOMAIN, context={"source": SOURCE_USER}
         )
-        assert result["type"] == FlowResultType.FORM
+        assert result["type"] is FlowResultType.FORM
 
         result2 = await hass.config_entries.flow.async_configure(
             result["flow_id"], user_input=MOCK_CONFIG
         )
         assert result2["title"] == f"Datadog {MOCK_CONFIG['host']}"
-        assert result2["type"] == FlowResultType.CREATE_ENTRY
+        assert result2["type"] is FlowResultType.CREATE_ENTRY
         assert result2["data"] == MOCK_DATA
         assert result2["options"] == MOCK_OPTIONS
 
@@ -48,7 +48,7 @@ async def test_user_flow_retry_after_connection_fail(hass: HomeAssistant) -> Non
         result2 = await hass.config_entries.flow.async_configure(
             result["flow_id"], user_input=MOCK_CONFIG
         )
-        assert result2["type"] == FlowResultType.FORM
+        assert result2["type"] is FlowResultType.FORM
         assert result2["errors"] == {"base": "cannot_connect"}
 
     with patch(
@@ -57,7 +57,7 @@ async def test_user_flow_retry_after_connection_fail(hass: HomeAssistant) -> Non
         result3 = await hass.config_entries.flow.async_configure(
             result["flow_id"], user_input=MOCK_CONFIG
         )
-        assert result3["type"] == FlowResultType.CREATE_ENTRY
+        assert result3["type"] is FlowResultType.CREATE_ENTRY
         assert result3["data"] == MOCK_DATA
         assert result3["options"] == MOCK_OPTIONS
 
@@ -104,13 +104,13 @@ async def test_options_flow_cannot_connect(hass: HomeAssistant) -> None:
         side_effect=OSError("connection failed"),
     ):
         result = await hass.config_entries.options.async_init(mock_entry.entry_id)
-        assert result["type"] == FlowResultType.FORM
+        assert result["type"] is FlowResultType.FORM
 
         result2 = await hass.config_entries.options.async_configure(
             result["flow_id"], user_input=MOCK_OPTIONS
         )
 
-        assert result2["type"] == FlowResultType.FORM
+        assert result2["type"] is FlowResultType.FORM
         assert result2["errors"] == {"base": "cannot_connect"}
 
     with patch(
@@ -119,7 +119,7 @@ async def test_options_flow_cannot_connect(hass: HomeAssistant) -> None:
         result3 = await hass.config_entries.options.async_configure(
             result["flow_id"], user_input=MOCK_OPTIONS
         )
-        assert result3["type"] == FlowResultType.CREATE_ENTRY
+        assert result3["type"] is FlowResultType.CREATE_ENTRY
         assert result3["data"] == MOCK_OPTIONS
 
 
@@ -141,7 +141,7 @@ async def test_import_flow(
             data=MOCK_CONFIG,
         )
 
-        assert result["type"] == FlowResultType.CREATE_ENTRY
+        assert result["type"] is FlowResultType.CREATE_ENTRY
         assert result["data"] == MOCK_DATA
         assert result["options"] == MOCK_OPTIONS
 
@@ -200,11 +200,11 @@ async def test_options_flow(hass: HomeAssistant) -> None:
         side_effect=OSError,
     ):
         result = await hass.config_entries.options.async_init(mock_entry.entry_id)
-        assert result["type"] == FlowResultType.FORM
+        assert result["type"] is FlowResultType.FORM
         result2 = await hass.config_entries.options.async_configure(
             result["flow_id"], user_input=new_options
         )
-        assert result2["type"] == FlowResultType.FORM
+        assert result2["type"] is FlowResultType.FORM
         assert result2["errors"] == {"base": "cannot_connect"}
 
     # ValueError Case
@@ -213,11 +213,11 @@ async def test_options_flow(hass: HomeAssistant) -> None:
         side_effect=ValueError,
     ):
         result = await hass.config_entries.options.async_init(mock_entry.entry_id)
-        assert result["type"] == FlowResultType.FORM
+        assert result["type"] is FlowResultType.FORM
         result2 = await hass.config_entries.options.async_configure(
             result["flow_id"], user_input=new_options
         )
-        assert result2["type"] == FlowResultType.FORM
+        assert result2["type"] is FlowResultType.FORM
         assert result2["errors"] == {"base": "cannot_connect"}
 
     # Success Case
@@ -231,7 +231,7 @@ async def test_options_flow(hass: HomeAssistant) -> None:
             result["flow_id"], user_input=new_options
         )
 
-        assert result["type"] == FlowResultType.CREATE_ENTRY
+        assert result["type"] is FlowResultType.CREATE_ENTRY
         assert result["data"] == new_options
         mock_instance.increment.assert_called_once_with("connection_test")
 
@@ -253,5 +253,5 @@ async def test_import_flow_abort_already_configured_service(
         data=MOCK_CONFIG,
     )
 
-    assert result["type"] == FlowResultType.ABORT
+    assert result["type"] is FlowResultType.ABORT
     assert result["reason"] == "already_configured"